Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040159
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformtrivialhave not tried2019-02-06 12:082019-03-28 14:56
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q2
StatusclosedFix in branchFixed in SCM revision9bc663af3896
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040159: remove unused guice depencency

DescriptionOpenbravo declares a dependency on guice, this was used for Google sign in when it used OpenID implementation. This was removed long time ago, but the dependency was kept.
Steps To ReproduceSee deployed libs.
Proposed SolutionRemove it.

Additional checks:

* No module published in CR makes of this library use from sources
* Google Sign in external module continues working
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0029894 closeddbaz Old Google Sign In, OpenID based, should be removed from core 

-  Notes
(0109625)
hgbot (developer)
2019-02-06 12:19

 Repository: erp/devel/pi
Changeset: 9bc663af38969177f83ea4362cc1def1ebcca865
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 05 15:33:59 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9bc663af38969177f83ea4362cc1def1ebcca865 [^]

fixed issue 40159: removed unused guice depencency

---
M legal/Licensing.txt
R modules/org.openbravo.client.application/lib/runtime/guice-2.0.jar
---
(0109878)
caristu (viewer)
2019-02-15 14:53
edited on: 2019-02-15 14:53

 Code reviewed + tested: Google Sign module continues working.
(0110799)
hudsonbot (viewer)
2019-03-28 14:56

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2019-02-06 12:08 alostale New Issue
2019-02-06 12:08 alostale Assigned To => platform
2019-02-06 12:08 alostale OBNetwork customer => No
2019-02-06 12:08 alostale Modules => Core
2019-02-06 12:08 alostale Triggers an Emergency Pack => No
2019-02-06 12:08 alostale Relationship added related to 0029894
2019-02-06 12:08 alostale Assigned To platform => alostale
2019-02-06 12:08 alostale Review Assigned To => caristu
2019-02-06 12:19 hgbot Checkin
2019-02-06 12:19 hgbot Note Added: 0109625
2019-02-06 12:19 hgbot Status new => resolved
2019-02-06 12:19 hgbot Resolution open => fixed
2019-02-06 12:19 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9bc663af38969177f83ea4362cc1def1ebcca865 [^]
2019-02-15 14:53 caristu Note Added: 0109878
2019-02-15 14:53 caristu Status resolved => closed
2019-02-15 14:53 caristu Fixed in Version => 3.0PR19Q2
2019-02-15 14:53 caristu Note Edited: 0109878 View Revisions
2019-03-28 14:56 hudsonbot Checkin
2019-03-28 14:56 hudsonbot Note Added: 0110799

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker