0040130: Set two new columns in C_Invoice as nullable and do not set a default value

Description

In Create Lines From Refactor introduced in 18Q4, two new columns were added to C_Invoice table: CREATEFROMORDERS and CREATEFROMINOUTS.

They were set as mandatory and default value 'N'.

In versions before PG 11 this configuration adds an important overhead when creating the columns. So to avoid a performance issue in the update process, it would be better to set both columns as nullable and without a default value.

Basically is to revert the changeset: https://code.openbravo.com/erp/devel/pi/rev/7d6426933ab5 [^]

Steps To Reproduce

In a HV table, like c_order, run:
ALTER TABLE c_order add COLUMN test character varying(1) default 'N';
Check it's very slow.

Now run:
ALTER TABLE c_order add COLUMN test2 character varying(1);
It's almost immediate.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0040119

closed

AtulOpenbravo

Set two new columns in C_Invoice as nullable and do not set a default value

Notes
(0109788) hgbot (developer) 2019-02-13 09:00	Repository: erp/backports/3.0PR18Q4.2 Changeset: e3d66bfad0a594251385cda8ca58233d560eafe4 Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Wed Feb 13 10:09:43 2019 +0530 URL: http://code.openbravo.com/erp/backports/3.0PR18Q4.2/rev/e3d66bfad0a594251385cda8ca58233d560eafe4 [^] Fixes Issue 40130:Set two new columns in C_Invoice as nullable and do not set a default value Remove NOT NULL constraint for columns CREATEFROMORDERS, CREATEFROMINOUTS Avoid setting DEFAULT value N for above columns. ** Remove check constraint either Y or N for above columns. --- M src-db/database/model/tables/C_INVOICE.xml M src-db/database/sourcedata/AD_COLUMN.xml ---

(0109792) Sandrahuguet (developer) 2019-02-13 09:10	Code review + testing ok

Issue History
Date Modified	Username	Field	Change
2019-02-04 20:10	AtulOpenbravo	Type	defect => backport
2019-02-04 20:10	AtulOpenbravo	Target Version	=> 3.0PR18Q4.2
2019-02-13 09:00	hgbot	Checkin
2019-02-13 09:00	hgbot	Note Added: 0109788
2019-02-13 09:00	hgbot	Status	scheduled => resolved
2019-02-13 09:00	hgbot	Resolution	open => fixed
2019-02-13 09:00	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR18Q4.2/rev/e3d66bfad0a594251385cda8ca58233d560eafe4 [^]
2019-02-13 09:10	Sandrahuguet	Review Assigned To	=> Sandrahuguet
2019-02-13 09:10	Sandrahuguet	Note Added: 0109792
2019-02-13 09:10	Sandrahuguet	Status	resolved => closed
2019-02-13 09:10	Sandrahuguet	Fixed in Version	=> 3.0PR18Q4.2