Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040113
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorhave not tried2019-01-16 18:142019-03-05 17:43
ReporterasiermartirenaView Statuspublic 
Assigned Toasiermartirena 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision17d148dc3fc3
ProjectionnoneETAnoneTarget VersionRR19Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040113: The updatePending function is executed too much times

DescriptionThe updatePending function is executed too many times during a single flow, when it should be executed only once setting the final status.
In addition, the function is executed also when the tab (the 'payment' tab) which has the buttons that are being shown/hidden or enabled/disabled is not shown. This function should't be executed in that case.
Steps To ReproduceOpen the Web POS and set a break point in the updatePending function.
Create a ticket in the Web POS --> Check that the updatePending function is being executed even if the payment tab is not shown
Add a payment --> Check that the updatePending function is called many times, when should be called only once
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks design defect 0039967 closedasiermartirena The updatePending function is executed too much times 

-  Notes
(0109869)
hgbot (developer)
2019-02-15 13:08

Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal
Changeset: 17d148dc3fc3a0c357741d1bec63a64c1caff49d
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Feb 15 13:07:22 2019 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/17d148dc3fc3a0c357741d1bec63a64c1caff49d [^]

Fixed issue 40113: The updatePending function is executed too much times

The updatePending is now called only when clicking in the payment tab, when changing the business partner (and the focus is in the payment tab), when the adjustPayment function is called (and the focus is in the payment tab and also the calculateReceipt process is not being executed) and after the calculateReceipt process has been finished (and the focus is in the payment tab).

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0110241)
jorge-garcia (developer)
2019-03-05 17:43

Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-02-04 09:17 marvintm Type design defect => backport
2019-02-04 09:17 marvintm Target Version => RR19Q1
2019-02-15 13:08 hgbot Checkin
2019-02-15 13:08 hgbot Note Added: 0109869
2019-02-15 13:08 hgbot Status scheduled => resolved
2019-02-15 13:08 hgbot Resolution open => fixed
2019-02-15 13:08 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/03faa9514189498f020b85f699de2573fc1ddcfb [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/17d148dc3fc3a0c357741d1bec63a64c1caff49d [^]
2019-03-05 17:43 jorge-garcia Review Assigned To => jorge-garcia
2019-03-05 17:43 jorge-garcia Note Added: 0110241
2019-03-05 17:43 jorge-garcia Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker