0039863: AverageAlgorithm class can be improved by showing the product.getSearchKey() on the OBException

diff -ru ORIGINAL/AverageAlgorithm.java MODIFICADO/AverageAlgorithm.java
--- a/src/org/openbravo/costing/AverageAlgorithm.java	2021-11-17 18:29:50.000000000 +0100
+++ b/src/org/openbravo/costing/AverageAlgorithm.java	2022-01-24 08:08:23.689506000 +0100
@@ -83,7 +83,7 @@
     final Costing currentCosting = getProductCost();
     if (currentCosting == null) {
       throw new OBException("@NoAvgCostDefined@ @Organization@: " + costOrg.getName()
-          + ", @Product@: " + transaction.getProduct().getName() + ", @Date@: "
+          + ", @Product@: " + transaction.getProduct().getIdentifier() + ", @Date@: "
           + OBDateUtils.formatDate(transaction.getTransactionProcessDate()));
     }
     BigDecimal cost = currentCosting.getCost();
diff -ru ORIGINAL/AverageCostAdjustment.java MODIFICADO/AverageCostAdjustment.java
--- a/src/org/openbravo/costing/AverageCostAdjustment.java	2021-11-17 18:29:50.000000000 +0100
+++ b/src/org/openbravo/costing/AverageCostAdjustment.java	2022-01-24 08:13:32.047491000 +0100
@@ -144,9 +144,9 @@
     final Costing costing = AverageAlgorithm.getProductCost(trxDate, basetrx.getProduct(),
         getCostDimensions(), getCostOrg());
     if (costing == null) {
-      throw new OBException(
-          "@NoAvgCostDefined@ @Organization@: " + getCostOrg().getName() + ", @Product@: "
-              + basetrx.getProduct().getName() + ", @Date@: " + OBDateUtils.formatDate(trxDate));
+      throw new OBException("@NoAvgCostDefined@ @Organization@: " + getCostOrg().getName()
+          + ", @Product@: " + basetrx.getProduct().getIdentifier() + ", @Date@: "
+          + OBDateUtils.formatDate(trxDate));
     }
     BigDecimal cost = null;
     // If current stock is zero the cost is not modified until a related transaction that modifies
@@ -471,7 +471,7 @@
           getCostDimensions(), getCostOrg());
       if (currentCosting == null) {
         throw new OBException("@NoAvgCostDefined@ @Organization@: " + getCostOrg().getName()
-            + ", @Product@: " + basetrx.getProduct().getName() + ", @Date@: "
+            + ", @Product@: " + basetrx.getProduct().getIdentifier() + ", @Date@: "
             + OBDateUtils.formatDate(new Date()));
       }
 
@@ -614,8 +614,8 @@
 
     if (costing == null) {
       String errorMessage = OBMessageUtils.parseTranslation("@NoAvgCostDefined@ @Organization@: "
-          + getCostOrg().getName() + ", @Product@: " + trx.getProduct().getName() + ", @Date@: "
-          + OBDateUtils.formatDate(trx.getMovementDate()));
+          + getCostOrg().getName() + ", @Product@: " + trx.getProduct().getIdentifier()
+          + ", @Date@: " + OBDateUtils.formatDate(trx.getMovementDate()));
       throw new OBException(errorMessage);
     }
     BigDecimal cost = costing.getCost();
diff -ru ORIGINAL/CostingAlgorithm.java MODIFICADO/CostingAlgorithm.java
--- a/src/org/openbravo/costing/CostingAlgorithm.java	2021-11-17 18:29:50.000000000 +0100
+++ b/src/org/openbravo/costing/CostingAlgorithm.java	2022-01-24 08:15:27.280155000 +0100
@@ -291,7 +291,7 @@
 
     if (stdCost == null && pp == null && orderLine == null) {
       throw new OBException("@NoPriceListOrStandardCostForProduct@ @Organization@: "
-          + costOrg.getName() + ", @Product@: " + transaction.getProduct().getSearchKey()
+          + costOrg.getName() + ", @Product@: " + transaction.getProduct().getIdentifier()
           + ", @Date@: " + OBDateUtils.formatDate(transaction.getTransactionProcessDate()));
     }
     Date stdCostDate = new Date(0L);
diff -ru ORIGINAL/CostingUtils.java MODIFICADO/CostingUtils.java
--- a/src/org/openbravo/costing/CostingUtils.java	2021-11-17 18:29:50.000000000 +0100
+++ b/src/org/openbravo/costing/CostingUtils.java	2022-01-24 08:14:49.091955000 +0100
@@ -153,7 +153,7 @@
     if (stdCost == null && pp == null) {
       throw new OBException(
           "@NoPriceListOrStandardCostForProduct@ @Organization@: " + org.getName() + ", @Product@: "
-              + product.getSearchKey() + ", @Date@: " + OBDateUtils.formatDate(costDate));
+              + product.getIdentifier() + ", @Date@: " + OBDateUtils.formatDate(costDate));
     } else if (stdCost != null && pp == null) {
       BigDecimal standardCost = getStandardCost(product, org, costDate, costDimensions, currency);
       return qty.abs().multiply(standardCost);
@@ -218,8 +218,9 @@
         recheckWithoutDimensions);
     if (stdCost == null) {
       // If no standard cost is found throw an exception.
-      throw new OBException("@NoStandardCostDefined@ @Organization@:" + org.getName()
-          + ", @Product@: " + product.getName() + ", @Date@: " + OBDateUtils.formatDate(date));
+      throw new OBException(
+          "@NoStandardCostDefined@ @Organization@:" + org.getName() + ", @Product@: "
+              + product.getIdentifier() + ", @Date@: " + OBDateUtils.formatDate(date));
     }
     return FinancialUtils.getConvertedAmount(stdCost.getCost(), stdCost.getCurrency(), convCurrency,
         date, org, FinancialUtils.PRECISION_COSTING);