Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039857
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-12-27 12:442019-01-07 17:04
Reporterjoniturralde93View Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR19Q2
StatusclosedFix in branchFixed in SCM revision9603cad2b028
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039857: If there is an error doing a cash management, there is no rollback of changed cashup data.

DescriptionAn error happens when inserting cash management: The cash management process failed to execute successfully. Please contact your system administrator.

But the cashup was already updated and no rollback is done. Cashup shows amount as if the cash management was completed.

This results in inconsistences:
-Difference in cashup report (POS) and cashup report (backoffice)
-Payment Method Status Cashup total different from Payment Method Cashup Events total.
Steps To Reproduce
This happened to a gold customer in a random way, and has happened other times producing incorrect cashup data.
Since we could not reproduce it the same way, we did this:

1. Log into POS Terminal: https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
2. Do a cashup.
3. Open developer tools and set a breakpoint in the following line:
    currentTransaction.executeSql(sql, params, silentFunction(successFunction), processError);
4. Do a cash management: Deposit 4000 in cash. Click done.
5. Debug and check when sql parameter is 'INSERT INTO cashmanagement...' and get the cashmanagement_id value.
6. Do another cash management: Deposit 4000 in cash. Click done.
7. Now, when sql parameter is 'INSERT INTO cashmanagement...' stop the execution and change cashmanagement_id value to the previous one so we can get an error (duplicated id). In the console: params[0]='previous cashmanagement id';
8. Continue the execution; an error is thrown: The cash management process failed to execute successfully. Please contact your system administrator.
9. There is an error doing the cash management, but the cashup data is updated anyway.
10. Do a cashup: Remaining -8.000.

You can check in backoffice:
11. Channel - Touchpoint -> Cash Up History -> Payment Method Status Cashup: Cashup total deposits: 8000
12. However, Payment Method Cashup Events only has one record: Amount 4000
13. Cash Up Report from backoffice shows DEPOSIT Cash - Backoffice transfer to VBS: 4,000.00
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0108841)
hgbot (developer)
2019-01-07 16:04

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1da2bb7c9184d74f93af5da112f65c9960b3ac83
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jan 07 20:34:39 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1da2bb7c9184d74f93af5da112f65c9960b3ac83 [^]

Related to issue 39857 : Added transaction to DAL Save method in Cash Managament functions

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0108842)
hgbot (developer)
2019-01-07 16:09

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9603cad2b028d0cfaf3155868611a440d276db68
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jan 07 20:39:21 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9603cad2b028d0cfaf3155868611a440d276db68 [^]

Fixed issue 39857 : Value true must be returned in WEBSQL Transaction Error callback handler

* If no value is returned or false is returned, execution will be continue with next execution
  If true is returned in error callback, transaction will be reverted

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---

- Issue History
Date Modified Username Field Change
2018-12-27 12:44 joniturralde93 New Issue
2018-12-27 12:44 joniturralde93 Assigned To => Retail
2018-12-27 12:44 joniturralde93 Resolution time => 1547679600
2018-12-27 12:44 joniturralde93 Triggers an Emergency Pack => No
2019-01-02 12:02 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2019-01-02 12:03 ranjith_qualiantech_com Status new => scheduled
2019-01-07 16:04 hgbot Checkin
2019-01-07 16:04 hgbot Note Added: 0108841
2019-01-07 16:09 hgbot Checkin
2019-01-07 16:09 hgbot Note Added: 0108842
2019-01-07 16:09 hgbot Status scheduled => resolved
2019-01-07 16:09 hgbot Resolution open => fixed
2019-01-07 16:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9603cad2b028d0cfaf3155868611a440d276db68 [^]
2019-01-07 17:04 guilleaer Review Assigned To => guilleaer
2019-01-07 17:04 guilleaer Status resolved => closed
2019-01-07 17:04 guilleaer Fixed in Version => RR19Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker