Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039804
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServerminorhave not tried2018-12-14 10:462018-12-17 14:55
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7e58ec2c2356
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039804: GenericBusinessPartnerSegmentationEventHandler throws NullPointerException if organization used to route is null

DescriptionThis issue [1] introduced a change that allows to specify the Organization column to be used by the GenericBusinessPartnerSegmentationEventHandler to know to what stores should a business partner be added.

The standard ad_org_id organization is not nullable, but other custom columns might be nullable. When the organization is null, the process fails and throws a NullPointerException

[1] https://issues.openbravo.com/view.php?id=39466 [^]
Steps To Reproduce- Create a nullable foreign key to ad_org_id in c_order (db column, ad column, ad field).
- As System Admin, open the Auto Add Business Partner to Store Tables, and update the record for c_order, by picking the new column in the Referenced Organization Column field.
- Change roles, and create an organization. The save will fail and a NullPointerException will be thrown.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0108636)
hgbot (developer)
2018-12-17 13:38

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 7e58ec2c235690880889cbdc7071eab3afe91b68
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Dec 17 13:37:53 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/7e58ec2c235690880889cbdc7071eab3afe91b68 [^]

Fixes issue 39804: Prevent NPE when routing a record whose organization is null

The GenericBusinessPartnerSegmentationEventHandler class usually decides what mobile servers should
be notified of a new business partner using the mandatory ad_org_id column.

But users can select another organization foreign key, and if that column is empty, the event
handler will not send the business partner info to any mobile server, instead of causing a NPE.

---
M src/org/openbravo/retail/storeserver/synchronization/eventhandler/GenericBusinessPartnerSegmentationEventHandler.java
---
(0108647)
mtaal (manager)
2018-12-17 14:55

 tested and reviewed

- Issue History
Date Modified Username Field Change
2018-12-14 10:46 AugustoMauch New Issue
2018-12-14 10:46 AugustoMauch Assigned To => AugustoMauch
2018-12-14 10:46 AugustoMauch Triggers an Emergency Pack => No
2018-12-17 13:38 hgbot Checkin
2018-12-17 13:38 hgbot Note Added: 0108636
2018-12-17 13:38 hgbot Status new => resolved
2018-12-17 13:38 hgbot Resolution open => fixed
2018-12-17 13:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/7e58ec2c235690880889cbdc7071eab3afe91b68 [^]
2018-12-17 13:38 AugustoMauch Review Assigned To => mtaal
2018-12-17 13:41 AugustoMauch Steps to Reproduce Updated View Revisions
2018-12-17 14:55 mtaal Note Added: 0108647
2018-12-17 14:55 mtaal Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker