Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0039683

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Copy Retail Store

major

always

2018-11-23 08:24

2018-12-14 13:52

Reporter

joniturralde93

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

urgent

Resolution

out of date

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Production - Confirmed Stable

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0039683: With OB versions previous to 18Q4, Copy Store process with manual role fails

Description

With OB versions previous to 18Q4 (due to core changes, in 18Q4 the process works as expected), Copy Store process with manual role fails.

In 17Q3.2 with module version 1.0.400 the process works fine with manual role, so probably a regression

Steps To Reproduce

- Install Copy Retail Store 1.0.700 in a OB version prior to 18Q4
- Create a manual role
- Log in as that role and execute copy store
- No error is thrown and it seems the process finished correctly, but a rollback was thrown and the organization was not cloned

Proposed Solution

newObject.getIdentifier() is where the process fails (as manual role only)

Tags

No tags attached.

parcheCDSRolManual.diff [^] (802 bytes) 2018-11-23 08:55 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/copystore/process/CopyStoreProcess.java b/src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
--- a/src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
+++ b/src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
@@ -320,6 +320,7 @@
       setOrgReady();
       addLog(LogLevel.WARN, OBMessageUtils.messageBD("OBPOSCS_LogoutLogin"));
     } catch (Exception e) {
+      e.printStackTrace();
       handleException(e);
     } catch (Throwable e) {
       hasErrors = true;
@@ -341,7 +342,9 @@
       } else {
         log.debug("Copy Store process finished in " + totalTime + " ms.");
       }
-
+      if (!hasErrors) {
+        OBDal.getInstance().commitAndClose();
+      }
       OBContext.restorePreviousMode();
     }
   }

issue 39683.patch [^] (1,608 bytes) 2018-12-12 12:44 [Show Content] [Hide Content]

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1544615023 -19800
#      Wed Dec 12 17:13:43 2018 +0530
# Node ID e2793be0ea3facd769229bee0cb07cd8c2eb7482
# Parent  190fc1599fc4f20598882fb1c6ebd5be22d5ee7c
Related to issue 39683 [1.0.610] : Modified Organization access while copying retail store

diff -r 190fc1599fc4 -r e2793be0ea3f src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
--- a/src/org/openbravo/retail/copystore/process/CopyStoreProcess.java	Tue Jul 17 09:04:19 2018 +0200
+++ b/src/org/openbravo/retail/copystore/process/CopyStoreProcess.java	Wed Dec 12 17:13:43 2018 +0530
@@ -919,10 +919,6 @@
    * Refreshes permissions to take into account recently created organization
    */
   private void fixPermissions() throws ServletException {
-    // Make new stuff visible
-    OBContext.getOBContext().addWritableOrganization(newStore.getId());
-    OBContext.getOBContext().getOrganizationStructureProvider().reInitialize();
-
     VariablesSecureApp vars = RequestContext.get().getVariablesSecureApp();
     DalConnectionProvider cp = new DalConnectionProvider(false);
     OBContext ctx = OBContext.getOBContext();
@@ -931,6 +927,10 @@
         .getLanguage(), ctx.getLanguage().isRTLLanguage() ? "Y" : "N", ctx.getRole().getId(), ctx
         .getCurrentClient().getId(), ctx.getCurrentOrganization().getId(), ctx.getWarehouse()
         .getId());
+
+    // Make new stuff visible
+    OBContext.getOBContext().addWritableOrganization(newStore.getId());
+    OBContext.getOBContext().getOrganizationStructureProvider().reInitialize();
   }
 
   /**

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0108569) ranjith_qualiantech_com (developer) 2018-12-13 08:03	Issue rises in Copy Store Module 1.0.700 due the Organization access is not present while copying data for new store. Attached patch (issue 39683.patch) will fix this issue.

(0108612) marvintm (manager) 2018-12-14 13:52	This issue was fixed in subsequent versions of the module, but the patches attached to it can be used to prevent it in case somebody cannot update for some reason.

Issue History
Date Modified	Username	Field	Change
2018-11-23 08:24	joniturralde93	New Issue
2018-11-23 08:24	joniturralde93	Assigned To	=> Retail
2018-11-23 08:24	joniturralde93	Triggers an Emergency Pack	=> No
2018-11-23 08:55	joniturralde93	File Added: parcheCDSRolManual.diff
2018-11-23 09:21	joniturralde93	Resolution time	=> 1544742000
2018-11-23 09:25	joniturralde93	Description Updated	View Revisions
2018-11-26 10:11	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2018-11-26 10:11	ranjith_qualiantech_com	Status	new => scheduled
2018-11-28 07:54	rafaroda	Issue Monitored: rafaroda
2018-12-12 12:44	ranjith_qualiantech_com	File Added: issue 39683.patch
2018-12-13 08:03	ranjith_qualiantech_com	Note Added: 0108569
2018-12-14 10:42	egoitz	Regression level	=> Production - Confirmed Stable
2018-12-14 13:52	marvintm	Review Assigned To	=> marvintm
2018-12-14 13:52	marvintm	Note Added: 0108612
2018-12-14 13:52	marvintm	Status	scheduled => closed
2018-12-14 13:52	marvintm	Resolution	open => out of date

Copyright © 2000 - 2009 MantisBT Group