Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0039603 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | random | 2018-11-07 15:03 | 2018-11-13 10:43 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR18Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | a456297ffb38 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR18Q4 | |||
| OS | Any | Database | PostgreSQL | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2016-08-10 | |||||||
| Regression introduced in release | 3.0PR16Q4 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/88ea14de1a84e176f457750118a6d4823588d7d2 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0039603: can't update information after killing a connection | |||||||
| Description | With Audit trail active, killing DB connections can cause random failures while trying to update information. Technically the problem is: 1. Pool keeps PooledConnections each of them associated with a physical DB connection 2. When one of those physical DB connections is killed and a PooledConnection is going to be used (borrowed from the pool), Tomcat transparently creates a new physical connection and associates it with the existing PooledConnection instance. 3. Openbravo, in order not to recreate ad_context_info temporary table on each borrow, does it when a new connection is created and marks it as already initialized. This flag is set in the PooledConnection, incorrectly assuming a PooledConnection instance is always tight to the same Connection instance 4. Because of 2nd step, a new uninitialized Connection is associated with an existing PooledConnection marked as initialized, so queries expecting the temporary table to be present will fail. This situation remains until the connection is finally returned to the pool. | |||||||
| Steps To Reproduce | In a Professional instance: 0. Configure DB pool to a fixed 5 connections: db.pool.initialSize=5 db.pool.minIdle=5 db.pool.maxActive=5 1. As System Admin open Table window 2. Select any table and mark it as fully audited 3. Restart Tomcat 4. Kill the 5 connections that are in pool: in psql execute select pg_terminate_backend(pid), pid from pg_stat_activity where application_name ='openbravo'; 5. Log in 6. Open Process Request window 7. Create a new record and save -> Saving failed. ERROR: relation "ad_context_info" does not exist Position: | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0107802) hgbot (developer) 2018-11-08 12:01 |
Repository: erp/backports/3.0PR18Q4 Changeset: 6532f60f9281670d35e52e2c237883e465fa9aec Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Nov 08 10:19:51 2018 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/6532f60f9281670d35e52e2c237883e465fa9aec [^] fixed bug 39603: can't execute DB updates after killing a connection Audit Trail infrastructure (ad_context_info in PG) is initialized each time a new connection is created. We incorrectly assumed a PooledConnection is always associated with a single Connection instance, which is not true in case Connection gets corrupted or killed, in this case Tomcat pool transparently re-associates a new connection with existent PooledConnection. We are now caching in PooledConnection actual Connection to detect this case so it can be initialized again. --- M modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/ConnectionInitializerInterceptor.java --- |
|
(0107874) caristu (developer) 2018-11-13 10:43 |
Code reviewed + tested OK. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-11-07 15:09 | alostale | Type | defect => backport |
| 2018-11-07 15:09 | alostale | Target Version | => 3.0PR18Q4 |
| 2018-11-08 12:01 | hgbot | Checkin | |
| 2018-11-08 12:01 | hgbot | Note Added: 0107802 | |
| 2018-11-08 12:01 | hgbot | Status | scheduled => resolved |
| 2018-11-08 12:01 | hgbot | Resolution | open => fixed |
| 2018-11-08 12:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/6532f60f9281670d35e52e2c237883e465fa9aec [^] |
| 2018-11-08 12:01 | hgbot | Checkin | |
| 2018-11-08 12:01 | hgbot | Note Added: 0107803 | |
| 2018-11-08 12:01 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/6532f60f9281670d35e52e2c237883e465fa9aec [^] => http://code.openbravo.com/erp/backports/3.0PR18Q3.3/rev/a456297ffb38ecfa584a54518d251cc3da9cda12 [^] |
| 2018-11-13 10:39 | caristu | Note Deleted: 0107803 | |
| 2018-11-13 10:43 | caristu | Note Added: 0107874 | |
| 2018-11-13 10:43 | caristu | Status | resolved => closed |
| 2018-11-13 10:43 | caristu | Fixed in Version | => 3.0PR18Q4 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |