Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039536
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2018-10-25 14:022018-12-07 04:36
Reporterinaki_garciaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionopenFixed in Version
StatusscheduledFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039536: [RR18Q4] Total Amount discounts get removed when splitting lines

DescriptionA ticket with a Total Amount type discount applied, which shows on all lines, gets removed when using the Split Lines feature. Said discount cannot be reapplied again unless
the ticket is removed.

Further observations after the steps to reproduce are executed:

- Adding a product which requires providing extra contact info ("Item Declaration" popup appears) throws the following error and makes the POS unusable (check the attached "2018-10-11 13-33-09.png"
screenshot and the following error log message). 'Contact customer info for product' module is required to be installed and the 'WEB POS Show BusinessPartner Birth Information' set to 'Y' to execute this step:

Uncaught TypeError: discountRule.set is not a function
    at 2de4b76c91e46e250b8a916b152d94d1.js:3516
    at Array.forEach (<anonymous>)
    at Function.b.each.b.forEach (underscore-1.3.3.min.js:11)
    at Object.manualByTotalPromotionsExecutor (2de4b76c91e46e250b8a916b152d94d1.js:3516)
    at Object.implementation (2de4b76c91e46e250b8a916b152d94d1.js:3516)
    at G.d.applyRule (2de4b76c91e46e250b8a916b152d94d1.js:1915)
    at G.d.nextAction (2de4b76c91e46e250b8a916b152d94d1.js:1903)
    at G.d.<anonymous> (2de4b76c91e46e250b8a916b152d94d1.js:1903)
    at g.Model.trigger (backbone-0.9.2.min.js:9)
    at 2de4b76c91e46e250b8a916b152d94d1.js:1912


- If another type of discount is applied (such as "Fixed Percentage Disount" type discount) for one or more lines, the Total Amount discount reappears only for that/those line(s) (check the attached "Screenshot from 2018-10-25 14-08-11.png" screenshot)
Steps To ReproducePrecondition: the "Discount rules for Retail by total" module is required to be installed and a Total Amount type discount configured.

Use this test case in as a guide to configure a Total Amount discount:

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10507 [^]

0. Log into the WebPOS
1. Add some products to the ticket to insert several lines and quantities
2. Open the "Receipt disounts" popup by selecting it from the dropdown menu
3. Apply the previously created Total Amount to the ticket by selecting it and clicking on "Apply"
4. Select a line with Quantity greater than 1, and click on the "Split" option from the right pane
5. Click "Apply" on the "Split" popup
6. NOTICE that the applied discount has dissappeared from all lines

Steps are reproduced in the attached video
TagsNo tags attached.
Attached Files? file icon ScreenRecording 2018-10-25 at 13.01.54.avi [^] (1,777,754 bytes) 2018-10-25 14:04
png file icon 2018-10-11 13-33-09.png [^] (225,087 bytes) 2018-10-25 14:06


png file icon Screenshot from 2018-10-25 14-08-11.png [^] (171,589 bytes) 2018-10-25 14:08

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0108318)
hgbot (developer)
2018-12-06 14:22

Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: acc28bc9b14186d976bacb2800869861099e9483
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 06 18:52:12 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/acc28bc9b14186d976bacb2800869861099e9483 [^]

Related to issue 39536 : Modified Discount Per Total Amount calculation

* Removed unnecessary attribute 'qtyOffer' for Disccount Per Total Amount calculation

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---
(0108320)
hgbot (developer)
2018-12-07 04:14

Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 8cc9dda150f603fc151aa86a7fd8fd143ed5e740
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Dec 07 08:44:18 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/8cc9dda150f603fc151aa86a7fd8fd143ed5e740 [^]

Related to issue 39536 : Backed out changeset: acc28bc9b141

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---

- Issue History
Date Modified Username Field Change
2018-10-25 14:02 inaki_garcia New Issue
2018-10-25 14:02 inaki_garcia Assigned To => Retail
2018-10-25 14:02 inaki_garcia Triggers an Emergency Pack => No
2018-10-25 14:04 inaki_garcia File Added: ScreenRecording 2018-10-25 at 13.01.54.avi
2018-10-25 14:06 inaki_garcia File Added: 2018-10-11 13-33-09.png
2018-10-25 14:08 inaki_garcia File Added: Screenshot from 2018-10-25 14-08-11.png
2018-10-25 14:09 inaki_garcia Description Updated View Revisions
2018-10-25 14:10 inaki_garcia Description Updated View Revisions
2018-10-25 14:11 inaki_garcia Description Updated View Revisions
2018-11-23 11:03 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2018-11-23 11:04 ranjith_qualiantech_com Status new => scheduled
2018-12-06 14:22 ranjith_qualiantech_com Regression level => Packaging and release
2018-12-06 14:22 ranjith_qualiantech_com Regression date => 2018-01-12
2018-12-06 14:22 ranjith_qualiantech_com Regression introduced in release => main
2018-12-06 14:22 ranjith_qualiantech_com Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/edd903ba2305#l8.75 [^]
2018-12-06 14:22 hgbot Checkin
2018-12-06 14:22 hgbot Note Added: 0108318
2018-12-07 04:14 hgbot Checkin
2018-12-07 04:14 hgbot Note Added: 0108320
2018-12-07 04:36 ranjith_qualiantech_com Regression level Packaging and release =>
2018-12-07 04:36 ranjith_qualiantech_com Regression date 2018-01-12 =>
2018-12-07 04:36 ranjith_qualiantech_com Regression introduced in release main =>
2018-12-07 04:36 ranjith_qualiantech_com Regression introduced by commit https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/edd903ba2305#l8.75 [^] =>


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker