Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039476
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-10-18 10:032018-11-23 09:30
ReporterlmonrealView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR19Q1
StatusclosedFix in branchFixed in SCM revision7d2984bb50e9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039476: Fast Browse- There is no warning when a product is reassigned to another category and the space is already occupied by other

DescriptionWith Fast Browse selected If I have a product with a row and a column assigned in the assortment and I change his category and there is already another product with the same row and column assigned to the new category, the first product is not displayed and there is no error message or warning to user.
Steps To ReproduceUsing fast browse:


1. Have a product “Glide wax” under category “Ski”, in assortment his space assigned is 1 row and 1 column
2. Have a product “Baby carrier” under category “Back packs and travels” in assortment his space assigned is 1 row and 1 column
3. Go to product tab and search “Glide wax”, reassing category to “Back packs and travels”, no error or warning is displayed
4. Go to Webpos and check category “Back packs and travels”, product “Baby carrier” is displayed but “Glide wax” is not displayed because that space was already assigned. User has not received any warning
Proposed SolutionShow a message to warn user that the space was already occupied and that the product should be assigned to another row and column
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0107629)
hgbot (developer)
2018-10-29 04:15

Repository: erp/pmods/org.openbravo.retail.fastbrowse
Changeset: 177c47fc206c6f6a1b656916807c94d4cbebfd76
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Oct 28 17:56:24 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/177c47fc206c6f6a1b656916807c94d4cbebfd76 [^]

Fixed issue 39476: Fast Browse- There is no warning when a product is reassigned
to another category and the space is already occupied by other

- A new Event Observer was added to check if there exists another product with
the same product category and column/row combination

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A src/org/openbravo/retail/fastbrowse/event/FastBrowseProductCategoryEventHandler.java
---
(0107638)
hgbot (developer)
2018-10-29 12:36

Repository: erp/pmods/org.openbravo.retail.fastbrowse
Changeset: 1155e2839aa9d5468afe2502afbab7abf885b8d5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Oct 29 12:36:48 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/1155e2839aa9d5468afe2502afbab7abf885b8d5 [^]

Related to issue 39476. Backed out change because it's affecting jUnit tests, causing NPE

---
M src-db/database/sourcedata/AD_MESSAGE.xml
R src/org/openbravo/retail/fastbrowse/event/FastBrowseProductCategoryEventHandler.java
---
(0107639)
marvintm (manager)
2018-10-29 12:37

Backed out change because it's breaking some junit tests, due to NullPointerException in the event handler
(0107640)
hgbot (developer)
2018-10-29 15:20

Repository: erp/pmods/org.openbravo.retail.fastbrowse
Changeset: 24ce5c4e02bff87154ed16e5bca92b4db1ecb5d6
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Oct 29 10:08:26 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/24ce5c4e02bff87154ed16e5bca92b4db1ecb5d6 [^]

Fixed issue 39476: Fast Browse- There is no warning when a product is reassigned
to another category and the space is already occupied by other

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A src/org/openbravo/retail/fastbrowse/event/FastBrowseProductCategoryEventHandler.java
---
(0107951)
marvintm (manager)
2018-11-16 13:22

The new ad_message, and most probably some of the logic, could be reused and shared with an existing event handler.
(0107995)
hgbot (developer)
2018-11-19 19:45

Repository: erp/pmods/org.openbravo.retail.fastbrowse
Changeset: 7d2984bb50e9aaa7b31d506c992b89132f2eb32b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Nov 18 12:22:59 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/7d2984bb50e9aaa7b31d506c992b89132f2eb32b [^]

Fixed issue 39476: Fast Browse- There is no warning when a product is reassigned
to another category and the space is already occupied by other

- Event Observer was modified to check in all assortments that the product appear
not only into the main organization assortment.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/fastbrowse/event/FastBrowseProductCategoryEventHandler.java
---
(0108067)
jorge-garcia (reporter)
2018-11-23 09:30

Code reviewed and tested

- Issue History
Date Modified Username Field Change
2018-10-18 10:03 lmonreal New Issue
2018-10-18 10:03 lmonreal Assigned To => Retail
2018-10-18 10:03 lmonreal Triggers an Emergency Pack => No
2018-10-23 14:10 lmonreal Description Updated View Revisions
2018-10-26 00:16 rqueralta Assigned To Retail => rqueralta
2018-10-26 00:16 rqueralta Status new => scheduled
2018-10-29 04:15 hgbot Checkin
2018-10-29 04:15 hgbot Note Added: 0107629
2018-10-29 04:15 hgbot Status scheduled => resolved
2018-10-29 04:15 hgbot Resolution open => fixed
2018-10-29 04:15 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/177c47fc206c6f6a1b656916807c94d4cbebfd76 [^]
2018-10-29 12:36 hgbot Checkin
2018-10-29 12:36 hgbot Note Added: 0107638
2018-10-29 12:37 marvintm Note Added: 0107639
2018-10-29 12:37 marvintm Status resolved => new
2018-10-29 12:37 marvintm Resolution fixed => open
2018-10-29 15:20 hgbot Checkin
2018-10-29 15:20 hgbot Note Added: 0107640
2018-10-29 15:20 hgbot Status new => resolved
2018-10-29 15:20 hgbot Resolution open => fixed
2018-10-29 15:20 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/177c47fc206c6f6a1b656916807c94d4cbebfd76 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/24ce5c4e02bff87154ed16e5bca92b4db1ecb5d6 [^]
2018-11-16 13:22 marvintm Note Added: 0107951
2018-11-16 13:22 marvintm Status resolved => new
2018-11-16 13:22 marvintm Resolution fixed => open
2018-11-19 19:45 hgbot Checkin
2018-11-19 19:45 hgbot Note Added: 0107995
2018-11-19 19:45 hgbot Status new => resolved
2018-11-19 19:45 hgbot Resolution open => fixed
2018-11-19 19:45 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/24ce5c4e02bff87154ed16e5bca92b4db1ecb5d6 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.fastbrowse/rev/7d2984bb50e9aaa7b31d506c992b89132f2eb32b [^]
2018-11-22 17:23 jorge-garcia Review Assigned To => jorge-garcia
2018-11-23 09:30 jorge-garcia Note Added: 0108067
2018-11-23 09:30 jorge-garcia Status resolved => closed
2018-11-23 09:30 jorge-garcia Fixed in Version => RR19Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker