Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0039413 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] B. User interface | major | always | 2018-09-28 11:22 | 2018-10-16 10:48 | |||
| Reporter | neil_smith | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR18Q3.2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 2ed3054e6a2b | ||||
| Projection | none | ETA | none | Target Version | 3.0PR18Q3.2 | |||
| OS | Any | Database | @0@ | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | caristu | |||||||
| OBNetwork customer | No | |||||||
| Web browser | Mozilla Firefox | |||||||
| Modules | User Interface Application | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0039413: Quantities replaced by line numer (only displayed in window, not in database) | |||||||
| Description | When editing a record with a line number (orderline, inoviceline, inoutline), if the quantity is updated and click on the header (without changing field), the line numer is displayed in the updated quantity. | |||||||
| Steps To Reproduce | 1. Go to the sales order window, double click on a sale order to go into form view 2. Double click on a sale order line to go in form view 3. Update the quantity on the sale order line and stay on field (no tab or clicking on another field) 4. Click in the sale order header It saves the quantity and displays the line numer in the updated quantity. If you change field (tab or click else where) or are not in form view on the header when you click on it, it does not do this. If you refresh the data, it displays the quantity with what you entered, the information in the database is correct. The problem is if you go back to the line and change something else and save, the wrong quantity is saved in the database!!! For me, it does not work on the orders, shipments and invoices (sales and purchases). I didn't try other windows where there is a line number... It has the same comportment in creation if the last field you enter is the quantity, don't change fields and click on the header (always in form view). This is a big issue as the quantity can be saved wrong in certain conditions! | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0107213) hgbot (developer) 2018-10-08 13:10 |
Repository: erp/backports/3.0PR18Q3.2 Changeset: 2ed3054e6a2b1c813fa94c4a95652507f934b3ab Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Oct 08 13:10:27 2018 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR18Q3.2/rev/2ed3054e6a2b1c813fa94c4a95652507f934b3ab [^] Fixes issue 39413: Prevents unintended formitem value change if focus changes There was a problem in this redraw function [1]. It did the following: 1) Get the value of the focused item (this.getFocusItem().getValue()) 2) Redraw the form (this.Super('redraw', arguments);) 3) Restore the value of the focused item if the value changed during the redraw (this.getFocusItem().setElementValue(focusItemValue);) The problem was that under some circumstances the focusedItem itself changed during the redraw, so the form items returned by this.getFocusItem() in steps 1) and 3) are different, and the value from one form item was copied into another form item. This problem has been fixed by storing in a variable the focused form item before the step 1), and the use that reference in the rest of the function instead of reinvoking this.getFocusItem() [1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js#l2157 [^] --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js --- |
|
(0107320) caristu (viewer) 2018-10-16 10:48 |
Code reviewed + tested OK. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-10-05 11:36 | AugustoMauch | Type | defect => backport |
| 2018-10-05 11:36 | AugustoMauch | Target Version | => 3.0PR18Q3.2 |
| 2018-10-08 13:10 | hgbot | Checkin | |
| 2018-10-08 13:10 | hgbot | Note Added: 0107213 | |
| 2018-10-08 13:10 | hgbot | Status | scheduled => resolved |
| 2018-10-08 13:10 | hgbot | Resolution | open => fixed |
| 2018-10-08 13:10 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR18Q3.2/rev/2ed3054e6a2b1c813fa94c4a95652507f934b3ab [^] |
| 2018-10-08 14:56 | AugustoMauch | Assigned To | platform => AugustoMauch |
| 2018-10-08 14:56 | AugustoMauch | Review Assigned To | => caristu |
| 2018-10-08 14:56 | AugustoMauch | Web browser | Mozilla Firefox => Mozilla Firefox |
| 2018-10-16 10:48 | caristu | Note Added: 0107320 | |
| 2018-10-16 10:48 | caristu | Status | resolved => closed |
| 2018-10-16 10:48 | caristu | Fixed in Version | => 3.0PR18Q3.2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |