Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0039380 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] 00. Application dictionary | major | have not tried | 2018-09-28 15:02 | 2019-06-26 04:55 | |||
| Reporter | Sandrahuguet | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR19Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d8730c85d885 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | 7.x | |||
| OS Version | Openbravo Appliance 14.04 | Database version | 9.3.x | Ant version | 1.9.x | |||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | caristu | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0039380: Support using both "-columnName" and "columnName desc" in HQL order by clauses | |||||||
| Description | The AdvancedQueryBuilder does different things to HQL order by clauses built like "-columnName" and to clauses built like "columnName desc", even though they should be equivalent. There are two places where AdvancedQueryBuilder tries to parse the descendir order by the hql order by clause columns: - [1], to detect if all columns are in descending order, to add the id column in descending order too - [2], to parse the hql order by clase part to detect if it is a function If desc is used instead of -, [1] does not work properly. If - is used instead of desc, [2] does not work properly. Given that there are already several hql order by clauses defined with desc and with -, it is better to support both than to try to enforce using one of them [1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java#l1385 [^] [2] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java#l1415 [^] | |||||||
| Steps To Reproduce | Use following expression to find all occurrences in PI: grep -ri 'Hqlorderbyclause' | grep desc | |||||||
| Proposed Solution | Replace DESC by "-" in hql order by clause. | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0107075) Sandrahuguet (viewer) 2018-09-28 15:04 |
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml:<!--1EA4A3F31A27483A8C6E93176AE912D3--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml:<!--2A9BA5FDA0F8470D881F8EA9DEDCC598--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml:<!--3FD616A223E44621806A8573068B6C62--> <HQLORDERBYCLAUSE><![CDATA[obSelected desc, dueDate, amount, documentno]]></HQLORDERBYCLAUSE> modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml:<!--81644A22CC4D4B879AA71C33C30E00A4--> <HQLORDERBYCLAUSE><![CDATA[obSelected desc, paymentPriority, expectedDate, coalesce(orderDocumentno, invoiceorderDocumentno)]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--0B6731F4F17A4A7AB00960148051E969--> <HQLORDERBYCLAUSE><![CDATA[sh.documentNo desc, e.lineNo asc]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--1B49A74CF8314D02B7F41B6595A169D4--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--21587C5E538E48758ED0C59B621DA91B--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--21790166FE1A47A284F9EA6F68695ACE--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--275327A580BF446DAA6502BFBCCDA20C--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--3595EBAC842D45FC95B96135C7799F0A--> <HQLORDERBYCLAUSE><![CDATA[validFromDate desc]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--38A56E62067242B39D3815E434D5BC48--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--3ACD18ADFBA8406086852B071250C481--> <HQLORDERBYCLAUSE><![CDATA[documentNo desc]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--52B21E690E024445A9F3B9F0A880AE8F--> <HQLORDERBYCLAUSE><![CDATA[o.documentNo desc, e.lineNo, e.product]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--5734406CB06D492CA9C5E31960CA7628--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--6EE02C9681A74406A129F1D96D022BA4--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--7209E9DB66CC47CF933AAEC8E3F873B6--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--7309F57E84264F6BB8F2A5E4A976ED93--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--89F074E609E841A7ACD0D4A19B6AF476--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--93787F9E92BD433EA7FD0E61227BC126--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--A399D7976DD74832A0D56586E46D149A--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--A55C6E2F874F4CD0B7AEDE4362701EA2--> <HQLORDERBYCLAUSE><![CDATA[creationDate desc]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--B01BFDF1E6B24CF4941807CA7F77A073--> <HQLORDERBYCLAUSE><![CDATA[obSelected desc, io.movementDate desc, io.documentNo desc, iol.lineNo]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--B1A51802BAF64D34BC59B91EA36D5064--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--B67386FF3EA94579BA9BA22353B5B897--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--C68533256F40484C89006BF00F669CD5--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--D7B93F8414E643DD8C1103D6FEF0B568--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--DA845735FBB34548B04F1908E2089CEC--> <HQLORDERBYCLAUSE><![CDATA[creationDate desc]]></HQLORDERBYCLAUSE> src-db/database/sourcedata/AD_TAB.xml:<!--EE01CF71A3D741E8B2B7204ADCBBF7A8--> <HQLORDERBYCLAUSE><![CDATA[accountingSchema.name, accountingDate, abs(debit) desc, credit desc, value]]></HQLORDERBYCLAUSE> 34804:-<!--242--> <HQLORDERBYCLAUSE><![CDATA[accountingDate desc, id desc]]></HQLORDERBYCLAUSE> |
|
(0112857) hgbot (developer) 2019-06-18 13:06 |
Repository: erp/devel/pi Changeset: d8730c85d885fae3cdd402527b10460383672ed3 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Jun 17 16:02:45 2019 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/d8730c85d885fae3cdd402527b10460383672ed3 [^] Fixes issue 39380: Both desc and - can be used in HQL Where Clauses The AdvancedQueryBuilder class did not behave the same when an HQL where clause used - instead of desc in descending order columns (i.e. -quantity vs quantity desc). There were two places that behaved differently: - The code that checked if all columns were ordered descending. - The pattern used to parse if a where clause part was a function. --- M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java --- |
|
(0112894) hudsonbot (viewer) 2019-06-19 16:02 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5a31264dd0f8 [^] Maturity status: Test |
|
(0112969) hgbot (developer) 2019-06-24 11:53 |
Repository: erp/devel/pi Changeset: d2cdc9ad4da2f94feaabec4e724015443fe06cbc Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Mon Jun 24 11:51:40 2019 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/d2cdc9ad4da2f94feaabec4e724015443fe06cbc [^] related to bug 39380: handle special case Take also into account when order by expression ends with "desc" or "DESC". --- M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java --- |
|
(0112970) caristu (viewer) 2019-06-24 11:54 |
Reviewed + tested OK. |
|
(0113017) hudsonbot (viewer) 2019-06-26 04:55 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0c724fa9726e [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-09-28 15:02 | Sandrahuguet | New Issue | |
| 2018-09-28 15:02 | Sandrahuguet | Assigned To | => markmm82 |
| 2018-09-28 15:02 | Sandrahuguet | OBNetwork customer | => No |
| 2018-09-28 15:02 | Sandrahuguet | Modules | => Core |
| 2018-09-28 15:02 | Sandrahuguet | Triggers an Emergency Pack | => No |
| 2018-09-28 15:02 | Sandrahuguet | Summary | In tabs the hql order by clause must use "-" instead of "DESC" => In tabs, the hql order by clause must use "-" instead of "DESC" |
| 2018-09-28 15:02 | Sandrahuguet | Description Updated | View Revisions |
| 2018-09-28 15:03 | Sandrahuguet | Tag Attached: Performance | |
| 2018-09-28 15:03 | Sandrahuguet | Relationship added | related to 0039293 |
| 2018-09-28 15:04 | Sandrahuguet | Note Added: 0107075 | |
| 2018-09-28 15:08 | Sandrahuguet | Relationship added | related to 0039381 |
| 2019-01-07 18:05 | markmm82 | Status | new => scheduled |
| 2019-06-13 16:23 | AugustoMauch | Assigned To | markmm82 => AugustoMauch |
| 2019-06-13 16:34 | AugustoMauch | Type | defect => feature request |
| 2019-06-13 16:45 | AugustoMauch | Relationship replaced | has duplicate 0039381 |
| 2019-06-13 16:55 | AugustoMauch | Summary | In tabs, the hql order by clause must use "-" instead of "DESC" => Support using both "-columnName" and "columnName desc" in HQL order by clauses |
| 2019-06-13 16:55 | AugustoMauch | Description Updated | View Revisions |
| 2019-06-18 13:05 | AugustoMauch | Review Assigned To | => caristu |
| 2019-06-18 13:06 | hgbot | Checkin | |
| 2019-06-18 13:06 | hgbot | Note Added: 0112857 | |
| 2019-06-18 13:06 | hgbot | Status | scheduled => resolved |
| 2019-06-18 13:06 | hgbot | Resolution | open => fixed |
| 2019-06-18 13:06 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d8730c85d885fae3cdd402527b10460383672ed3 [^] |
| 2019-06-19 16:02 | hudsonbot | Checkin | |
| 2019-06-19 16:02 | hudsonbot | Note Added: 0112894 | |
| 2019-06-24 11:53 | hgbot | Checkin | |
| 2019-06-24 11:53 | hgbot | Note Added: 0112969 | |
| 2019-06-24 11:54 | caristu | Note Added: 0112970 | |
| 2019-06-24 11:54 | caristu | Status | resolved => closed |
| 2019-06-24 11:54 | caristu | Fixed in Version | => 3.0PR19Q3 |
| 2019-06-26 04:55 | hudsonbot | Checkin | |
| 2019-06-26 04:55 | hudsonbot | Note Added: 0113017 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |