Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039332
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2018-09-20 19:272018-09-25 20:57
ReportercaristuView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q4
StatusclosedFix in branchFixed in SCM revision462eab118a3b
ProjectionnoneETAnoneTarget Version
OSAnyDatabasePostgreSQLJava version
OS VersionDatabase version11Ant version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039332: PG 11: ad_db_modified function fails

DescriptionThe ad_db_modified fails in PostgreSQL11, because it is using a query[1] that makes use of the proisagg column which does not longer exists in the pg_proc catalog table.

Note that the function is failing silently because on case of error, the exception is caught and 'N' is returned.

[1] https://code.openbravo.com/erp/devel/pi/file/tip/src-db/database/model/prescript-PostgreSql.sql#l1341 [^]
Steps To ReproduceUsing PostgreSQL 11:
1. Apply the attached patch (just for testing) that raises an exception in case an error happens during the execution of the ad_db_modified function.
2. Run ant install.source. It fails:

database.postcreate.POSTGRE:
      [sql] Executing commands
      [sql] Failed to execute: SELECT AD_DB_MODIFIED('Y')

BUILD FAILED
/home/openbravo/src/openbravo/pi/build.xml:686: The following error occurred while executing this line:
/home/openbravo/src/openbravo/pi/src-db/database/build-create.xml:53: The following error occurred while executing this line:
/home/openbravo/src/openbravo/pi/src-db/database/build-create.xml:255: org.postgresql.util.PSQLException: ERROR: ERROR!!!!

TagsNo tags attached.
Attached Filesdiff file icon ad_db_modified_error.diff [^] (395 bytes) 2018-09-21 08:16 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039271 closedalostale PG 11: error when updating database 
blocks feature request 0039270 closedplatform support PostgreSQL 11 

-  Notes
(0106990)
hgbot (developer)
2018-09-25 10:04

 Repository: erp/devel/pi
Changeset: 462eab118a3bbd84c8493a845ee750a6e61ca2c0
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Sep 21 11:26:50 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/462eab118a3bbd84c8493a845ee750a6e61ca2c0 [^]

fixed bug 39332: PG 11: ad_db_modified function fails

  AD_DB_MODIFIED was failing in PG 11 because it was using pg_proc.proisagg
  column which does no longer exist starting from 11.

  Using that column was unneeded in any case because it was in query to get
  paramaters and it was filtering out functions using them, as those functions
  where already obtained in outer query, it is not needed to filter them again.

---
M src-db/database/model/prescript-PostgreSql.sql
---
(0106991)
hgbot (developer)
2018-09-25 10:04

 Repository: erp/devel/pi
Changeset: 45a672248561d79d4a3f22df7393414e4e71a9c9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Sep 21 11:34:01 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/45a672248561d79d4a3f22df7393414e4e71a9c9 [^]

related to bug 39332: PG 11: ad_db_modified function fails

  Added test cases covering ad_db_modified

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
A src-test/src/org/openbravo/test/model/DBModifiedTest.java
---
(0106997)
hgbot (developer)
2018-09-25 11:04

 Repository: erp/devel/pi
Changeset: b378ec3feb5108222b5cbdcfbd3531c71db7a062
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Sep 25 11:04:15 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b378ec3feb5108222b5cbdcfbd3531c71db7a062 [^]

related to issue 39332: Fix typo

---
M src-test/src/org/openbravo/test/model/DBModifiedTest.java
---
(0106999)
caristu (developer)
2018-09-25 11:25

 Code reviewed + tested OK.
(0107027)
hudsonbot (developer)
2018-09-25 20:57

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b69e30e117b8 [^]
Maturity status: Test
(0107028)
hudsonbot (developer)
2018-09-25 20:57

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b69e30e117b8 [^]
Maturity status: Test
(0107031)
hudsonbot (developer)
2018-09-25 20:57

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b69e30e117b8 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-09-20 19:27 caristu New Issue
2018-09-20 19:27 caristu Assigned To => platform
2018-09-20 19:27 caristu Modules => Core
2018-09-20 19:27 caristu Triggers an Emergency Pack => No
2018-09-20 19:27 caristu Issue generated from 0039271
2018-09-20 19:27 caristu Relationship added related to 0039271
2018-09-20 19:27 caristu Relationship added blocks 0039270
2018-09-20 19:28 caristu Description Updated View Revisions
2018-09-21 08:16 caristu File Added: ad_db_modified_error.diff
2018-09-21 08:17 caristu Steps to Reproduce Updated View Revisions
2018-09-21 08:17 caristu Description Updated View Revisions
2018-09-21 08:20 caristu Summary PG 11: ad_db_modified function fails silently => PG 11: ad_db_modified function fails
2018-09-21 08:21 caristu Description Updated View Revisions
2018-09-21 11:23 alostale Status new => scheduled
2018-09-21 11:23 alostale Assigned To platform => alostale
2018-09-25 10:04 hgbot Checkin
2018-09-25 10:04 hgbot Note Added: 0106990
2018-09-25 10:04 hgbot Status scheduled => resolved
2018-09-25 10:04 hgbot Resolution open => fixed
2018-09-25 10:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/462eab118a3bbd84c8493a845ee750a6e61ca2c0 [^]
2018-09-25 10:04 hgbot Checkin
2018-09-25 10:04 hgbot Note Added: 0106991
2018-09-25 10:05 alostale Review Assigned To => caristu
2018-09-25 11:04 hgbot Checkin
2018-09-25 11:04 hgbot Note Added: 0106997
2018-09-25 11:25 caristu Note Added: 0106999
2018-09-25 11:25 caristu Status resolved => closed
2018-09-25 11:25 caristu Fixed in Version => 3.0PR18Q4
2018-09-25 20:57 hudsonbot Checkin
2018-09-25 20:57 hudsonbot Note Added: 0107027
2018-09-25 20:57 hudsonbot Checkin
2018-09-25 20:57 hudsonbot Note Added: 0107028
2018-09-25 20:57 hudsonbot Checkin
2018-09-25 20:57 hudsonbot Note Added: 0107031

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker