Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0039194 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | trivial | have not tried | 2018-08-28 14:16 | 2018-08-30 18:48 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 14005f586f3c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | jarmendariz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0039194: Improve parameter name in Utility.getImage(String, boolean) method | |||||||
| Description | The name of the boolean parameter in Utility.getImage(String, boolean) method is not descriptive enough (doCommit). This method was introduced to avoid connection leaks when printing an image on a jasper subreport using the Utility.showImage method. This method ensures that the connection is closed once the image has been retrieved. The boolean parameter was intended to decide if the connection should be closed (not just commited). This should be reflected on its name. | |||||||
| Steps To Reproduce | In description | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0106507) hgbot (developer) 2018-08-28 14:23 |
Repository: erp/devel/pi Changeset: 14005f586f3c8181acf6f6f69785b1e83f970253 Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Tue Aug 28 14:19:56 2018 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/14005f586f3c8181acf6f6f69785b1e83f970253 [^] fixes bug 39194: More descriptive param name in getImage(String,boolean) method --- M src/org/openbravo/erpCommon/utility/Utility.java --- |
|
(0106511) jarmendariz (developer) 2018-08-29 09:00 |
Reviewed. |
|
(0106548) hudsonbot (developer) 2018-08-30 18:48 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f018f6d60a65 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-08-28 14:16 | caristu | New Issue | |
| 2018-08-28 14:16 | caristu | Assigned To | => platform |
| 2018-08-28 14:16 | caristu | Modules | => Core |
| 2018-08-28 14:16 | caristu | Triggers an Emergency Pack | => No |
| 2018-08-28 14:16 | caristu | Assigned To | platform => caristu |
| 2018-08-28 14:16 | caristu | Relationship added | related to 0036697 |
| 2018-08-28 14:23 | hgbot | Checkin | |
| 2018-08-28 14:23 | hgbot | Note Added: 0106507 | |
| 2018-08-28 14:23 | hgbot | Status | new => resolved |
| 2018-08-28 14:23 | hgbot | Resolution | open => fixed |
| 2018-08-28 14:23 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/14005f586f3c8181acf6f6f69785b1e83f970253 [^] |
| 2018-08-28 14:23 | caristu | Review Assigned To | => jarmendariz |
| 2018-08-29 09:00 | jarmendariz | Note Added: 0106511 | |
| 2018-08-29 09:02 | jarmendariz | Status | resolved => closed |
| 2018-08-29 09:02 | jarmendariz | Fixed in Version | => 3.0PR18Q4 |
| 2018-08-30 18:48 | hudsonbot | Checkin | |
| 2018-08-30 18:48 | hudsonbot | Note Added: 0106548 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |