Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038967
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-07-16 12:282018-09-10 15:24
ReporterairaceburuView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR18Q4
StatusclosedFix in branchFixed in SCM revision3faebb978a4a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038967: Sum of linenet plus tax can be different than gross

DescriptionUnder certain conditions this error can appear in Web POS

885e3dd427966dd0eace05e3dca14967.js:3933 Receipt verification error: The sum of the net of each line plus taxes does not equal the gross: 'closed', gross: 188.97, difference: 0.01

This is also true in backend, the tax is not being adjusted properly
Steps To ReproduceIn Web POS:
Place a breakpoint in the line "accum = OB.DEC.add(accum, fieldValue);"
Menu, Layaway this receipt
Add 3 products to the receipt
Change the 3 prices to 62.99
Click Layaway
Notice that during the third stop in the breakpoint the value of fieldValue has a precision problem but luckily it ends up summing the appropriate value
Open the receipt
Pay it
Click Done
Notice that during the third stop of the breakpoint the value of fieldValue has no longer the precision problem and having 2 decimals makes the previous error appear
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0038927 closedadrianromero To calculate pending to pay in a foreign amount it is not used the configured multiply by rate 
related to defect 0038731pi closedrqueralta Layaway price may vary when opened in another terminal 
related to defect 0041154 closedrqueralta "Tax" field in the order's JSON is wrong when including a compound tax rate in a layaway, it is loaded and paid 

-  Notes
(0106434)
hgbot (developer)
2018-08-21 22:08

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3faebb978a4a636e37a6a3dc88f6a264755195c0
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Aug 21 12:07:15 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3faebb978a4a636e37a6a3dc88f6a264755195c0 [^]

Fixed issue 38967: Sum of linenet plus tax can be different than gross

- Added linenetamount to orderline model on PaidReceiptLinesProperties

---
M src/org/openbravo/retail/posterminal/PaidReceiptLinesProperties.java
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0106449)
marvintm (manager)
2018-08-22 14:51

 The issue can still be reproduced, by following the same steps:

- Create layaway, three lines with price 62.99
- Click on "layaway"
- Open receipt, load it again
- Add partial payment, and click on "layaway"

Verify that you get the following error in the console:

Receipt verification error: The sum of the net of each line plus taxes does not equal the gross: 'closed', gross: 188.97, difference: -0.01;


The problem still comes from the fact that we are recalculating the net. It should just be loaded from the backend, and used in the line.
(0106466)
hgbot (developer)
2018-08-24 04:52

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d0b2f908faae1122d0c48e42251660e028c40447
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Aug 23 18:08:20 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0b2f908faae1122d0c48e42251660e028c40447 [^]

Related to issue 38967: Sum of linenet plus tax can be different than gross

- Added linenetamount to orderline model on PaidReceiptLinesProperties

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0106673)
hgbot (developer)
2018-09-10 15:24

 Repository: tools/automation/pi-mobile
Changeset: 2abf23b1f744b7ee8cc89d8af4aa0987896070ff
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Jul 30 17:50:06 2018 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2abf23b1f744b7ee8cc89d8af4aa0987896070ff [^]

Related to issue 38967: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I38967_VerifyLayawaySumInLineNetAmount.java
---

- Issue History
Date Modified Username Field Change
2018-07-16 12:28 airaceburu New Issue
2018-07-16 12:28 airaceburu Assigned To => Retail
2018-07-16 12:28 airaceburu Resolution time => 1532901600
2018-07-16 12:28 airaceburu Triggers an Emergency Pack => No
2018-07-16 14:00 migueldejuana Relationship added related to 0038927
2018-07-16 14:04 migueldejuana Review Assigned To => marvintm
2018-07-16 14:04 migueldejuana Note Added: 0105752
2018-07-16 14:04 migueldejuana Status new => closed
2018-07-16 14:04 migueldejuana Resolution open => no change required
2018-07-16 14:06 migueldejuana Note Edited: 0105752 View Revisions
2018-07-16 16:51 migueldejuana Relationship added related to 0038731
2018-07-16 17:11 migueldejuana Note Deleted: 0105752
2018-07-16 17:11 migueldejuana Status closed => new
2018-07-16 17:11 migueldejuana Resolution no change required => open
2018-07-16 20:24 rqueralta Assigned To Retail => rqueralta
2018-07-16 20:24 rqueralta Status new => scheduled
2018-08-21 22:08 hgbot Checkin
2018-08-21 22:08 hgbot Note Added: 0106434
2018-08-21 22:08 hgbot Status scheduled => resolved
2018-08-21 22:08 hgbot Resolution open => fixed
2018-08-21 22:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3faebb978a4a636e37a6a3dc88f6a264755195c0 [^]
2018-08-22 14:51 marvintm Note Added: 0106449
2018-08-22 14:51 marvintm Status resolved => new
2018-08-22 14:51 marvintm Resolution fixed => open
2018-08-24 04:52 hgbot Checkin
2018-08-24 04:52 hgbot Note Added: 0106466
2018-08-24 04:53 rqueralta Status new => scheduled
2018-08-24 04:54 rqueralta Status scheduled => resolved
2018-08-24 04:54 rqueralta Resolution open => fixed
2018-08-24 08:21 marvintm Status resolved => closed
2018-08-24 08:21 marvintm Fixed in Version => RR18Q4
2018-09-10 15:24 hgbot Checkin
2018-09-10 15:24 hgbot Note Added: 0106673
2019-06-24 12:41 ngarcia Relationship added related to 0041154

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker