Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0038965
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-07-16 11:192018-10-23 11:24
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision4eb6161cdd82
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038965: Exact payment in a foreign amount must use the multiply by rate not divide by rate

DescriptionWhen executing the exact payment action in a foreign currency, to do exactly the same calculation done when calculating the pending to pay, the payment amount to pay must be calculated as multiplying the pending amount by the *multiply by rate* field instead of dividing the amount by the *divide by rate*.
Steps To Reproduce* First update the Format.xml configuration file with the following entries and rebuild the instance:
   <Number name="generalQtyRelation"
       decimal="." grouping="," formatOutput="#,##0.############" formatInternal="#0.000000000000" />
   <Number name="generalQtyEdition"
       decimal="." grouping="," formatOutput="#0.############" formatInternal="#0.000000000000" />
   <Number name="generalQtyExcel"
       decimal="." grouping="," formatOutput="#,##0.############" formatInternal="#0.000000000000" />

* Modify the Conversion Rate for EUR -> USD as multiply rate 4100, divide rate is automatically calculated as 0.000243902439. Do the same for USD -> EUR conversion, but in the opposite direction.

* Login in Web POS and create a receipt for a total of 20.00€
* Go to the payment panel and add a payment of 19.00€
* Select Cash USA payment method and observe the remaining to pay is $4.100.
* Select the exact payment action and observe the payment amount is $4.098. This is wrong and must be $4.100 as calculated in the remaining to pay.
Proposed SolutionApply the attached changeset
TagsNo tags attached.
Attached Filesdiff file icon issue38965.diff [^] (1,193 bytes) 2018-07-16 11:50 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0038927 closedadrianromero To calculate pending to pay in a foreign amount it is not used the configured multiply by rate 

-  Notes
(0107277)
hgbot (developer)
2018-10-15 10:24

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 181cb2f12ceb88d1950aa4903496d66d8d97e28c
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jul 16 11:33:12 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/181cb2f12ceb88d1950aa4903496d66d8d97e28c [^]

Fixes issue 0038965: Exact payment in a foreign amount must use the multiply by rate not divide by rate

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0107278)
hgbot (developer)
2018-10-15 10:24

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5b7c3d3aaa9d4628b0fdc10f6a85397ea8695d57
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jul 16 19:15:42 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5b7c3d3aaa9d4628b0fdc10f6a85397ea8695d57 [^]

Fixes issue 0038965: Exact payment in a foreign amount must use the multiply by rate not divide by rate

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0107279)
hgbot (developer)
2018-10-15 10:24

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4eb6161cdd82d8d8dafaf5519165ee838cd683bf
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Jul 18 11:48:20 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4eb6161cdd82d8d8dafaf5519165ee838cd683bf [^]

Fixes issue 0038965: Exact payment in a foreign amount must use the multiply by rate not divide by rate
Fixing graft of the changeset

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0107513)
migueldejuana (developer)
2018-10-23 11:24

Tested and reviewed

- Issue History
Date Modified Username Field Change
2018-07-16 11:19 adrianromero New Issue
2018-07-16 11:19 adrianromero Assigned To => Retail
2018-07-16 11:19 adrianromero Triggers an Emergency Pack => No
2018-07-16 11:19 adrianromero Relationship added related to 0038927
2018-07-16 11:20 adrianromero Summary Exact payment in a foreign amount must use the multiply by rate not divide rate => Exact payment in a foreign amount must use the multiply by rate not divide by rate
2018-07-16 11:23 adrianromero Description Updated View Revisions
2018-07-16 11:23 adrianromero Steps to Reproduce Updated View Revisions
2018-07-16 11:50 adrianromero Assigned To Retail => adrianromero
2018-07-16 11:50 adrianromero File Added: issue38965.diff
2018-10-15 10:24 hgbot Checkin
2018-10-15 10:24 hgbot Note Added: 0107277
2018-10-15 10:24 hgbot Status new => resolved
2018-10-15 10:24 hgbot Resolution open => fixed
2018-10-15 10:24 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/181cb2f12ceb88d1950aa4903496d66d8d97e28c [^]
2018-10-15 10:24 hgbot Checkin
2018-10-15 10:24 hgbot Note Added: 0107278
2018-10-15 10:24 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/181cb2f12ceb88d1950aa4903496d66d8d97e28c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5b7c3d3aaa9d4628b0fdc10f6a85397ea8695d57 [^]
2018-10-15 10:24 hgbot Checkin
2018-10-15 10:24 hgbot Note Added: 0107279
2018-10-15 10:24 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5b7c3d3aaa9d4628b0fdc10f6a85397ea8695d57 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4eb6161cdd82d8d8dafaf5519165ee838cd683bf [^]
2018-10-22 12:55 adrianromero Steps to Reproduce Updated View Revisions
2018-10-23 09:22 adrianromero Steps to Reproduce Updated View Revisions
2018-10-23 11:24 migueldejuana Review Assigned To => migueldejuana
2018-10-23 11:24 migueldejuana Note Added: 0107513
2018-10-23 11:24 migueldejuana Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker