Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0038911
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Modules] Distribution Ordersmajoralways2018-07-06 10:462020-11-11 17:00
Reportermaarten1962View Statuspublic 
Assigned Tononofrancisco 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision745af9b73671
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Regression introduced in release
Summary

0038911: When a picked but not issued DOi is CLOSED, the reservations are not deleted.

DescriptionA DO can be closed in the middle of the process. This is OK.
If there are open tasks, these should be deleted. This is currently not the case.
With deleting the tasks, the reservation should be deleted also (it probably will, manually deleting a Task also deletes the Res).
If there are no open tasks (after picking was confirmed but issue hasn't started yet) the reservations should be deleted.
Steps To ReproduceCreate and pick a DOi. Confirm the tasks.
Observe in Whse operations that the stock is moved and the reservation points to the new bin.
Go to the DOi and closed it.
Observe in Whse operations that the reservation is still allocated and not released.
Proposed SolutionWhen a DOi is closed, open tasks and reservations must be deleted.
Please check if the same behavior happens with Sales Orders. If so, adjust accordingly.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
causes defect 0039607 closednonofrancisco Cannot close a Distribution Order Receipt 

-  Notes
(0107304)
vmromanos (manager)
2018-10-15 15:01
edited on: 2018-10-24 13:33

Before this design defect the behavior is the following:

In Sales Order:
1. It shows an error when closing a sales order with open tasks
2. It shows an error if there are allocated reservations linked to the order
In both cases the order can't be closed till the user manually fixes these situations.

In Distribution Order:
The system allows to close a distribution with open reservations and/or tasks.


This design defect must try to fix this mismatch.



Proposed solution:
Implement the current behavior found in Sales Order to Distribution Order.

Create a new preference (disabled by default) called "Delete tasks & reservations when closing Document". If enable it will automatically delete the related tasks and reservations linked to the SO/DO at closing document time.

This preference might have different values per document

In DO module add a hook when processing a DO (to be executed from "draft -> book" and from "booked -> close").

In DO for AWO module implement the hook to delete non-closed tasks linked to the DO. This should automatically delete any linked reservation. Please double check.

In DO module implement the hook to release any open reservation linked to the DO line (that won't be linked to any task).



For Sales Order, instead of creating a hook, it will be necessary to directly implement an extension point (http://wiki.openbravo.com/wiki/How_to_use_an_Extension_Point [^]) on C_Order_Post to delete any related task.
Reservations should be already released when closing the order.

(0107486)
nonofrancisco (developer)
2018-10-22 15:17

Test plan 1. Closing DO with non confirmed picking tasks

1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing DO" preference
3. Create a Distribution Order Issue
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Close the document
8. Verify the document was closed

Test plan 2. Closing DO with confirmed picking tasks

1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing DO" preference
3. Create a Distribution Order Issue
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Close the document
9. Verify the document was closed


Test plan 3. Closing DO with non confirmed issue tasks

1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing DO" preference
3. Create a Distribution Order Issue
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Generate issue tasks
9. Close the document
10. Verify the document was closed

Test plan 4. Closing DO with confirmed issue tasks

1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing DO" preference
3. Create a Distribution Order Issue
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Generate issue tasks
9. Confirm issue tasks
10. Close the document
11. Verify the document was closed

Test plan 5. Closing Sales Order with non confirmed picking tasks

1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing SO" preference
3. Create a Sales Order
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Close the document
8. Verify the document was closed

Test plan 6. Closing Sales Order with confirmed picking tasks

1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing SO" preference
3. Create a Sales Order
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Close the document
9. Verify the document was closed

Test plan 7. Closing Sales Order with non confirmed issue tasks

1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing SO" preference
3. Create a Sales Order
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Generate issue tasks
9. Close the document
10. Verify the document was closed

Test plan 8. Closing Sales Order with confirmed issue tasks

1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing SO" preference
3. Create a Sales Order
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Generate issue tasks
9. Confirm issue tasks
10. Close the document
11. Verify the document was closed
(0107669)
hgbot (developer)
2018-10-30 17:45

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 8cbc638247e89a93e0dbafa220a642a7b9876b08
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 12:02:24 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8cbc638247e89a93e0dbafa220a642a7b9876b08 [^]

Fixes issue 38911: Close Order with open reservations and non confirmed tasks.

- A new preference has been added to point out open reservations sould be
  released, and non confirmed tasks should be removed, when closing a
  Sales Order.
- The expension point OBAWO_CLOSE_ORDER_EP has been modified to, when closing
  the order, remove non confirmed tasks linked to sales order lines if
  preference is set; otherwise an exception is thrown.
- A new extension point has been created to be executed at the beginning of
  order proccesing, to, when closing the order, release all open reservations
  linked to sales order lines.
- Automated tests have been added.

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_EP_PROCEDURES.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOTestSuite.java
A src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOx_CloseSalesOrder.java
---
(0107670)
hgbot (developer)
2018-10-30 17:45

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 757558f2ac882ed6e474f555951012752ac7918e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:40:16 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/757558f2ac882ed6e474f555951012752ac7918e [^]

Related to issue 38911: Code review improvements

OBAWO_CLOSE_ORDER_BEFORE_EP: Simplified update query, avoiding to query once again the m_reservation_stock table.

OBAWO_CLOSE_ORDER_EP: Added missing documentation. Use <> 'CL' to support new non-closed statuses in the future

AD_REF_LIST: Removed blank space in the name

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0107671)
hgbot (developer)
2018-10-30 17:45

Repository: erp/mods/org.openbravo.distributionorder
Changeset: 11b34e901a1c9b520f544538259cd0025739699d
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 13:23:08 2018 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/11b34e901a1c9b520f544538259cd0025739699d [^]

Fixes issue 38911: Close Order with open reservations and non confirmed tasks.

- A new hook was created to be executed after the Distribution Order has been
  processed.
- A new hook implementation was added to release all open reservations linked
  to Distribution Order lines, when closing the Distribution Order.
- Automated tests were updated

---
M src-test/org/openbravo/distributionorder/test/OBDO_FB_WeldBaseTest.java
M src-test/org/openbravo/distributionorder/test/utils/DistributionOrderTestUtils.java
M src/org/openbravo/distributionorder/actionHandler/ProcessDistributionOrder.java
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
A src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
A src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
A src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
(0107672)
hgbot (developer)
2018-10-30 17:45

Repository: erp/mods/org.openbravo.distributionorder
Changeset: b4cd74947fdcd7175b07f571eb50272155e1e58a
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:46:47 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/b4cd74947fdcd7175b07f571eb50272155e1e58a [^]

Related to issue 38911: Code review improvements

ProcessDistributionOrderUtil:
* Declare as public the DocActions, as they might be interesting for the hooks
* Pass the docAction to the hooks

AfterDistributionOrderProcessedHook:
* Pass docAction to the methods isValid() and run()
* Created method isBeingClosed() useful for the hooks implementation

AfterDistributionOrderProcessedHookRunner:
* Implement new AfterDistributionOrderProcessedHook API

AfterOrderProcessedHook:
* Implement new AfterDistributionOrderProcessedHook API
* isValid() calls the isBeingClosed() method
* Proper class javadoc

---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
M src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
(0107673)
hgbot (developer)
2018-10-30 17:45

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: b92e6eb41047b1a042f89293be295405a71d6837
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 13:26:05 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/b92e6eb41047b1a042f89293be295405a71d6837 [^]

Fixes issue 38911: Close Order with open reservations and non confirmed tasks.

- A new preference has been added to point out open reservations sould be
  released, and non confirmed tasks should be removed, when closing a
  Distribution Order.
- A new hook implementation has been added to remove all non confimed tasks
  linked to Distribution Order lines, when closing a Distribution Order.

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTestSuite.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
A src-db/database/sourcedata/AD_REF_LIST.xml
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107674)
hgbot (developer)
2018-10-30 17:45

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: beddffa5b19750cab949140f7911e02ebf53b898
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:46:49 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/beddffa5b19750cab949140f7911e02ebf53b898 [^]

Related to issue 38911: Code review improvements

Avoid to duplicate utility methods that are already available at the DO module.

AfterAWODistributionOrderProcessedHook:
* Implement new AfterDistributionOrderProcessedHook API
* Run flush() only if necessary
* Clear session inside the tasks loop
* Use <> 'CL' to support new non-closed statuses in the future
* Proper class javadoc

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107675)
hgbot (developer)
2018-10-30 17:45

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 4499478bcb9b08166a9c9365518d57fc2b2d60e5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 17:28:47 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/4499478bcb9b08166a9c9365518d57fc2b2d60e5 [^]

Related to issue 38911: Code review improvements II

Avoid to load too many objects in memory. Instead only the affected records are loaded.

Properly support tasks behaving as group with RI.

Note that it is necessary to delete the tasks (or the group of tasks document) through Hibernate (not directly using SQL) because it's necessary to launch the EventObserves on those entities

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107685)
hgbot (developer)
2018-10-31 10:08

Repository: erp/mods/org.openbravo.distributionorder
Changeset: 51d2fe865c7e58ebb6e7cff17b1c345d4601b837
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:02:56 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/51d2fe865c7e58ebb6e7cff17b1c345d4601b837 [^]

Related to issue 38911: Avoid OptimisticLockException
Set an order to execute the hooks

---
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
M src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
(0107686)
hgbot (developer)
2018-10-31 10:08

Repository: erp/mods/org.openbravo.distributionorder
Changeset: 1f2f60b596e3b7deebb21aff694178043bb70226
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:20:14 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/1f2f60b596e3b7deebb21aff694178043bb70226 [^]

Related to issue 38911: Renamed hook to make it clear

---
A src/org/openbravo/distributionorder/hooks/implementation/AfterDOProcessedHook.java
R src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
(0107687)
hgbot (developer)
2018-10-31 10:08

Repository: erp/mods/org.openbravo.distributionorder
Changeset: fda9ab358b4df64d788b00e2a23d7c5112252045
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 10:08:23 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/fda9ab358b4df64d788b00e2a23d7c5112252045 [^]

Related to issue 38911: flush after hook execution

---
M src/org/openbravo/distributionorder/hooks/implementation/AfterDOProcessedHook.java
---
(0107688)
hgbot (developer)
2018-10-31 10:09

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 760f56c414c9f60ca4c47f2965ccef95cb7baacb
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:03:56 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/760f56c414c9f60ca4c47f2965ccef95cb7baacb [^]

Related to issue 38911: Avoid OptimisticLockException
Set an order to execute the hooks. The AWO DO hook is always executed before the DO hook

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107689)
hgbot (developer)
2018-10-31 10:09

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 363bbce52ac40d047f55eb9e6a15db789f9d9626
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:20:26 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/363bbce52ac40d047f55eb9e6a15db789f9d9626 [^]

Related to issue 38911: Renamed hook to make it clear

---
A src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
R src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107690)
hgbot (developer)
2018-10-31 10:09

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 0d3a2df10b927c79000ed5492222503f940411ee
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 10:08:15 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/0d3a2df10b927c79000ed5492222503f940411ee [^]

Related to issue 38911: flush after hook execution

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
---
(0107694)
hgbot (developer)
2018-10-31 10:49

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0770d819c01ef6b99291e8ec452b35a8ad992208
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 10:49:03 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0770d819c01ef6b99291e8ec452b35a8ad992208 [^]

Related to issue 38911: removed unused variable v_count

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
---
(0107732)
hgbot (developer)
2018-11-05 11:51

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 7d01d130c0d9c717e16fc04414693556c51b853c
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Oct 31 16:46:19 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/7d01d130c0d9c717e16fc04414693556c51b853c [^]

Related to issue 38911: Added a new automated test

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
---
(0107733)
hgbot (developer)
2018-11-05 11:51

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 8b60c2e8105059c43e758694b2da89083d9ce0e9
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Nov 01 08:05:33 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/8b60c2e8105059c43e758694b2da89083d9ce0e9 [^]

Related to issue 38911: Removes commented code

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
---
(0107739)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: 8bc3d3972fdfc6abc3b9940b6f1670f65b323527
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 13:23:08 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/8bc3d3972fdfc6abc3b9940b6f1670f65b323527 [^]

Fixes issue 38911: Close Order with open reservations and non confirmed tasks.

- A new hook was created to be executed after the Distribution Order has been
  processed.
- A new hook implementation was added to release all open reservations linked
  to Distribution Order lines, when closing the Distribution Order.
- Automated tests were updated

---
M src-test/org/openbravo/distributionorder/test/OBDO_FB_WeldBaseTest.java
M src-test/org/openbravo/distributionorder/test/utils/DistributionOrderTestUtils.java
M src/org/openbravo/distributionorder/actionHandler/ProcessDistributionOrder.java
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
A src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
A src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
A src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
(0107740)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: 1f0d98bf420ece164b835e6ad47376c79547984c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:46:47 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/1f0d98bf420ece164b835e6ad47376c79547984c [^]

Related to issue 38911: Code review improvements

ProcessDistributionOrderUtil:
* Declare as public the DocActions, as they might be interesting for the hooks
* Pass the docAction to the hooks

AfterDistributionOrderProcessedHook:
* Pass docAction to the methods isValid() and run()
* Created method isBeingClosed() useful for the hooks implementation

AfterDistributionOrderProcessedHookRunner:
* Implement new AfterDistributionOrderProcessedHook API

AfterOrderProcessedHook:
* Implement new AfterDistributionOrderProcessedHook API
* isValid() calls the isBeingClosed() method
* Proper class javadoc

---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
M src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
(0107741)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: 9a9a2b4952d6439a0c8d6fa7b8ee108a15480e00
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:02:56 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/9a9a2b4952d6439a0c8d6fa7b8ee108a15480e00 [^]

Related to issue 38911: Avoid OptimisticLockException
Set an order to execute the hooks

---
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
M src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
(0107742)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: e5edd444ae68e7ea28a59832b9db16d60bbabec7
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:20:14 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/e5edd444ae68e7ea28a59832b9db16d60bbabec7 [^]

Related to issue 38911: Renamed hook to make it clear

---
A src/org/openbravo/distributionorder/hooks/implementation/AfterDOProcessedHook.java
R src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
(0107743)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: d41d7ad2427815d19d50c4c76ea5c43ab97c34e8
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 10:08:23 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/d41d7ad2427815d19d50c4c76ea5c43ab97c34e8 [^]

Related to issue 38911: flush after hook execution

---
M src/org/openbravo/distributionorder/hooks/implementation/AfterDOProcessedHook.java
---
(0107744)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: e7024ee418e12cf764dd59fac1f7b54dc6845fe5
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Oct 31 12:58:45 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/e7024ee418e12cf764dd59fac1f7b54dc6845fe5 [^]

Related to issue 38911: Adapted code to 18Q3

---
M src/org/openbravo/distributionorder/hooks/implementation/AfterDOProcessedHook.java
---
(0107745)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: f0c4fe046c0c1275f23203de2b58ad3957f482ef
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 12:02:24 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/f0c4fe046c0c1275f23203de2b58ad3957f482ef [^]

Fixes issue 38911: Close Order with open reservations and non confirmed tasks.

- A new preference has been added to point out open reservations sould be
  released, and non confirmed tasks should be removed, when closing a
  Sales Order.
- The expension point OBAWO_CLOSE_ORDER_EP has been modified to, when closing
  the order, remove non confirmed tasks linked to sales order lines if
  preference is set; otherwise an exception is thrown.
- A new extension point has been created to be executed at the beginning of
  order proccesing, to, when closing the order, release all open reservations
  linked to sales order lines.
- Automated tests have been added.

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_EP_PROCEDURES.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOTestSuite.java
A src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOx_CloseSalesOrder.java
---
(0107746)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: b25a50b7c2a95a38373cae717f287c43173fc61c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:40:16 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/b25a50b7c2a95a38373cae717f287c43173fc61c [^]

Related to issue 38911: Code review improvements

OBAWO_CLOSE_ORDER_BEFORE_EP: Simplified update query, avoiding to query once again the m_reservation_stock table.

OBAWO_CLOSE_ORDER_EP: Added missing documentation. Use <> 'CL' to support new non-closed statuses in the future

AD_REF_LIST: Removed blank space in the name

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0107747)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: b78ec6d249a1b05930fb7ff89f72ee0efb31d554
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 10:49:03 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/b78ec6d249a1b05930fb7ff89f72ee0efb31d554 [^]

Related to issue 38911: removed unused variable v_count

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
---
(0107748)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: b1b56c0e9ce3112e4915ac74a5db11de476e867d
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Oct 31 12:58:06 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/b1b56c0e9ce3112e4915ac74a5db11de476e867d [^]

Related to issue 38911: Adapted code to 18Q3

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOb_BasicFunctionalFlowsWithAWOPreference.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOx_CloseSalesOrder.java
---
(0107749)
hgbot (developer)
2018-11-05 18:14

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 745af9b736717908833010c562be9cf14851cc6a
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Oct 31 10:39:14 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/745af9b736717908833010c562be9cf14851cc6a [^]

Fixes issue 38911: Close Order with open reservations and non confirmed tasks.

- A new preference has been added to point out open reservations sould be
  released, and non confirmed tasks should be removed, when closing a
  Distribution Order.
- A new hook implementation has been added to remove all non confimed tasks
  linked to Distribution Order lines, when closing a Distribution Order.

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTestSuite.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
A src-db/database/sourcedata/AD_REF_LIST.xml
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107750)
hgbot (developer)
2018-11-05 18:15

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 4ebc2bd5cef7115c9f7156c82113a852f543e8c0
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:46:49 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/4ebc2bd5cef7115c9f7156c82113a852f543e8c0 [^]

Related to issue 38911: Code review improvements

Avoid to duplicate utility methods that are already available at the DO module.

AfterAWODistributionOrderProcessedHook:
* Implement new AfterDistributionOrderProcessedHook API
* Run flush() only if necessary
* Clear session inside the tasks loop
* Use <> 'CL' to support new non-closed statuses in the future
* Proper class javadoc

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107751)
hgbot (developer)
2018-11-05 18:15

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 30741e0d503c829f09d1fef16dd99dc20bf1162c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 17:28:47 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/30741e0d503c829f09d1fef16dd99dc20bf1162c [^]

Related to issue 38911: Code review improvements II

Avoid to load too many objects in memory. Instead only the affected records are loaded.

Properly support tasks behaving as group with RI.

Note that it is necessary to delete the tasks (or the group of tasks document) through Hibernate (not directly using SQL) because it's necessary to launch the EventObserves on those entities

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107752)
hgbot (developer)
2018-11-05 18:15

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 33f501fe4fbb3232ce198956cef85e35a0379e1d
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:03:56 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/33f501fe4fbb3232ce198956cef85e35a0379e1d [^]

Related to issue 38911: Avoid OptimisticLockException
Set an order to execute the hooks. The AWO DO hook is always executed before the DO hook

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107753)
hgbot (developer)
2018-11-05 18:15

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: db75353fa08052f43542c7e6660da8a3fd3aa150
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:20:26 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/db75353fa08052f43542c7e6660da8a3fd3aa150 [^]

Related to issue 38911: Renamed hook to make it clear

---
A src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
R src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
(0107754)
hgbot (developer)
2018-11-05 18:15

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 586694339006b82790961ad3f7b1e470737d38e8
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 10:08:15 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/586694339006b82790961ad3f7b1e470737d38e8 [^]

Related to issue 38911: flush after hook execution

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
---
(0107755)
hgbot (developer)
2018-11-05 18:15

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 4d7883832f043ef2ec5f6f72382e80402e367fc8
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Oct 31 13:06:39 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/4d7883832f043ef2ec5f6f72382e80402e367fc8 [^]

Related to issue 38911: Adapted code to 18Q3

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
---
(0107756)
hgbot (developer)
2018-11-05 18:15

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 46e096c1b2cb03e8df850b2b8651929aba2e127d
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Oct 31 16:46:19 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/46e096c1b2cb03e8df850b2b8651929aba2e127d [^]

Related to issue 38911: Added a new automated test

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
---
(0107757)
hgbot (developer)
2018-11-05 18:15

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 6cee7bb27011f50b7709ca8d18bb631b2a35bfdf
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Nov 01 08:05:33 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/6cee7bb27011f50b7709ca8d18bb631b2a35bfdf [^]

Related to issue 38911: Removes commented code

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
---
(0107758)
vmromanos (manager)
2018-11-05 18:18

Code review + testing OK.

Fixed in:
AWO 1.3.600 or higher
AWO DO 1.2.300 or higher
DO 1.2.300 or higher
(0107817)
hgbot (developer)
2018-11-09 09:41

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: e5261543d7260da252db93b6eb572b65f7c4cab1
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Nov 08 16:26:38 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/e5261543d7260da252db93b6eb572b65f7c4cab1 [^]

Related to issue 38911: Adds new automated test

Adds a new automated test to verify a sales order can be successfully closed
after booked, when preference "OBAWO_DeleteNonConfTaskAndResWhenCloseSO"
is not set.

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOx_CloseSalesOrder.java
---
(0107819)
hgbot (developer)
2018-11-09 09:52

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: d16d6d539cab614ded7ccac535d757c8c5999584
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Nov 08 16:26:38 2018 -0500
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/d16d6d539cab614ded7ccac535d757c8c5999584 [^]

Related to issue 38911: Adds new automated test

Adds a new automated test to verify a sales order can be successfully closed
after booked, when preference "OBAWO_DeleteNonConfTaskAndResWhenCloseSO"
is not set.

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOx_CloseSalesOrder.java
---
(0107820)
hgbot (developer)
2018-11-09 09:52

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: d16d6d539cab614ded7ccac535d757c8c5999584
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Nov 08 16:26:38 2018 -0500
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/d16d6d539cab614ded7ccac535d757c8c5999584 [^]

Related to issue 38911: Adds new automated test

Adds a new automated test to verify a sales order can be successfully closed
after booked, when preference "OBAWO_DeleteNonConfTaskAndResWhenCloseSO"
is not set.

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOx_CloseSalesOrder.java
---
(0107821)
hgbot (developer)
2018-11-09 09:52

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 9d4401c13cfc7afe152bc0d5d396fc43c8b6f690
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 09 09:46:52 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/9d4401c13cfc7afe152bc0d5d396fc43c8b6f690 [^]

Related to issue 38911: Code review improvements
Removed unnecessary SuppressWarnings

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
---
(0107936)
hgbot (developer)
2018-11-15 17:39

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: fecb39a629494694644a2f966d96e4e10eeaa062
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 15 17:38:47 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/fecb39a629494694644a2f966d96e4e10eeaa062 [^]

Related to issue 38911: Confirmed status is CO (and not CL)
Simplified query avoiding extra join

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
---
(0107937)
hgbot (developer)
2018-11-15 17:39

Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 09d40b3d619612ae33f496edb98cccfa4c13ce6e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 15 17:38:47 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/09d40b3d619612ae33f496edb98cccfa4c13ce6e [^]

Related to issue 38911: Confirmed status is CO (and not CL)
Simplified query avoiding extra join

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
---

- Issue History
Date Modified Username Field Change
2018-07-06 10:46 maarten1962 New Issue
2018-07-06 10:46 maarten1962 Assigned To => Triage Finance
2018-10-15 14:50 vmromanos Status new => scheduled
2018-10-15 14:50 vmromanos Assigned To Triage Finance => nonofrancisco
2018-10-15 15:01 vmromanos Note Added: 0107304
2018-10-15 15:02 vmromanos Type defect => design defect
2018-10-15 15:03 vmromanos Note Edited: 0107304 View Revisions
2018-10-22 15:17 nonofrancisco Note Added: 0107486
2018-10-24 13:33 vmromanos Note Edited: 0107304 View Revisions
2018-10-30 17:45 hgbot Checkin
2018-10-30 17:45 hgbot Note Added: 0107669
2018-10-30 17:45 hgbot Status scheduled => resolved
2018-10-30 17:45 hgbot Resolution open => fixed
2018-10-30 17:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8cbc638247e89a93e0dbafa220a642a7b9876b08 [^]
2018-10-30 17:45 hgbot Checkin
2018-10-30 17:45 hgbot Note Added: 0107670
2018-10-30 17:45 hgbot Checkin
2018-10-30 17:45 hgbot Note Added: 0107671
2018-10-30 17:45 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8cbc638247e89a93e0dbafa220a642a7b9876b08 [^] => http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/11b34e901a1c9b520f544538259cd0025739699d [^]
2018-10-30 17:45 hgbot Checkin
2018-10-30 17:45 hgbot Note Added: 0107672
2018-10-30 17:45 hgbot Checkin
2018-10-30 17:45 hgbot Note Added: 0107673
2018-10-30 17:45 hgbot Fixed in SCM revision http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/11b34e901a1c9b520f544538259cd0025739699d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/b92e6eb41047b1a042f89293be295405a71d6837 [^]
2018-10-30 17:45 hgbot Checkin
2018-10-30 17:45 hgbot Note Added: 0107674
2018-10-30 17:45 hgbot Checkin
2018-10-30 17:45 hgbot Note Added: 0107675
2018-10-31 10:08 hgbot Checkin
2018-10-31 10:08 hgbot Note Added: 0107685
2018-10-31 10:08 hgbot Checkin
2018-10-31 10:08 hgbot Note Added: 0107686
2018-10-31 10:08 hgbot Checkin
2018-10-31 10:08 hgbot Note Added: 0107687
2018-10-31 10:09 hgbot Checkin
2018-10-31 10:09 hgbot Note Added: 0107688
2018-10-31 10:09 hgbot Checkin
2018-10-31 10:09 hgbot Note Added: 0107689
2018-10-31 10:09 hgbot Checkin
2018-10-31 10:09 hgbot Note Added: 0107690
2018-10-31 10:18 vmromanos Review Assigned To => vmromanos
2018-10-31 10:49 hgbot Checkin
2018-10-31 10:49 hgbot Note Added: 0107694
2018-11-05 11:51 hgbot Checkin
2018-11-05 11:51 hgbot Note Added: 0107732
2018-11-05 11:51 hgbot Checkin
2018-11-05 11:51 hgbot Note Added: 0107733
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107739
2018-11-05 18:14 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/b92e6eb41047b1a042f89293be295405a71d6837 [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/8bc3d3972fdfc6abc3b9940b6f1670f65b323527 [^]
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107740
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107741
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107742
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107743
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107744
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107745
2018-11-05 18:14 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/8bc3d3972fdfc6abc3b9940b6f1670f65b323527 [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/f0c4fe046c0c1275f23203de2b58ad3957f482ef [^]
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107746
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107747
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107748
2018-11-05 18:14 hgbot Checkin
2018-11-05 18:14 hgbot Note Added: 0107749
2018-11-05 18:14 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/f0c4fe046c0c1275f23203de2b58ad3957f482ef [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/745af9b736717908833010c562be9cf14851cc6a [^]
2018-11-05 18:15 hgbot Checkin
2018-11-05 18:15 hgbot Note Added: 0107750
2018-11-05 18:15 hgbot Checkin
2018-11-05 18:15 hgbot Note Added: 0107751
2018-11-05 18:15 hgbot Checkin
2018-11-05 18:15 hgbot Note Added: 0107752
2018-11-05 18:15 hgbot Checkin
2018-11-05 18:15 hgbot Note Added: 0107753
2018-11-05 18:15 hgbot Checkin
2018-11-05 18:15 hgbot Note Added: 0107754
2018-11-05 18:15 hgbot Checkin
2018-11-05 18:15 hgbot Note Added: 0107755
2018-11-05 18:15 hgbot Checkin
2018-11-05 18:15 hgbot Note Added: 0107756
2018-11-05 18:15 hgbot Checkin
2018-11-05 18:15 hgbot Note Added: 0107757
2018-11-05 18:18 vmromanos Note Added: 0107758
2018-11-05 18:18 vmromanos Status resolved => closed
2018-11-08 17:58 ngarcia Relationship added causes 0039607
2018-11-09 09:41 hgbot Checkin
2018-11-09 09:41 hgbot Note Added: 0107817
2018-11-09 09:52 hgbot Checkin
2018-11-09 09:52 hgbot Note Added: 0107819
2018-11-09 09:52 hgbot Checkin
2018-11-09 09:52 hgbot Note Added: 0107820
2018-11-09 09:52 hgbot Checkin
2018-11-09 09:52 hgbot Note Added: 0107821
2018-11-15 17:31 martinsdan Issue Monitored: martinsdan
2018-11-15 17:39 hgbot Checkin
2018-11-15 17:39 hgbot Note Added: 0107936
2018-11-15 17:39 hgbot Checkin
2018-11-15 17:39 hgbot Note Added: 0107937
2020-11-11 17:00 eugeni Issue Monitored: eugeni


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker