Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0038749 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2018-06-13 12:14 | 2018-06-15 10:49 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0PR18Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 12232bee10ef | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0038749: InventoryCountProcess registers SQL functions in a non-standard way | |||||||
| Description | InventoryCountProcess registers SQL functions in a non-standard way[1]. It is was manually registering the functions into the dialect. This is wrong because: a) Duplicates the code. Performs the same actions done by the OBDal.registerSQLFunction b) This will not work in Hibernate 5.3 Note that this is a change we missed when fixing 0038520, due to the fact that the code does not use the OBDal.registerSQLFunction. | |||||||
| Steps To Reproduce | In description | |||||||
| Proposed Solution | Register the required functions using a SQLFunctionRegister | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0105132) hgbot (developer) 2018-06-13 17:34 |
Repository: erp/devel/pi Changeset: 12232bee10ef58d11743de979fdfa0dd9e4614ba Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Wed Jun 13 17:18:35 2018 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/12232bee10ef58d11743de979fdfa0dd9e4614ba [^] fixes issue 38749: InventoryCountProcess registers SQL functions in a non-standard way Register in Hibernate the SQL functions required by the InventoryCountProcess class during the initialization of the DAL layer: - get_uuid: being already registered in the KernelSQLFunctionRegister - to_date: there is no need of explicitly registering it, it is already registered by the corresponding PostgreSQL and Oracle dialects - to_timestamp: being registered by default with the PostgreSQL but not with the Oracle dialect. So for PostgreSQL we are overriding the registry of this function. For this reason we are registering it in the same way as done by the PostgreSQL dialect. - now: the same as to_timestamp function --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelSQLFunctionRegister.java M src/org/openbravo/materialmgmt/InventoryCountProcess.java --- |
|
(0105134) hudsonbot (developer) 2018-06-13 21:36 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3aea2ba95cc7 [^] Maturity status: Test |
|
(0105171) alostale (manager) 2018-06-15 10:49 |
reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-06-13 12:14 | caristu | New Issue | |
| 2018-06-13 12:14 | caristu | Assigned To | => caristu |
| 2018-06-13 12:14 | caristu | Modules | => Core |
| 2018-06-13 12:14 | caristu | Triggers an Emergency Pack | => No |
| 2018-06-13 12:15 | caristu | Description Updated | View Revisions |
| 2018-06-13 12:15 | caristu | Relationship added | related to 0038520 |
| 2018-06-13 12:16 | caristu | Description Updated | View Revisions |
| 2018-06-13 17:34 | hgbot | Checkin | |
| 2018-06-13 17:34 | hgbot | Note Added: 0105132 | |
| 2018-06-13 17:34 | hgbot | Status | new => resolved |
| 2018-06-13 17:34 | hgbot | Resolution | open => fixed |
| 2018-06-13 17:34 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/12232bee10ef58d11743de979fdfa0dd9e4614ba [^] |
| 2018-06-13 17:34 | caristu | Review Assigned To | => alostale |
| 2018-06-13 21:36 | hudsonbot | Checkin | |
| 2018-06-13 21:36 | hudsonbot | Note Added: 0105134 | |
| 2018-06-15 10:49 | alostale | Note Added: 0105171 | |
| 2018-06-15 10:49 | alostale | Status | resolved => closed |
| 2018-06-15 10:49 | alostale | Fixed in Version | => 3.0PR18Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |