Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0038749
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2018-06-13 12:142018-06-15 10:49
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in Version3.0PR18Q3
StatusclosedFix in branchFixed in SCM revision12232bee10ef
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038749: InventoryCountProcess registers SQL functions in a non-standard way

DescriptionInventoryCountProcess registers SQL functions in a non-standard way[1]. It is was manually registering the functions into the dialect. This is wrong because:

a) Duplicates the code. Performs the same actions done by the OBDal.registerSQLFunction
b) This will not work in Hibernate 5.3

Note that this is a change we missed when fixing 0038520, due to the fact that the code does not use the OBDal.registerSQLFunction.
Steps To ReproduceIn description
Proposed SolutionRegister the required functions using a SQLFunctionRegister
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0038520 closedcaristu Deprecate OBDal.registerSQLFunction 

-  Notes
(0105132)
hgbot (developer)
2018-06-13 17:34

Repository: erp/devel/pi
Changeset: 12232bee10ef58d11743de979fdfa0dd9e4614ba
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Jun 13 17:18:35 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/12232bee10ef58d11743de979fdfa0dd9e4614ba [^]

fixes issue 38749: InventoryCountProcess registers SQL functions in a non-standard way

  Register in Hibernate the SQL functions required by the InventoryCountProcess class during the initialization of the DAL layer:

  - get_uuid: being already registered in the KernelSQLFunctionRegister
  - to_date: there is no need of explicitly registering it, it is already registered by the corresponding PostgreSQL and Oracle dialects
  - to_timestamp: being registered by default with the PostgreSQL but not with the Oracle dialect. So for PostgreSQL we are overriding the registry of this function. For this reason we are registering it in the same way as done by the PostgreSQL dialect.
  - now: the same as to_timestamp function

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelSQLFunctionRegister.java
M src/org/openbravo/materialmgmt/InventoryCountProcess.java
---
(0105134)
hudsonbot (developer)
2018-06-13 21:36

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3aea2ba95cc7 [^]
Maturity status: Test
(0105171)
alostale (developer)
2018-06-15 10:49

reviewed

- Issue History
Date Modified Username Field Change
2018-06-13 12:14 caristu New Issue
2018-06-13 12:14 caristu Assigned To => caristu
2018-06-13 12:14 caristu Modules => Core
2018-06-13 12:14 caristu Triggers an Emergency Pack => No
2018-06-13 12:15 caristu Description Updated View Revisions
2018-06-13 12:15 caristu Relationship added related to 0038520
2018-06-13 12:16 caristu Description Updated View Revisions
2018-06-13 17:34 hgbot Checkin
2018-06-13 17:34 hgbot Note Added: 0105132
2018-06-13 17:34 hgbot Status new => resolved
2018-06-13 17:34 hgbot Resolution open => fixed
2018-06-13 17:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/12232bee10ef58d11743de979fdfa0dd9e4614ba [^]
2018-06-13 17:34 caristu Review Assigned To => alostale
2018-06-13 21:36 hudsonbot Checkin
2018-06-13 21:36 hudsonbot Note Added: 0105134
2018-06-15 10:49 alostale Note Added: 0105171
2018-06-15 10:49 alostale Status resolved => closed
2018-06-15 10:49 alostale Fixed in Version => 3.0PR18Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker