Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038551
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorhave not tried2018-05-15 09:552018-05-30 00:14
ReporterSandrahuguetView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q3
StatusclosedFix in branchFixed in SCM revisionf8bc7fbdf77e
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038551: Improve performance of Add Multiple Payments process in Financial Account window

DescriptionImprove performance of Add Multiple Payments process in Financial Account window.
In a high volume environment.
Having 1000 payments pending to deposit in the financial account:
 - Select all: 6 min
 - Done: 3 min
Steps To ReproduceIn a high volume environment and having 1000 payments pending to deposit.
Login ERP
Go to Financial account and click on add multiple payments button
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0036180 closedmarkmm82 Add Multiple payments pick and execute performance 
related to defect 0035664 closedmarkmm82 Performance of Add Multiple Payments P&E grid should be improved 

-  Notes
(0104722)
AtulOpenbravo (developer)
2018-05-25 17:51
edited on: 2018-05-25 17:56

 In Local environment, Add Multiple Payments process

Before Change

doExecute--------------: (1538961 ms)
getTransactionMaxLineNo: (4000 ms) approx. as it was not captured.

 
After Change

doExecute--------------: (1538961 ms)
getTransactionMaxLineNo: (2239 ms)

% Improvement in doExecute: 83.63%

In BUT big environment, Add Multiple Payments process


Before Change

doExecute--------------: (1198728 ms)
getTransactionMaxLineNo: (2047 ms)
AD_GET_DOC_LE_BU-------: (7289 ms)


 
After Change

doExecute--------------: (369412 ms)
getTransactionMaxLineNo: (1293 ms)
AD_GET_DOC_LE_BU-------: (491 ms)


% Improvement in doExecute--------------: 69.18%
% Improvement in getTransactionMaxLineNo: 36.83%
% Improvement in AD_GET_DOC_LE_BU-------: 93.26%

Note: AD_GET_DOC_LE_BU improvement is achieved by applying Persist Org Info issue 33650 fixes.
(0104782)
hgbot (developer)
2018-05-29 17:56

 Repository: erp/devel/pi
Changeset: f8bc7fbdf77ec2fcdc170275744db362a2c97946
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 25 21:00:17 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f8bc7fbdf77ec2fcdc170275744db362a2c97946 [^]

Fixes Issue 38551: Improve performance of Add Multiple Payments process
in Financial Account window

** Clear session after processing each payment being used to create
Financial Account Transaction.
** getTransactionMaxLineNo is already called to set Line No in
TransactionsDao's createFinAccTransaction method so avoid it again
in AddMultiplePaymentsHandler

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddMultiplePaymentsHandler.java
---
(0104783)
dmiguelez (developer)
2018-05-29 17:57

 Code Review + Testing Ok
(0104794)
hudsonbot (developer)
2018-05-30 00:14

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/08f13cf1fa33 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-05-15 09:55 Sandrahuguet New Issue
2018-05-15 09:55 Sandrahuguet Assigned To => Triage Finance
2018-05-15 09:55 Sandrahuguet Modules => Core
2018-05-15 09:55 Sandrahuguet Triggers an Emergency Pack => No
2018-05-15 09:55 Sandrahuguet Tag Attached: Performance
2018-05-15 10:06 Sandrahuguet Description Updated View Revisions
2018-05-15 10:06 Sandrahuguet Steps to Reproduce Updated View Revisions
2018-05-15 10:23 aferraz Assigned To Triage Finance => AtulOpenbravo
2018-05-17 09:22 vmromanos Relationship added related to 0036180
2018-05-17 09:22 vmromanos Relationship added related to 0035664
2018-05-18 21:36 AtulOpenbravo Status new => scheduled
2018-05-25 17:40 AtulOpenbravo Note Added: 0104721
2018-05-25 17:43 AtulOpenbravo Note Edited: 0104721 View Revisions
2018-05-25 17:44 AtulOpenbravo Note Deleted: 0104721
2018-05-25 17:51 AtulOpenbravo Note Added: 0104722
2018-05-25 17:51 AtulOpenbravo Note Edited: 0104722 View Revisions
2018-05-25 17:56 AtulOpenbravo Note Edited: 0104722 View Revisions
2018-05-29 17:56 hgbot Checkin
2018-05-29 17:56 hgbot Note Added: 0104782
2018-05-29 17:56 hgbot Status scheduled => resolved
2018-05-29 17:56 hgbot Resolution open => fixed
2018-05-29 17:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f8bc7fbdf77ec2fcdc170275744db362a2c97946 [^]
2018-05-29 17:57 dmiguelez Review Assigned To => dmiguelez
2018-05-29 17:57 dmiguelez Note Added: 0104783
2018-05-29 17:57 dmiguelez Status resolved => closed
2018-05-29 17:57 dmiguelez Fixed in Version => 3.0PR18Q3
2018-05-30 00:14 hudsonbot Checkin
2018-05-30 00:14 hudsonbot Note Added: 0104794

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker