Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0038300 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Y. DBSourceManager | minor | have not tried | 2018-04-08 18:19 | 2018-05-09 19:29 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 7f5e9e478b37 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0038300: export.database still reads from old obsolete ad_system_info.code_revision field | |||||||
| Description | Safety mechanism to not accidentally overwrite file changes during export.database has been changed a long time ago from 'mercurial revision' to md5 checksum of files. See DBSMOBUtil.verifyCheckSum call in ExportDatabase code However if the checksum comparison fails the code did still read and display the older obsolete ad_system_info.code_revision field. As the new md5 value is not useful to do anything specific with for the user remove printing the old code_revision without replacing it with printing the new md5 checksum value from config/checksums file. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  38300.hgexport [^] (5,174 bytes) 2018-04-08 20:07 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0103882) hgbot (developer) 2018-04-13 15:07 |
Repository: erp/devel/dbsm-main Changeset: 7f5e9e478b3725dc7ab1ce0f23ba6dcd29c883e3 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Sun Apr 08 18:21:36 2018 +0200 URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/7f5e9e478b3725dc7ab1ce0f23ba6dcd29c883e3 [^] fixes issue 38300: Remove using/showing obsolete ad_system_info.code_revision Export.database safety to not overwrite files is using md5 checksum for files for a long time. However there was a leftover of printing the old obsolete ad_system_info.code_revision which is hereby removed. Commit also removes the longer unused verifyRevision call on top of the getDBRevision. --- M src/org/openbravo/ddlutils/task/ExportDatabase.java M src/org/openbravo/ddlutils/util/DBSMOBUtil.java --- |
|
(0103883) hgbot (developer) 2018-04-13 15:14 |
Repository: erp/devel/pi Changeset: 734cd2862d3429fe5aed4019d107e8ce007b99df Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Fri Apr 13 15:12:34 2018 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/734cd2862d3429fe5aed4019d107e8ce007b99df [^] related to issue 38300: update DBSM .jar file --- M src-db/database/lib/dbsourcemanager.jar --- |
|
(0104382) hudsonbot (developer) 2018-05-09 19:29 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-04-08 18:19 | shuehner | New Issue | |
| 2018-04-08 18:19 | shuehner | Assigned To | => platform |
| 2018-04-08 18:19 | shuehner | Modules | => Core |
| 2018-04-08 18:19 | shuehner | Triggers an Emergency Pack | => No |
| 2018-04-08 18:19 | shuehner | Relationship added | blocks 0037500 |
| 2018-04-08 18:49 | shuehner | Assigned To | platform => shuehner |
| 2018-04-08 20:07 | shuehner | File Added: 38300.hgexport | |
| 2018-04-13 15:07 | hgbot | Checkin | |
| 2018-04-13 15:07 | hgbot | Note Added: 0103882 | |
| 2018-04-13 15:07 | hgbot | Status | new => resolved |
| 2018-04-13 15:07 | hgbot | Resolution | open => fixed |
| 2018-04-13 15:07 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/dbsm-main/rev/7f5e9e478b3725dc7ab1ce0f23ba6dcd29c883e3 [^] |
| 2018-04-13 15:14 | hgbot | Checkin | |
| 2018-04-13 15:14 | hgbot | Note Added: 0103883 | |
| 2018-04-13 15:15 | caristu | Review Assigned To | => caristu |
| 2018-04-13 15:15 | caristu | Status | resolved => closed |
| 2018-04-13 15:15 | caristu | Fixed in Version | => 3.0PR18Q3 |
| 2018-05-09 19:29 | hudsonbot | Checkin | |
| 2018-05-09 19:29 | hudsonbot | Note Added: 0104382 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |