0038113: Role with limited access can not Generate Pickings Or Issues from Front End

Description

Role with limited access can not Generate Pickings Or Issues from Front End

Steps To Reproduce

Using AWO and AWO Sampledata

Log in as QAAdmin

Go to User window and create a new user for * Organization

Go to Role window and create a new Role for * Organization with Client+Organization User Level and flagged as Manual
Move to the Org Access Tab and create a new record for US West Coast Organization
Move to User Assignment Tab and create a new record for the user created previously
Move to Form Access Tab and create a new record for Advance Mobile Warehouse Operations

Go to Sales Order Window and create a new Order for:
  - Organization: US West Coast
  - Business Partner: Healthy Food Supermarkets
  - Warehouse: US West Coast
Create a line with:
  - Product: Ale Beer
  - Operative Quantity: 10
Complete the Sales Order

In the Front End Log in as the new user
Click on Pick menu entry, look for the Sales Order previously created and select it.
Click Ok on the Pop Up to generate Tasks
Error ir raised. Image attached.

In the Back End Log is as Openbravo with F&B Admin Role

Move to the Sales Order and click on Pick and then Ok. The Tasks are generated.
Move to Lines || Task Tab
Select the Task and click on Confirm and Ok. The Task is confirmed.

Log In again the Front End Log in as the new user
Click on Issue menu entry, look for the Sales Order previously created and select it.
Click Ok on the Pop Up to generate Tasks
Error ir raised. Image attached.

Proposed Solution

diff --git a/src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/TaskGeneratorProcessor.java b/src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/TaskGeneratorProcessor.java
--- a/src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/TaskGeneratorProcessor.java
+++ b/src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/TaskGeneratorProcessor.java
@@ -88,9 +88,10 @@
       }
     } else if (action.equals(OBAWO_Constants.ACTION_PICKING)
         && source.equals(OBAWO_Constants.SOURCE_SALESORDER)) {
- final Order salesOrder = OBDal.getInstance().get(Order.class, id);
+ Order salesOrder = null;
       try {
         OBContext.setAdminMode(true);
+ salesOrder = OBDal.getInstance().get(Order.class, id);
         final OBAWO_BatchOfTasks batchOfTasks = CentralBroker.getNewInstance().doTheStuff(
             salesOrder, OBAWO_Constants.ACTION_PICKING, userId, null, null);
         toReturn.put("generated", true);
@@ -107,9 +108,10 @@
       }
     } else if (action.equals(OBAWO_Constants.ACTION_ISSUE)
         && source.equals(OBAWO_Constants.SOURCE_SALESORDER)) {
- final Order salesOrder = OBDal.getInstance().get(Order.class, id);
+ Order salesOrder = null;
       try {
         OBContext.setAdminMode(true);
+ salesOrder = OBDal.getInstance().get(Order.class, id);
         final OBAWO_BatchOfTasks batchOfTasks = CentralBroker.getNewInstance().doTheStuff(
             salesOrder, OBAWO_Constants.ACTION_ISSUE, userId, null, null);
         toReturn.put("generated", true);

Tags

No tags attached.

Attached Files

error.png [^] (195,197 bytes) 2018-03-13 12:55

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0103197) hgbot (developer) 2018-03-13 15:57	Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 19d84bdf0b841cc395df53b839f592e43401e7b4 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Mar 13 15:57:25 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/19d84bdf0b841cc395df53b839f592e43401e7b4 [^] Fixed issue 38113: Role with limited access can Generate Pickings and Issues from SO --- M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/TaskGeneratorProcessor.java ---

(0103657) dmiguelez (developer) 2018-04-03 17:44	Code Review + Testing Ok

Issue History
Date Modified	Username	Field	Change
2018-03-13 12:55	dmiguelez	New Issue
2018-03-13 12:55	dmiguelez	Assigned To	=> dmiguelez
2018-03-13 12:55	dmiguelez	File Added: error.png
2018-03-13 12:55	dmiguelez	Proposed Solution updated
2018-03-13 13:03	dmiguelez	Assigned To	dmiguelez => guilleaer
2018-03-13 13:04	dmiguelez	Resolution time	=> 1522706400
2018-03-13 15:57	hgbot	Checkin
2018-03-13 15:57	hgbot	Note Added: 0103197
2018-03-13 15:57	hgbot	Status	new => resolved
2018-03-13 15:57	hgbot	Resolution	open => fixed
2018-03-13 15:57	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/19d84bdf0b841cc395df53b839f592e43401e7b4 [^]
2018-04-03 17:44	dmiguelez	Review Assigned To	=> dmiguelez
2018-04-03 17:44	dmiguelez	Note Added: 0103657
2018-04-03 17:44	dmiguelez	Status	resolved => closed
2022-09-06 17:18	caristu	Category	Advance Warehouse Operations => Advanced Warehouse Operations