Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038098
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2018-03-11 13:012018-03-16 17:29
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision678132f0a29a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038098: Fix new javadoc warnings of -Xdoclint:html active by default as errors since Java 8

DescriptionSince Java8 javadoc has -Xdoclint:html active by default raising issues of level error not just warning.
That essentially enforces proper use of html tags in javadoc comments.

Ubuntu has that locally patched to hide those but they show up when testing with normal upstream Openjdk)

This fixes up all those in pi where most are just basic syntax fixes
- use

and not the xhtml verions


- use
and not the xhtml verions

- use html escape for <, >, &
- proper use of <code> and >ul>

In ReferencedInventoryUtil qualify @value use of 2 constants instead of referencing as local constant as otherwise javadoc from java9+10 doesn't find them.

Steps To ReproduceAdd <arg value="-Xdoclint:-missing" to generate.java.doc.(jdk7,jdk9) and run ant generate.java.doc

That activates all warnings except those enforcing javadoc being present everywhere.
Proposed SolutionFix javadoc comments
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0037825 closedshuehner Fix new javadoc warnings active by default in JDK 9 

-  Notes
(0103282)
hgbot (developer)
2018-03-15 16:41

 Repository: erp/devel/pi
Changeset: 678132f0a29a4b593e2c8d19afb58ffd3337b36e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Mar 11 13:10:30 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/678132f0a29a4b593e2c8d19afb58ffd3337b36e [^]

Fixed 38098. Fix all javadoc -Xdoclint:html warnings

Javadoc since java8 enforces stricter correct html use inside javadoc.
That was hidden by a local change done in Ubuntu openjdk packages.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ExtraWindowSettingsInjector.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/TemplateResolver.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/CheckTreeOperationManager.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonToDataConverter.java
M src-core/src/org/openbravo/base/AntExecutor.java
M src-core/src/org/openbravo/base/ConfigParameters.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_18.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_06.java
M src/org/openbravo/base/provider/OBProvider.java
M src/org/openbravo/base/util/OBClassLoader.java
M src/org/openbravo/base/validation/AccessLevelChecker.java
M src/org/openbravo/costing/CostingAlgorithm.java
M src/org/openbravo/dal/core/DalRequestFilter.java
M src/org/openbravo/dal/security/EntityAccessChecker.java
M src/org/openbravo/dal/security/OrganizationStructureProvider.java
M src/org/openbravo/dal/security/SecurityChecker.java
M src/org/openbravo/dal/service/OBCriteria.java
M src/org/openbravo/dal/service/OBDal.java
M src/org/openbravo/dal/xml/EntityResolver.java
M src/org/openbravo/dal/xml/StaxXMLEntityConverter.java
M src/org/openbravo/dal/xml/XMLEntityConverter.java
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
M src/org/openbravo/erpCommon/ad_forms/DocOrder.java
M src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java
M src/org/openbravo/erpCommon/ad_forms/Translation.java
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
M src/org/openbravo/erpCommon/modules/ApplyModule.java
M src/org/openbravo/erpCommon/modules/ModuleUtiltiy.java
M src/org/openbravo/erpCommon/utility/AntExecutor.java
M src/org/openbravo/erpCommon/utility/BasicUtility.java
M src/org/openbravo/erpCommon/utility/CashVATUtil.java
M src/org/openbravo/erpCommon/utility/GenericTree.java
M src/org/openbravo/erpCommon/utility/Utility.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
M src/org/openbravo/service/db/ClientImportEntityResolver.java
M src/org/openbravo/service/db/ImportResult.java
M src/org/openbravo/service/web/BaseWebServiceServlet.java
M src/org/openbravo/service/web/UserContextCache.java
M src/org/openbravo/service/web/WebServiceUtil.java
---
(0103285)
hgbot (developer)
2018-03-15 16:53

 Repository: erp/devel/pi
Changeset: 636948c66791648438db0bc1f27af5b2f331e388
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Mar 11 13:10:30 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/636948c66791648438db0bc1f27af5b2f331e388 [^]

Related to issue 38098. Fix all javadoc -Xdoclint:html warnings

Javadoc since java8 enforces stricter correct html use inside javadoc.
That was hidden by a local change done in Ubuntu openjdk packages.

---
M src-test/src/org/openbravo/test/materialMgmt/iscompletelyinvoicedshipment/ICIUtility.java
M src/org/openbravo/erpCommon/utility/OBMessageUtils.java
---
(0103286)
caristu (developer)
2018-03-15 16:53

 Reviewed + tested OK.
(0103327)
hudsonbot (developer)
2018-03-16 17:29

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5323533018b6 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-03-11 13:01 shuehner New Issue
2018-03-11 13:01 shuehner Assigned To => shuehner
2018-03-11 13:01 shuehner Modules => Core
2018-03-11 13:01 shuehner Triggers an Emergency Pack => No
2018-03-11 13:03 shuehner Issue generated from 0037825
2018-03-11 13:03 shuehner Relationship added related to 0037825
2018-03-11 13:03 shuehner Review Assigned To => alostale
2018-03-15 16:41 hgbot Checkin
2018-03-15 16:41 hgbot Note Added: 0103282
2018-03-15 16:41 hgbot Status new => resolved
2018-03-15 16:41 hgbot Resolution open => fixed
2018-03-15 16:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/678132f0a29a4b593e2c8d19afb58ffd3337b36e [^]
2018-03-15 16:44 caristu Review Assigned To alostale => caristu
2018-03-15 16:44 caristu Note Added: 0103283
2018-03-15 16:44 caristu Status resolved => closed
2018-03-15 16:44 caristu Fixed in Version => 3.0PR18Q2
2018-03-15 16:52 caristu Note Deleted: 0103283
2018-03-15 16:53 hgbot Checkin
2018-03-15 16:53 hgbot Note Added: 0103285
2018-03-15 16:53 caristu Note Added: 0103286
2018-03-16 17:29 hudsonbot Checkin
2018-03-16 17:29 hudsonbot Note Added: 0103327

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker