Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037967
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2018-02-19 11:592018-02-26 18:00
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionRR18Q2
StatusclosedFix in branchFixed in SCM revisionee1e56342da5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037967: JDK9: Fix new deprecation warnings related to: new Long, new Integer, new Boolean...

Description    Java since long time had both:
- new Integer(String
- new Integer(int)

but also
- int Integer.parseInt
- Integer Integer.valueOf

With the latter being preferred (i.e. not constructing new instance for performance etc)

JDK9 now deprecated those constructors.

This issue fixes all cases in pi of the now deprecated usage by applying simple pattern depending on usage:

Special notes:
a.) StatusBackgroundProcessScheduler
used int as return type of private method getPingInterval but later needs Long object for dal setter.
Change method type to return long instead to avoid need to convert type later.

b.) POSUtils had type confusion also parsing Long -> changing to int
After checking with amo use int type consistently here (should be 'long' enough)
Steps To ReproduceCompile with JDK9 and observe new compilation warnings.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks feature request 0037083 closedalostale Openbravo ERP support JDK 9 

-  Notes
(0102488)
hgbot (developer)
2018-02-19 12:03

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 909adc9e2f65a222cf52cc0412aca90fc7ed54ec
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Feb 19 12:01:29 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/909adc9e2f65a222cf52cc0412aca90fc7ed54ec [^]

Issue 37967. Fix new JDK9 deprecation warnings related to new Long

new Long is deprecated now replace it by Long.valueOf & autoboxing

---
M src/org/openbravo/mobile/core/listener/StatusBackgroundProcessScheduler.java
M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
---
(0102489)
hgbot (developer)
2018-02-19 12:07

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ee1e56342da5f900e82b3134b38c33166aed7671
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Feb 19 12:07:30 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ee1e56342da5f900e82b3134b38c33166aed7671 [^]

Fixed 37967. Fix new jdk9 deprecation warnings related to new Long.

Replace usage of new Long, new Double by equivalent use of autoboxing
and .valueOf.

Special mention:
POSUtils -> consistently use int as type instead of int/long mix.

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/SyncAllErrorsWhileImporting.java
---

- Issue History
Date Modified Username Field Change
2018-02-19 11:59 shuehner New Issue
2018-02-19 11:59 shuehner Assigned To => shuehner
2018-02-19 11:59 shuehner Triggers an Emergency Pack => No
2018-02-19 11:59 shuehner Relationship added blocks 0037083
2018-02-19 12:03 hgbot Checkin
2018-02-19 12:03 hgbot Note Added: 0102488
2018-02-19 12:04 shuehner Status new => scheduled
2018-02-19 12:07 hgbot Checkin
2018-02-19 12:07 hgbot Note Added: 0102489
2018-02-19 12:07 hgbot Status scheduled => resolved
2018-02-19 12:07 hgbot Resolution open => fixed
2018-02-19 12:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ee1e56342da5f900e82b3134b38c33166aed7671 [^]
2018-02-19 12:07 shuehner Review Assigned To => marvintm
2018-02-26 18:00 marvintm Status resolved => closed
2018-02-26 18:00 marvintm Fixed in Version => RR18Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker