Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037927
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Remittancemajoralways2018-02-15 11:172018-03-06 12:09
ReportermaiteView Statuspublic 
Assigned Tocollazoandy4 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision710b327ea51d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0037927: Cost Center dimension (and others) should be considered when posting remittance elements

DescriptionOnly Project, Campaign and Activity accounting dimensions are considered at the moment. But in order to obtain balanced accounting information rest of dimensions needs to be considered too
Steps To Reproduce1. Access to Client window and enable "Cost Center" dimension for Header and Lines
2. Logout and login again
3. Access to Cost Center window and create record
4. Register new Payment Out document using "In remittance" payment method and setting Cost Center dimension in the header. Add line selecting any Gl Item and setting any amount. Process payment and realize that is left in Awaiting Execution status
5. Create new Remittance header and select previous Payment. Process remittance
6. Post remittance
7. Access to Accounting Transaction Details to review remittance's accounting entry and realize that no cost center information has been set

If you register similar Payment Out document using another Payment Method and posts the payment document, cost center information will be correctly set
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0102531)
collazoandy4 (reporter)
2018-02-20 15:41
edited on: 2018-02-27 23:05

Test Plan
  Go to Financial Account window and select Caja record:
      Create a new record in Payment Method tab:
        Payment Method: Remittance
        Upon Deposit Use: Cleared Payment Account
        Upon Reconciliation Use: Deposited Payment Account
        Upon Receipt Use: In Transit Payment Account
    Go to Remittance Type window and select Printable Remittance record:
      Create a two new records in Accounting tab:
        1. General Ledger: F&B España, S.A. US/A/Euro, Settlement Account / Sent Account: 52080
        2. General Ledger: F&B International Group US/A/US Dollar, Settlement Account / Sent Account: 1190
  Go to Client window and check Cost Center Dimension, 1st Dimension, 2nd Dimension, Show in Header and Show in Lines
  Log out and Log in again
  Go to Cost Center window and create a new record:
    Search Key/Name: IssueCostCenter
  Go to User Defined Dimension 1 and create a new record:
    Search Key/Name: UserDimension1
  Go to User Defined Dimension 2 and create a new record:
    Search Key/Name: UserDimension2
  Go to Payment out window and create a new record:
    Payment method: Remittance
    Paying From: Caja - EUR
    Cost Center: IssueCostCenter
    1st Dimension: UserDimension1
    2nd Dimension: UserDimension2
    Click on Add Details button:
      G/L Item: Capital social G/LItem
      Paid Out: 5.00
      Action Regarding Process: Process Made Payment(s) and Withdrawal
      Click on Done button
    Click on Execute Payment button and check the process ends successfull
  Go to Remittance window and check a new record was created for the previous payment
    Click on Process button and Post the remittance document
  Go to Accounting Transaction Details window and filter by Today Accounting Date and check all the remittance entries have a Cost center, 1st Dimension and 2nd Dimension value
  Go to Settle / Protest Remittances window and filter by F&B España - Region Norte, select the previous record, set Accounting Date as now and clic on Settle button
  Go to Remittance window and select the previous record created, go to Settle tab and post the record created
  Go to Accounting Transaction Details window and filter by Today Accounting Date and check two of the remittance entries have a Cost center, 1st Dimension and 2nd Dimension value

Test Plan II
  Go to Payment out window and create a new record:
    Payment method: Remittance
    Paying From: Caja - EUR
    Cost Center: IssueCostCenter
    1st Dimension: UserDimension1
    2nd Dimension: UserDimension2
    Click on Add Details button:
      G/L Item: Capital social G/LItem
      Paid Out: 6.00
      Action Regarding Process: Process Made Payment(s) and Withdrawal
      Click on Done button
    Click on Execute Payment button and check the process ends successfull
  Go to Remittance window and check a new record was created for the previous payment
    Click on Process button and Post the remittance document
  Go to Accounting Transaction Details window and filter by Today Accounting Date and check all the remittance entries have a Cost center, 1st Dimension and 2nd Dimension value
  Go to Settle / Protest Remittances window and filter by F&B España - Region Norte, select the previous record, set Accounting Date as now and clic on Protest button
  Go to Remittance window and select the previous record created, go to Protest tab and post the record created
  Go to Accounting Transaction Details window and filter by Today Accounting Date and check all of the remittance entries for the previous record have a Cost center, 1st Dimension and 2nd Dimension value

Test Plan III
  Go to Sales Invoice window and create a new record:
    Business Partner: Alimentos y Supermercados, S.A
    Payment Method: Remittance
    Cost Center: IssueCostCenter
    1st Dimension: UserDimension1
    2nd Dimension: UserDimension2
    Create a new record in Lines tab:
      Product: Zumo de Piña 0,5L
      Invoiced Quantity: 10
    Complete the Invoice and Pay it
  Go to Payment in window and select the previous payment created and Click on Execute Payment button and check the process ends successfull
  Go to Remittance window and check a new record was created for the previous payment
    Click on Process button and Post the remittance document
  Go to Accounting Transaction Details window and filter by Today Accounting Date and check all the remittance entries have a Cost center value
  Go to Settle / Protest Remittances window and filter by F&B España - Region Norte, select the previous record, set Accounting Date as now and clic on Settle button
  Go to Remittance window and select the previous record created, go to Settle tab and post the record created
  Go to Accounting Transaction Details window and filter by Today Accounting Date and check two of the remittance entries have a Cost center, 1st Dimension and 2nd Dimension value

Test Plan IV
  Go to Sales Invoice window and create a new record:
    Business Partner: Alimentos y Supermercados, S.A
    Payment Method: Remittance
    Cost Center: IssueCostCenter
    1st Dimension: UserDimension1
    2nd Dimension: UserDimension2
    Create a new record in Lines tab:
      Product: Zumo de Pera 0,5L
      Invoiced Quantity: 10
    Complete the Invoice and Pay it
  Go to Payment in window and select the previous payment created and Click on Execute Payment button and check the process ends successfull
  Go to Remittance window and check a new record was created for the previous payment
    Click on Process button and Post the remittance document
  Go to Accounting Transaction Details window and filter by Today Accounting Date and check all the remittance entries have a Cost center value
  Go to Settle / Protest Remittances window and filter by F&B España - Region Norte, select the previous record, set Accounting Date as now and clic on Protest button
  Go to Remittance window and select the previous record created, go to Protest tab and post the record created
  Go to Accounting Transaction Details window and filter by Today Accounting Date and check all of the remittance entries for the previous record have a Cost center, 1st Dimension and 2nd Dimension value


Repeat the Previous Test Plan for Sales Orders

(0103022)
hgbot (developer)
2018-03-06 12:07

Repository: erp/mods/org.openbravo.module.remittance
Changeset: 710b327ea51dd44ba8f42a8ad90e14a1486bdee0
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Feb 20 19:55:01 2018 -0500
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/710b327ea51dd44ba8f42a8ad90e14a1486bdee0 [^]

Fixes issue 37927:Cost Center dimension (and others) should be considered when
posting remittance elements

Only Project, Campaign and Activity accounting dimensions are considered at the
moment. But in order to obtain balanced accounting information rest of dimensions
needs to be considered too

The cost center, sales region and product accounting dimensions are now considered
in the Remittance post process

---
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceReturn.java
---
(0103023)
hgbot (developer)
2018-03-06 12:07

Repository: erp/mods/org.openbravo.module.remittance
Changeset: 3036ace3cf9045418229adb56af52a5216b305ed
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 05 17:20:35 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/3036ace3cf9045418229adb56af52a5216b305ed [^]

Related to Issue 37927. Code review changes:

* Too many conditionals in one clause makes code hard to read. It has been split
  into several self explanatory methods
* Since methods can be reused, they have been moved to a new Utils class
* Removed Sales Region and Campaing, since those can not be defined
  as Accounting Dimensions for the Client

---
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceReturn.java
A src/org/openbravo/module/remittance/utility/RemittanceUtils.java
---
(0103024)
hgbot (developer)
2018-03-06 12:07

Repository: erp/mods/org.openbravo.module.remittance
Changeset: 7692bef5d9ac335d97a81ee0ed48e26901086e1f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 05 17:23:34 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/7692bef5d9ac335d97a81ee0ed48e26901086e1f [^]

Related to issue 37927. Code Review changes.

Assigned paymentDetails.get(i) into a variable to be used instead
of calling the same expression so many times

---
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceReturn.java
---
(0103025)
hgbot (developer)
2018-03-06 12:07

Repository: erp/mods/org.openbravo.module.remittance
Changeset: 11d7dbe7d1018d8aa4ab2fc516ebf8c185b27930
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Mar 06 11:57:29 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/11d7dbe7d1018d8aa4ab2fc516ebf8c185b27930 [^]

Related to Issue 37927. Updated module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0103026)
dmiguelez (developer)
2018-03-06 12:09

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2018-02-15 11:17 maite New Issue
2018-02-15 11:17 maite Assigned To => Triage Finance
2018-02-15 11:17 maite Resolution time => 1488927600
2018-02-15 11:17 maite Issue Monitored: networkb
2018-02-15 12:09 maite Priority high => urgent
2018-02-15 12:27 dmiguelez Resolution time 1488927600 => 1520463600
2018-02-15 17:29 dmiguelez Assigned To Triage Finance => collazoandy4
2018-02-19 20:32 collazoandy4 Status new => scheduled
2018-02-20 15:41 collazoandy4 Note Added: 0102531
2018-02-27 23:05 collazoandy4 Note Edited: 0102531 View Revisions
2018-03-06 12:07 hgbot Checkin
2018-03-06 12:07 hgbot Note Added: 0103022
2018-03-06 12:07 hgbot Status scheduled => resolved
2018-03-06 12:07 hgbot Resolution open => fixed
2018-03-06 12:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/710b327ea51dd44ba8f42a8ad90e14a1486bdee0 [^]
2018-03-06 12:07 hgbot Checkin
2018-03-06 12:07 hgbot Note Added: 0103023
2018-03-06 12:07 hgbot Checkin
2018-03-06 12:07 hgbot Note Added: 0103024
2018-03-06 12:07 hgbot Checkin
2018-03-06 12:07 hgbot Note Added: 0103025
2018-03-06 12:09 dmiguelez Review Assigned To => dmiguelez
2018-03-06 12:09 dmiguelez Note Added: 0103026
2018-03-06 12:09 dmiguelez Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker