Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037918
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformminoralways2018-02-13 17:192018-02-15 09:35
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q4.1
StatusclosedFix in branchFixed in SCM revision6f6bd229fc5e
ProjectionnoneETAnoneTarget Version3.0PR17Q4.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037918: Internal CSS are included in AD_TextInterface as translatable content

DescriptionHtml pages can embed some CSS in <style> tags, though it will be included in AD_TextInterfaces after running ant export.database, which is not desiderable.
Steps To Reproduce1) Apply the attached patch (cssCreatesTextInterface.diff)
2) Run "ant compile.complete"

At the end of the output of this command you can see the following line, indicating that the styles are recognized as translatable content:

[java] 1917 [main] INFO org.openbravo.translate.Translate - New label found [body {background-color: green;} h1 {color: red;} p {color: blue;}] in /org/openbravo/erpCommon/security/Login.html
TagsNo tags attached.
Attached Filesdiff file icon cssCreatesTextInterface.diff [^] (574 bytes) 2018-02-15 09:20 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0037907 closedjarmendariz Internal CSS are included in AD_TextInterface as translatable content 

-  Notes
(0102415)
hgbot (developer)
2018-02-14 18:36

 Repository: erp/backports/3.0PR17Q4.1
Changeset: 6f6bd229fc5efea73f95901c45beb8d8a29dd299
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Feb 14 18:34:52 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/6f6bd229fc5efea73f95901c45beb8d8a29dd299 [^]

Fixed bug 37918: Internal CSS are included in AD_TextInterfaces

Adding <style> tags along <script> as tags excluded from being parsed for the Translate class.

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0102426)
hgbot (developer)
2018-02-15 09:35

 Repository: erp/backports/3.0PR17Q4.1
Changeset: 3420f8221073ce09654c86f48f322b04dfa5fa57
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Feb 15 09:34:49 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/3420f8221073ce09654c86f48f322b04dfa5fa57 [^]

related to issue 37918: updated copyright year

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0102427)
caristu (developer)
2018-02-15 09:35

 Code reviewed + tested OK.

- Issue History
Date Modified Username Field Change
2018-02-14 18:10 jarmendariz Type defect => backport
2018-02-14 18:10 jarmendariz Target Version => 3.0PR17Q4.1
2018-02-14 18:36 hgbot Checkin
2018-02-14 18:36 hgbot Note Added: 0102415
2018-02-14 18:36 hgbot Status scheduled => resolved
2018-02-14 18:36 hgbot Resolution open => fixed
2018-02-14 18:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/6f6bd229fc5efea73f95901c45beb8d8a29dd299 [^]
2018-02-14 18:37 jarmendariz Assigned To platform => jarmendariz
2018-02-14 18:37 jarmendariz Review Assigned To => caristu
2018-02-15 09:20 caristu File Added: cssCreatesTextInterface.diff
2018-02-15 09:35 hgbot Checkin
2018-02-15 09:35 hgbot Note Added: 0102426
2018-02-15 09:35 caristu Note Added: 0102427
2018-02-15 09:35 caristu Status resolved => closed
2018-02-15 09:35 caristu Fixed in Version => 3.0PR17Q4.1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker