Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037917 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | always | 2018-02-13 17:19 | 2018-03-12 13:15 | |||
| Reporter | jarmendariz | View Status | public | |||||
| Assigned To | jarmendariz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q1.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d9ca99578b53 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR18Q1.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037917: Internal CSS are included in AD_TextInterface as translatable content | |||||||
| Description | Html pages can embed some CSS in <style> tags, though it will be included in AD_TextInterfaces after running ant export.database, which is not desiderable. | |||||||
| Steps To Reproduce | 1) Apply the attached patch (cssCreatesTextInterface.diff) 2) Run "ant compile.complete" At the end of the output of this command you can see the following line, indicating that the styles are recognized as translatable content: [java] 1917 [main] INFO org.openbravo.translate.Translate - New label found [body {background-color: green;} h1 {color: red;} p {color: blue;}] in /org/openbravo/erpCommon/security/Login.html | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0103018) hgbot (developer) 2018-03-06 11:07 |
Repository: erp/backports/3.0PR18Q1.1 Changeset: d9ca99578b537508768a60f42667bf34fc4a6f48 Author: Javier Armendáriz <javier.armendariz <at> openbravo.com> Date: Fri Mar 02 12:39:36 2018 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/d9ca99578b537508768a60f42667bf34fc4a6f48 [^] Fixed issue 37917: Internal CSS are included in AD_TextInterfaces Adding <style> tags along <script> as tags excluded from being parsed for the Translate class. --- M src-trl/src/org/openbravo/translate/Translate.java --- |
|
(0103156) caristu (developer) 2018-03-12 13:15 |
Code reviewed + tested OK. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-02-14 18:10 | jarmendariz | Type | defect => backport |
| 2018-02-14 18:10 | jarmendariz | Target Version | => 3.0PR18Q1 |
| 2018-02-20 12:42 | alostale | Target Version | 3.0PR18Q1 => 3.0PR18Q1.1 |
| 2018-03-06 11:07 | hgbot | Checkin | |
| 2018-03-06 11:07 | hgbot | Note Added: 0103018 | |
| 2018-03-06 11:07 | hgbot | Status | scheduled => resolved |
| 2018-03-06 11:07 | hgbot | Resolution | open => fixed |
| 2018-03-06 11:07 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR18Q1.1/rev/d9ca99578b537508768a60f42667bf34fc4a6f48 [^] |
| 2018-03-09 16:27 | caristu | Review Assigned To | => caristu |
| 2018-03-12 13:15 | caristu | Note Added: 0103156 | |
| 2018-03-12 13:15 | caristu | Status | resolved => closed |
| 2018-03-12 13:15 | caristu | Fixed in Version | => 3.0PR18Q1.1 |
| 2018-03-12 13:15 | caristu | Assigned To | platform => jarmendariz |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |