Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037907
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2018-02-13 17:192018-03-05 18:25
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision0f39f1cd72c1
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037907: Internal CSS are included in AD_TextInterface as translatable content

DescriptionHtml pages can embed some CSS in <style> tags, though it will be included in AD_TextInterfaces after running ant export.database, which is not desiderable.
Steps To Reproduce1) Apply the attached patch (cssCreatesTextInterface.diff)
2) Run "ant compile.complete"

At the end of the output of this command you can see the following line, indicating that the styles are recognized as translatable content:

[java] 1917 [main] INFO org.openbravo.translate.Translate - New label found [body {background-color: green;} h1 {color: red;} p {color: blue;}] in /org/openbravo/erpCommon/security/Login.html
TagsNo tags attached.
Attached Filesdiff file icon cssCreatesTextInterface.diff [^] (574 bytes) 2018-02-13 17:19 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00379173.0PR18Q1.1 closedjarmendariz Openbravo ERP Internal CSS are included in AD_TextInterface as translatable content 
depends on backport 00379183.0PR17Q4.1 closedjarmendariz Openbravo ERP Internal CSS are included in AD_TextInterface as translatable content 
related to defect 0037916 closedjarmendariz Modules Remove wrong AD_TextInterface entry 
blocks design defect 0037740 closedjarmendariz Openbravo ERP support custom error pages 

-  Notes
(0102413)
hgbot (developer)
2018-02-14 18:30

 Repository: erp/devel/pi
Changeset: 0f39f1cd72c172607771dcefe7f3d4d6a6ca699a
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Feb 14 18:29:26 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0f39f1cd72c172607771dcefe7f3d4d6a6ca699a [^]

Fixed bug 37907: Internal CSS are included in AD_TextInterfaces

Adding <style> tags along <script> as tags excluded from being parsed for the Translate class.

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0102422)
hgbot (developer)
2018-02-15 08:50

 Repository: erp/devel/pi
Changeset: 2c6c3bf5a19ed7137d7e51ad97b1a4eafa6b8959
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Feb 15 08:50:37 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c6c3bf5a19ed7137d7e51ad97b1a4eafa6b8959 [^]

related to issue 37907: updated copyright year

---
M src-trl/src/org/openbravo/translate/Translate.java
---
(0102423)
caristu (developer)
2018-02-15 08:51

 Code reviewed + tested OK.
(0102760)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102763)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-02-13 17:19 jarmendariz New Issue
2018-02-13 17:19 jarmendariz Assigned To => platform
2018-02-13 17:19 jarmendariz File Added: cssCreatesTextInterface.diff
2018-02-13 17:19 jarmendariz Modules => Core
2018-02-13 17:19 jarmendariz Triggers an Emergency Pack => No
2018-02-14 09:25 caristu Relationship added blocks 0037740
2018-02-14 10:17 caristu Relationship deleted blocks 0037740
2018-02-14 10:17 caristu Relationship added related to 0037740
2018-02-14 13:49 jarmendariz Relationship replaced blocks 0037740
2018-02-14 17:51 jarmendariz Relationship added related to 0037916
2018-02-14 18:10 jarmendariz Status new => scheduled
2018-02-14 18:30 hgbot Checkin
2018-02-14 18:30 hgbot Note Added: 0102413
2018-02-14 18:30 hgbot Status scheduled => resolved
2018-02-14 18:30 hgbot Resolution open => fixed
2018-02-14 18:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0f39f1cd72c172607771dcefe7f3d4d6a6ca699a [^]
2018-02-14 18:37 jarmendariz Assigned To platform => jarmendariz
2018-02-14 18:37 jarmendariz Review Assigned To => caristu
2018-02-15 08:50 hgbot Checkin
2018-02-15 08:50 hgbot Note Added: 0102422
2018-02-15 08:51 caristu Note Added: 0102423
2018-02-15 08:51 caristu Status resolved => closed
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102760
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102763
2018-03-05 18:25 caristu Fixed in Version => 3.0PR18Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker