Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037897 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | always | 2018-02-06 15:53 | 2018-02-15 09:50 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | platform | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR17Q4.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 3329a5d35ffa | ||||
| Projection | none | ETA | none | Target Version | 3.0PR17Q4.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2016-01-28 | |||||||
| Regression introduced in release | 3.0PR16Q2 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037897: Callout not triggered when clearing a selector | |||||||
| Description | A callout is associated to a nullable column with a OBUISEL_Selector Reference. When the user selects something in the selector the callout is properly triggered. However when the user clears the selector (i.e. no value is selected) and the focus is changed to another field then the callout is NOT triggered. I have noticed a special case where the callout is properly triggered: when you open a window and then you clear the selector of an existing record (i.e. a record previously saved in the DB) then the callout is properly triggered. | |||||||
| Steps To Reproduce | Associate a callout with a nullable column with a OBUISEL_Selector Reference. Compile and restart tomcat in debug mode. Set a break point at the beginning of the callout. Create a new record in the correspondent window. Select any value in the selector and change the focus. Verify the callout is properly triggered. OK Now clears the selector and change the focus. The callout is NOT triggered. WRONG. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0102388) hgbot (developer) 2018-02-14 09:43 |
Repository: erp/backports/3.0PR17Q4.1 Changeset: 3329a5d35ffaa7915a9dbc99001cce238602147a Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Feb 14 09:40:23 2018 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/3329a5d35ffaa7915a9dbc99001cce238602147a [^] Fixes issue 37897: Callouts are invoked when clearing a non mandatory selector This changeset [1] fixed a problem where a callout was being called twice when picking a value from a selector. The first request was done properly, but the second one was done with a null value. The fix consisted in not notifying a change in selector when it was modified from a non-empty value to an empty value. But as a result, when a non mandatory selector is emptied, callouts are no longer being invoked. The original issue is very hard to reproduce, I have not been able to find a new way to reproduce it or fix it. To avoid the regression, now the code that was done to fix [1] will only take place if the selector is mandatory, to make sure that it is possible to give empty values to non-mandatory selectors. [1] https://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^] --- M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js --- |
|
(0102430) caristu (developer) 2018-02-15 09:50 |
Code reviewed + tested OK. Tested with Product field in the Lines tab of Sales Invoice window. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-02-13 10:36 | AugustoMauch | Type | defect => backport |
| 2018-02-13 10:36 | AugustoMauch | Target Version | => 3.0PR17Q4.1 |
| 2018-02-14 09:43 | hgbot | Checkin | |
| 2018-02-14 09:43 | hgbot | Note Added: 0102388 | |
| 2018-02-14 09:43 | hgbot | Status | scheduled => resolved |
| 2018-02-14 09:43 | hgbot | Resolution | open => fixed |
| 2018-02-14 09:43 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR17Q4.1/rev/3329a5d35ffaa7915a9dbc99001cce238602147a [^] |
| 2018-02-15 07:50 | alostale | Review Assigned To | => caristu |
| 2018-02-15 09:50 | caristu | Note Added: 0102430 | |
| 2018-02-15 09:50 | caristu | Status | resolved => closed |
| 2018-02-15 09:50 | caristu | Fixed in Version | => 3.0PR17Q4.1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |