Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037842
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2018-02-06 15:532018-02-22 18:19
ReportervmromanosView Statuspublic 
Assigned Toplatform 
PriorityimmediateResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision2ae5f4a8e8da
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2016-01-28
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^]
Triggers an Emergency PackNo
Summary

0037842: Callout not triggered when clearing a selector

DescriptionA callout is associated to a nullable column with a OBUISEL_Selector Reference.
When the user selects something in the selector the callout is properly triggered. However when the user clears the selector (i.e. no value is selected) and the focus is changed to another field then the callout is NOT triggered.

I have noticed a special case where the callout is properly triggered: when you open a window and then you clear the selector of an existing record (i.e. a record previously saved in the DB) then the callout is properly triggered.
Steps To ReproduceOpen the Sales Invoice window
- Create a record in the header tab
- In the Lines tab, select a product. Check that the price is updated
- Now give an empty value to the product field. Check that the price is not being emptied (this would have been done had the callout been called)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00378963.0PR18Q1 closedAugustoMauch Callout not triggered when clearing a selector 
depends on backport 00378973.0PR17Q4.1 closedplatform Callout not triggered when clearing a selector 
caused by defect 0032007 closedcaristu Double request to FIC in CHANGE mode when the form is redrawn by overflow under some circumstances 

-  Notes
(0102387)
hgbot (developer)
2018-02-14 09:41

 Repository: erp/devel/pi
Changeset: 2ae5f4a8e8da772e5a62bbaa7b8a51012411ef9e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 14 09:40:23 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2ae5f4a8e8da772e5a62bbaa7b8a51012411ef9e [^]

Fixes issue 37842: Callouts are invoked when clearing a non mandatory selector

This changeset [1] fixed a problem where a callout was being called twice when picking a value from a selector. The first request was done properly, but the
second one was done with a null value. The fix consisted in not notifying a change in selector when it was modified from a non-empty value to an empty value.

But as a result, when a non mandatory selector is emptied, callouts are no longer being invoked. The original issue is very hard to reproduce, I have not been
able to find a new way to reproduce it or fix it. To avoid the regression, now the code that was done to fix [1] will only take place if the selector is mandatory,
to make sure that it is possible to give empty values to non-mandatory selectors.

[1] https://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^]

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0102432)
hgbot (developer)
2018-02-15 10:37

 Repository: erp/devel/pi
Changeset: cdfabd384be43a9804b0d1de4c4a796949f61a17
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Feb 15 10:36:34 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cdfabd384be43a9804b0d1de4c4a796949f61a17 [^]

related to issue 37842: update copyright year

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0102433)
caristu (developer)
2018-02-15 10:38

 Code reviewed + tested OK.
(0102752)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102764)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-02-06 15:53 vmromanos New Issue
2018-02-06 15:53 vmromanos Assigned To => platform
2018-02-06 15:53 vmromanos Modules => Core
2018-02-06 15:53 vmromanos Triggers an Emergency Pack => No
2018-02-06 17:39 AugustoMauch Regression level => Production - Confirmed Stable
2018-02-06 17:39 AugustoMauch Regression date => 2016-01-28
2018-02-06 17:39 AugustoMauch Regression introduced in release => 3.0PR16Q2
2018-02-06 17:39 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^]
2018-02-07 13:07 alostale Relationship added caused by 0032007
2018-02-09 09:23 alostale Priority normal => immediate
2018-02-13 10:36 AugustoMauch Status new => scheduled
2018-02-14 09:41 hgbot Checkin
2018-02-14 09:41 hgbot Note Added: 0102387
2018-02-14 09:41 hgbot Status scheduled => resolved
2018-02-14 09:41 hgbot Resolution open => fixed
2018-02-14 09:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2ae5f4a8e8da772e5a62bbaa7b8a51012411ef9e [^]
2018-02-14 13:31 AugustoMauch Steps to Reproduce Updated View Revisions
2018-02-15 10:37 hgbot Checkin
2018-02-15 10:37 hgbot Note Added: 0102432
2018-02-15 10:38 caristu Review Assigned To => caristu
2018-02-15 10:38 caristu Note Added: 0102433
2018-02-15 10:38 caristu Status resolved => closed
2018-02-15 10:38 caristu Fixed in Version => 3.0PR18Q2
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102752
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102764

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker