Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037827
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] 04. Warehouse managementmajorN/A2018-02-05 10:022018-03-07 01:04
ReportervmromanosView Statuspublic 
Assigned Tovmromanos 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision9179fe0a1c2c
ProjectionnoneETAnoneTarget Version3.0PR18Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037827: Referenced Inventory

DescriptionFeature request to implement Referenced Inventory (Core part).
Steps To Reproducehttp://wiki.openbravo.com/wiki/Projects:Referenced_Inventory/Functional_Specification [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0038015 closedvmromanos Openbravo ERP Referenced Inventory. Attribute Value not copied correctly when Boxing stock 
related to defect 00380393.0PR18Q2 closedjarmendariz Openbravo ERP Organization filtering issues in Process Definition selectors 
related to defect 00380613.0PR18Q2 closedalostale Openbravo ERP Selector filter expression with OB.isSalesTransaction() doesn't work when called from a Process Definition 
blocks feature request 0037906 closedvmromanos Modules Referenced Inventory support for AWO 
causes defect 0037828 closedvmromanos Openbravo ERP False API change due to referenced inventory 

-  Notes
(0102172)
hgbot (developer)
2018-02-05 10:22

 Repository: erp/devel/pi
Changeset: fceb92c459574b09d41b2ec9577985eb27629a49
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 05 10:04:17 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fceb92c459574b09d41b2ec9577985eb27629a49 [^]

Fixed issue 37827: [ri] Added Referenced Inventory support

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M src-db/database/model/functions/M_MOVEMENT_POST.xml
M src-db/database/model/functions/M_UPDATE_INVENTORY.xml
M src-db/database/model/tables/M_ATTRIBUTESETINSTANCE.xml
M src-db/database/model/tables/M_MOVEMENTLINE.xml
M src-db/database/model/tables/M_STORAGE_DETAIL.xml
M src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MENU.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-db/database/sourcedata/AD_TREENODE.xml
M src-db/database/sourcedata/AD_WINDOW.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src-db/database/sourcedata/OBUIAPP_REF_WINDOW.xml
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src/org/openbravo/erpCommon/info/AttributeSetInstance.java
M src/org/openbravo/erpCommon/utility/AttributeSetInstanceValue.java
A src-db/database/model/tables/M_REFINVENTORY.xml
A src-db/database/model/tables/M_REFINVENTORY_TYPE.xml
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxForcedReservation.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxFullReservationTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxSeveralStorageDetailsTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryExceptionTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullBoxTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialBoxTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventorySequenceTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestSuite.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java
A src/org/openbravo/common/actionhandler/ReferencedInventoryBoxHandler.java
A src/org/openbravo/common/actionhandler/ReferencedInventoryUnBoxHandler.java
A src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
A src/org/openbravo/event/ReferenceInventoryEventHandler.java
A src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
A src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
A src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
A src/org/openbravo/materialmgmt/refinventory/ReservationManager.java
A src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java
---
(0102173)
hgbot (developer)
2018-02-05 10:22

 Repository: erp/devel/pi
Changeset: e4712f47df4392974d1bb925f3a005d16fea3d15
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 05 10:16:55 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e4712f47df4392974d1bb925f3a005d16fea3d15 [^]

Fixed issue 37827: [ri] Removed TODO as no need of hooks

---
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
---
(0102185)
hgbot (developer)
2018-02-05 12:43

 Repository: erp/devel/pi
Changeset: 53ef76edf8452311b8f13cb746f101e71d1872ea
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 05 12:42:34 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/53ef76edf8452311b8f13cb746f101e71d1872ea [^]

Fixed issue 37827: [ri] updated copyright year

---
M src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
M src/org/openbravo/event/ReferenceInventoryEventHandler.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
---
(0102209)
hgbot (developer)
2018-02-06 10:55

 Repository: erp/devel/pi
Changeset: fcdc7c1db65bceab7753c85ae69bfce370a4533d
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Feb 06 10:54:44 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fcdc7c1db65bceab7753c85ae69bfce370a4533d [^]

Fixed issue 37827: [ri] clear session after each test execution

---
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java
---
(0102216)
hgbot (developer)
2018-02-06 13:01

 Repository: erp/devel/pi
Changeset: 756a8987324d41af1e54c5cc5d1c419767c39821
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Feb 06 12:59:15 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/756a8987324d41af1e54c5cc5d1c419767c39821 [^]

Fixed issue 37827: [ri] clear session after each individual test execution

---
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxForcedReservation.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxFullReservationTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxSeveralStorageDetailsTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullBoxTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialBoxTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
---
(0102275)
hgbot (developer)
2018-02-08 17:48

 Repository: erp/devel/pi
Changeset: 967f7b6068eedef0e146bb97f70345ac36ecbe5f
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Feb 08 17:46:57 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/967f7b6068eedef0e146bb97f70345ac36ecbe5f [^]

Fixed issue 37827: [ri] Added message to Application Dictionary

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java
---
(0102391)
hgbot (developer)
2018-02-14 10:23

 Repository: erp/devel/pi
Changeset: de2414ba537927d64d10009227fa146791a0ec50
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 12 15:19:05 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/de2414ba537927d64d10009227fa146791a0ec50 [^]

Fixed issue 37827: [ri] Reservation Management Refactor

Removed new reservation management initially implemented for Referenced Inventory, and adapted the Core's engine to work with RI.

M_Movement_Post:
 1. The new storage detail passed to the M_RESERVE_STOCK_MANUAL takes into account the new m_attributesetinstanceto_id
 2. The check for unique bin in referenced inventory is only executed for RI movement, thus improving performance

M_RESERVE_STOCK_MANUAL:
 1. The code that gets the storage detail is able to work with reference inventory

ReferencedInventoryProcessor:
 1. Removed ReservationManager stuff as it is now directly executed in the existing Core's code
 2. The movement lines are created in 2 steps: first without reservation and, if necessary, moving reservations.
 3. Some util methods are moved to ReferencedInventoryUtil class.

Automatic tests modifications to adapt to new logic:
 1. Now we always work in just one reservation, and we don't create a new one releasing from the existing one anymore.
 2. The goods movement might create several lines (depending on reservation quantities)
 3. Split some tests to make them more readable

---
M src-db/database/model/functions/M_MOVEMENT_POST.xml
M src-db/database/model/functions/M_RESERVE_STOCK_MANUAL.xml
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxForcedReservation.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestSuite.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservation1MovementLineTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservation2MovementLinesTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservation1MovementLineTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservation2MovementLinesTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation1MovementLineUnboxTest.java
A src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation2MovementLinesUnboxTest.java
R src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
R src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
R src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
R src/org/openbravo/materialmgmt/refinventory/ReservationManager.java
---
(0102392)
hgbot (developer)
2018-02-14 10:24

 Repository: erp/devel/pi
Changeset: e9356b180aac683c6d1cecdf9056bb0e0c2cd313
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 12 19:29:47 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e9356b180aac683c6d1cecdf9056bb0e0c2cd313 [^]

Fixed issue 37827: [ri] declare method as public to be used by AWO

---
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
---
(0102564)
hgbot (developer)
2018-02-21 19:05

 Repository: erp/devel/pi
Changeset: 9cb6170994b12df7d36d7ff6fb53b33d1cde11aa
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Feb 13 18:05:20 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9cb6170994b12df7d36d7ff6fb53b33d1cde11aa [^]

Fixed issue 37827: [ri] redesign M_REFINVENTORY_VALUE_UN unique constraint
For AWO purposes it's better to ensure a unique referenced inventory per client.

---
M src-db/database/model/tables/M_REFINVENTORY.xml
---
(0102565)
hgbot (developer)
2018-02-21 19:05

 Repository: erp/devel/pi
Changeset: 499ed06c9d18daaf5f81314a39e71629a3495a39
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Sat Feb 17 09:33:17 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/499ed06c9d18daaf5f81314a39e71629a3495a39 [^]

Fixed issue 37827: [ri] set original attributesetinstance=0 if null

---
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
---
(0102566)
hgbot (developer)
2018-02-21 19:05

 Repository: erp/devel/pi
Changeset: 526633fb1fd0db848ff139ce8450bbdc8f6dc2e2
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Feb 20 17:38:26 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/526633fb1fd0db848ff139ce8450bbdc8f6dc2e2 [^]

Fixed issue 37827: [ri] Moved validation over storage bin in boxing to Core

---
M src-db/database/sourcedata/AD_VAL_RULE.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
---
(0102567)
hgbot (developer)
2018-02-21 19:05

 Repository: erp/devel/pi
Changeset: 28ecb6656be7f72d05e0ccd07b19c19be97192f2
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Feb 20 17:50:47 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/28ecb6656be7f72d05e0ccd07b19c19be97192f2 [^]

Fixed issue 37827: [ri] transform index to partial index

---
M src-db/database/model/tables/M_STORAGE_DETAIL.xml
---
(0102568)
hgbot (developer)
2018-02-21 19:05

 Repository: erp/devel/pi
Changeset: b6a93ba857f3e251039dab3a0a54830e90104686
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Feb 21 10:12:00 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b6a93ba857f3e251039dab3a0a54830e90104686 [^]

Fixed issue 37827: [ri] Added RefInventory to M_PRODUCT_STOCK_V and related selectors

---
M src-db/database/model/views/M_PRODUCT_STOCK_V.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
---
(0102715)
hudsonbot (developer)
2018-02-22 18:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102716)
hudsonbot (developer)
2018-02-22 18:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102718)
hudsonbot (developer)
2018-02-22 18:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102723)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102724)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102735)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102753)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102754)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102787)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102788)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102789)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102790)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102791)
hudsonbot (developer)
2018-02-22 18:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102837)
hgbot (developer)
2018-02-27 09:08

 Repository: erp/devel/pi
Changeset: 5c21517ea155534712ce7ced27fa91049b0790e6
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 26 17:29:18 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5c21517ea155534712ce7ced27fa91049b0790e6 [^]

Fixed issue 37827: [ri] M_Movement_Post referenced inventory validation improvement
The validation was previously executed only for a boxing activity, however we also need to validate any movement where a referenced inventory is involved.
This avoids partial movements of boxes

---
M src-db/database/model/functions/M_MOVEMENT_POST.xml
---
(0102951)
hudsonbot (developer)
2018-03-02 21:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05dece3dc80b [^]
Maturity status: Test
(0102987)
hgbot (developer)
2018-03-05 17:09

 Repository: erp/devel/pi
Changeset: 00def91a508f1542966d141415ddc73ff9cd38cf
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Mar 02 13:33:57 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/00def91a508f1542966d141415ddc73ff9cd38cf [^]

Fixed issue 37827: [ri] [cr] M_Movement_Post validation at document level

The validation that ensures the same referenced inventory is not located in two different bins have been moved from line level to document level.
This is necessary to ensure we can fully move all the storage details within a referenced inventory to a different bin.

---
M src-db/database/model/functions/M_MOVEMENT_POST.xml
---
(0102989)
hgbot (developer)
2018-03-05 17:09

 Repository: erp/devel/pi
Changeset: 66d89284c6608040f4c3992f315d9f68fbcd8501
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Mar 05 13:33:07 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/66d89284c6608040f4c3992f315d9f68fbcd8501 [^]

Fixed issue 37827: [ri] [cr] Code review improvements

M_RESERVE_STOCK_MANUAL:
 Removed useless COALESCE

M_UPDATE_INVENTORY:
 Added comment to clarify code

AD:
 Added help/description where missed
 Declared Referenced Inventory windows as Purchase to force on hand selector to not filter by on hand warehouses.

ReferencedInventoryUnBoxHandler:
 Removed useles throw JSONException

SE_RefInventory_RefInvType:
 Use org.slf4j.Logger

AttributeSetInstance:
 Use && instead of &

BoxProcessor:
 Add to cache map the found attribute set instance so the process is faster
 Removed useless override of method createAndProcessGoodsMovement(). This would create a false positive

ReferencedInventoryProcessor:
 Do not check reservationStockScroll != null
 Do not create variable to inmediately return it

ReferencedInventoryUtil:
 Added Javadoc in public method

Automatic Tests:
 Declared static constants where missed
 Clarify if condition by creating private methods
 Declare private methods where useful
 Use org.slf4j.Logger

---
M src-db/database/model/functions/M_RESERVE_STOCK_MANUAL.xml
M src-db/database/model/functions/M_UPDATE_INVENTORY.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
M src-db/database/sourcedata/AD_WINDOW.xml
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxForcedReservation.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullBoxTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialBoxTest.java
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventorySequenceTest.java
M src/org/openbravo/common/actionhandler/ReferencedInventoryBoxHandler.java
M src/org/openbravo/common/actionhandler/ReferencedInventoryUnBoxHandler.java
M src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
M src/org/openbravo/erpCommon/info/AttributeSetInstance.java
M src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
---
(0102990)
hgbot (developer)
2018-03-05 17:09

 Repository: erp/devel/pi
Changeset: a59ae9cabeb052c512eecae6c42df48b1e978aa3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Mar 05 13:45:45 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a59ae9cabeb052c512eecae6c42df48b1e978aa3 [^]

Fixed issue 37827: [ri] [cr] Code review improvements

Reordered and hide some fields
Added UOM display logic where missed
Fixed javadoc typo
Control NPE in ReferencedInventoryUtil.getProposedValueFromSequenceOrNull()

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestSuite.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
---
(0102991)
hgbot (developer)
2018-03-05 17:09

 Repository: erp/devel/pi
Changeset: 9179fe0a1c2c85006cb657db954a21b0f276ff20
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Mar 05 13:54:53 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9179fe0a1c2c85006cb657db954a21b0f276ff20 [^]

Fixed issue 37827: [ri] [cr] Added unique constraint.
This will create a false positive in PI

---
M src-db/database/model/tables/M_REFINVENTORY_TYPE.xml
---
(0102998)
hudsonbot (developer)
2018-03-05 23:45

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ae235ad7fcda [^]
Maturity status: Test
(0103000)
hudsonbot (developer)
2018-03-05 23:45

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ae235ad7fcda [^]
Maturity status: Test
(0103001)
hudsonbot (developer)
2018-03-05 23:45

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ae235ad7fcda [^]
Maturity status: Test
(0103002)
hudsonbot (developer)
2018-03-05 23:45

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ae235ad7fcda [^]
Maturity status: Test
(0103032)
hgbot (developer)
2018-03-06 16:55

 Repository: erp/devel/pi
Changeset: f71fb18c45380f8be585dde53b509558945e1981
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Mar 06 16:55:15 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f71fb18c45380f8be585dde53b509558945e1981 [^]

Related to Issue 37827: [ri][cr] Changed "x" expression for one that explains
why we compare an id to a literal that is not going to match any Id

---
M src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
---
(0103034)
dmiguelez (developer)
2018-03-06 16:58

 Code Review + Testing Ok
(0103050)
hudsonbot (developer)
2018-03-07 01:04

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/14b1dec19bfc [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-02-05 10:02 vmromanos New Issue
2018-02-05 10:02 vmromanos Assigned To => vmromanos
2018-02-05 10:02 vmromanos Modules => Core
2018-02-05 10:02 vmromanos Triggers an Emergency Pack => No
2018-02-05 10:03 vmromanos Status new => scheduled
2018-02-05 10:10 vmromanos Relationship added causes 0037828
2018-02-05 10:22 hgbot Checkin
2018-02-05 10:22 hgbot Note Added: 0102172
2018-02-05 10:22 hgbot Status scheduled => resolved
2018-02-05 10:22 hgbot Resolution open => fixed
2018-02-05 10:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fceb92c459574b09d41b2ec9577985eb27629a49 [^]
2018-02-05 10:22 hgbot Checkin
2018-02-05 10:22 hgbot Note Added: 0102173
2018-02-05 10:22 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/fceb92c459574b09d41b2ec9577985eb27629a49 [^] => http://code.openbravo.com/erp/devel/pi/rev/e4712f47df4392974d1bb925f3a005d16fea3d15 [^]
2018-02-05 10:39 vmromanos Review Assigned To => dmiguelez
2018-02-05 12:43 hgbot Checkin
2018-02-05 12:43 hgbot Note Added: 0102185
2018-02-05 12:43 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e4712f47df4392974d1bb925f3a005d16fea3d15 [^] => http://code.openbravo.com/erp/devel/pi/rev/53ef76edf8452311b8f13cb746f101e71d1872ea [^]
2018-02-06 10:55 hgbot Checkin
2018-02-06 10:55 hgbot Note Added: 0102209
2018-02-06 10:55 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/53ef76edf8452311b8f13cb746f101e71d1872ea [^] => http://code.openbravo.com/erp/devel/pi/rev/fcdc7c1db65bceab7753c85ae69bfce370a4533d [^]
2018-02-06 13:01 hgbot Checkin
2018-02-06 13:01 hgbot Note Added: 0102216
2018-02-06 13:01 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/fcdc7c1db65bceab7753c85ae69bfce370a4533d [^] => http://code.openbravo.com/erp/devel/pi/rev/756a8987324d41af1e54c5cc5d1c419767c39821 [^]
2018-02-08 17:48 hgbot Checkin
2018-02-08 17:48 hgbot Note Added: 0102275
2018-02-08 17:48 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/756a8987324d41af1e54c5cc5d1c419767c39821 [^] => http://code.openbravo.com/erp/devel/pi/rev/967f7b6068eedef0e146bb97f70345ac36ecbe5f [^]
2018-02-13 16:06 vmromanos Relationship added blocks 0037906
2018-02-14 10:23 hgbot Checkin
2018-02-14 10:23 hgbot Note Added: 0102391
2018-02-14 10:23 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/967f7b6068eedef0e146bb97f70345ac36ecbe5f [^] => http://code.openbravo.com/erp/devel/pi/rev/de2414ba537927d64d10009227fa146791a0ec50 [^]
2018-02-14 10:24 hgbot Checkin
2018-02-14 10:24 hgbot Note Added: 0102392
2018-02-14 10:24 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/de2414ba537927d64d10009227fa146791a0ec50 [^] => http://code.openbravo.com/erp/devel/pi/rev/e9356b180aac683c6d1cecdf9056bb0e0c2cd313 [^]
2018-02-21 19:05 hgbot Checkin
2018-02-21 19:05 hgbot Note Added: 0102564
2018-02-21 19:05 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e9356b180aac683c6d1cecdf9056bb0e0c2cd313 [^] => http://code.openbravo.com/erp/devel/pi/rev/9cb6170994b12df7d36d7ff6fb53b33d1cde11aa [^]
2018-02-21 19:05 hgbot Checkin
2018-02-21 19:05 hgbot Note Added: 0102565
2018-02-21 19:05 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/9cb6170994b12df7d36d7ff6fb53b33d1cde11aa [^] => http://code.openbravo.com/erp/devel/pi/rev/499ed06c9d18daaf5f81314a39e71629a3495a39 [^]
2018-02-21 19:05 hgbot Checkin
2018-02-21 19:05 hgbot Note Added: 0102566
2018-02-21 19:05 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/499ed06c9d18daaf5f81314a39e71629a3495a39 [^] => http://code.openbravo.com/erp/devel/pi/rev/526633fb1fd0db848ff139ce8450bbdc8f6dc2e2 [^]
2018-02-21 19:05 hgbot Checkin
2018-02-21 19:05 hgbot Note Added: 0102567
2018-02-21 19:05 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/526633fb1fd0db848ff139ce8450bbdc8f6dc2e2 [^] => http://code.openbravo.com/erp/devel/pi/rev/28ecb6656be7f72d05e0ccd07b19c19be97192f2 [^]
2018-02-21 19:05 hgbot Checkin
2018-02-21 19:05 hgbot Note Added: 0102568
2018-02-21 19:05 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/28ecb6656be7f72d05e0ccd07b19c19be97192f2 [^] => http://code.openbravo.com/erp/devel/pi/rev/b6a93ba857f3e251039dab3a0a54830e90104686 [^]
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102715
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102716
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102718
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102723
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102724
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102735
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102753
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102754
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102787
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102788
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102789
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102790
2018-02-22 18:19 hudsonbot Checkin
2018-02-22 18:19 hudsonbot Note Added: 0102791
2018-02-27 09:08 hgbot Checkin
2018-02-27 09:08 hgbot Note Added: 0102837
2018-02-27 09:08 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/b6a93ba857f3e251039dab3a0a54830e90104686 [^] => http://code.openbravo.com/erp/devel/pi/rev/5c21517ea155534712ce7ced27fa91049b0790e6 [^]
2018-02-28 13:49 vmromanos Relationship added related to 0038015
2018-03-02 21:18 hudsonbot Checkin
2018-03-02 21:18 hudsonbot Note Added: 0102951
2018-03-05 13:25 vmromanos Relationship added related to 0038039
2018-03-05 17:09 hgbot Checkin
2018-03-05 17:09 hgbot Note Added: 0102987
2018-03-05 17:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/5c21517ea155534712ce7ced27fa91049b0790e6 [^] => http://code.openbravo.com/erp/devel/pi/rev/00def91a508f1542966d141415ddc73ff9cd38cf [^]
2018-03-05 17:09 hgbot Checkin
2018-03-05 17:09 hgbot Note Added: 0102989
2018-03-05 17:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/00def91a508f1542966d141415ddc73ff9cd38cf [^] => http://code.openbravo.com/erp/devel/pi/rev/66d89284c6608040f4c3992f315d9f68fbcd8501 [^]
2018-03-05 17:09 hgbot Checkin
2018-03-05 17:09 hgbot Note Added: 0102990
2018-03-05 17:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/66d89284c6608040f4c3992f315d9f68fbcd8501 [^] => http://code.openbravo.com/erp/devel/pi/rev/a59ae9cabeb052c512eecae6c42df48b1e978aa3 [^]
2018-03-05 17:09 hgbot Checkin
2018-03-05 17:09 hgbot Note Added: 0102991
2018-03-05 17:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/a59ae9cabeb052c512eecae6c42df48b1e978aa3 [^] => http://code.openbravo.com/erp/devel/pi/rev/9179fe0a1c2c85006cb657db954a21b0f276ff20 [^]
2018-03-05 23:45 hudsonbot Checkin
2018-03-05 23:45 hudsonbot Note Added: 0102998
2018-03-05 23:45 hudsonbot Checkin
2018-03-05 23:45 hudsonbot Note Added: 0103000
2018-03-05 23:45 hudsonbot Checkin
2018-03-05 23:45 hudsonbot Note Added: 0103001
2018-03-05 23:45 hudsonbot Checkin
2018-03-05 23:45 hudsonbot Note Added: 0103002
2018-03-06 16:55 hgbot Checkin
2018-03-06 16:55 hgbot Note Added: 0103032
2018-03-06 16:58 dmiguelez Note Added: 0103034
2018-03-06 16:58 dmiguelez Status resolved => closed
2018-03-06 16:58 dmiguelez Fixed in Version => 3.0PR18Q2
2018-03-06 17:52 vmromanos Relationship added related to 0038061
2018-03-07 01:04 hudsonbot Checkin
2018-03-07 01:04 hudsonbot Note Added: 0103050

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker