|View Issue Details|
|Type||Category||Severity||Reproducibility||Date Submitted||Last Update|
|backport||[Openbravo ERP] 09. Financial management||major||have not tried||2015-08-24 11:51||2018-01-31 10:02|
|Priority||normal||Resolution||fixed||Fixed in Version||3.0PR18Q1|
|Status||closed||Fix in branch||Fixed in SCM revision||7cd239fd329a|
|OS Version||Database version||Ant version|
|Product Version||SCM revision|
|Review Assigned To||dmiguelez|
|Regression introduced in release|
|Regression introduced by commit|
|Triggers an Emergency Pack||No|
0037785: Overly huge request size in AddPaymentDisplayLogicActionHandler
|Description||Looking in net panel i see several request to that display action handler|
and last one of those seem to have in its request json
context -> sales_order_invoice -> _allRows
and then array with all the values of all the rows.
+ then on top in _selected
copy of all data again for the selected rows.
and that is up to 20-30k already just for 4 lines i saw in grid.
So will get much bigger in case you have more lines in your view.
|Steps To Reproduce||new sales invoice + 1 line + complete|
then just add payment
and in the popup it did show me apparently 4 other invoices.
Look at the net panel
|Proposed Solution||The request to that action handler is apparently only done from the OB.APRM.AddPayment.recalcDisplayLogicOrReadOnlyLogic function.|
In the parameter windows, when the value of the grid is requested (i.e. when invoking the getContextInfo, which is done in the recalcDisplayLogicOrReadOnlyLogic function), the returned value contains the list of selected records plus the list of all grid records if the grid contents are completely cached. If you don't need any of those values, you could just get rid of them before including them in the request.
|Tags||No tags attached.|
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 19 09:25:37 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/7cd239fd329a4eb2fd0eddd0d05deaa58cb17bad [^]
Fixes Issue 37785:Overly huge request size in AddPaymentDisplayLogicActionHandle
Before sending the context, the grids with the information about orders and invoices,
gl items and credit used are removed from it.
This data is not used for calculating the display or read only logic of the rest of the parameters
and sending the grid can have an impact in the performance of this process.
|Code Review + Testing Ok|
|2018-01-31 09:42||dmiguelez||Type||defect => backport|
|2018-01-31 09:42||dmiguelez||Target Version||=> 3.0PR18Q1|
|2018-01-31 09:58||hgbot||Note Added: 0102082|
|2018-01-31 09:58||hgbot||Status||scheduled => resolved|
|2018-01-31 09:58||hgbot||Resolution||open => fixed|
|2018-01-31 09:58||hgbot||Fixed in SCM revision||http://code.openbravo.com/erp/devel/pi/rev/436eb0fb4c04367a4ff2502421f53db6381318be [^] => http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/7cd239fd329a4eb2fd0eddd0d05deaa58cb17bad [^]|
|2018-01-31 10:02||dmiguelez||Note Added: 0102084|
|2018-01-31 10:02||dmiguelez||Status||resolved => closed|
|2018-01-31 10:02||dmiguelez||Fixed in Version||=> 3.0PR18Q1|
|Copyright © 2000 - 2009 MantisBT Group|