Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037703
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] 09. Financial managementminoralways2018-01-23 10:202018-02-22 18:18
ReporterdmiguelezView Statuspublic 
Assigned ToTriage Finance 
PrioritylowResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision7ed116cab029
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037703: Refactor TestCosting class to make it more manageable.

DescriptionRefactor TestCosting class to make it more manageable.

This class has become too big to manage, refactor it to make it easier to maintain.
Steps To ReproduceRefactor TestCosting class to make it more manageable.

This class has become too big to manage, refactor it to make it easier to maintain.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0101885)
hgbot (developer)
2018-01-23 10:22

Repository: erp/devel/pi
Changeset: 7ed116cab029986758076af3858c25b86803bede
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Jan 22 17:05:50 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7ed116cab029986758076af3858c25b86803bede [^]

Fixes Issue 37703. Refactors TestCosting class

* Assert Classes were placed in a new package
* Constants were moved to a new class
* TestCostingUtils now contains all the API to create tests
* New test classes were created containig the tests
* TestCosting class was converted into a suite running all test classes

---
M src-test/src/org/openbravo/test/costing/TestCosting.java
A src-test/src/org/openbravo/test/costing/TestCostingBase.java
A src-test/src/org/openbravo/test/costing/TestCostingLandedCost.java
A src-test/src/org/openbravo/test/costing/TestCostingNoSourceAdjustments.java
A src-test/src/org/openbravo/test/costing/TestCostingSourceAdjustments.java
A src-test/src/org/openbravo/test/costing/TestIssue37033.java
A src-test/src/org/openbravo/test/costing/TestIssue37279.java
A src-test/src/org/openbravo/test/costing/assertclass/CostAdjustmentAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/DocumentPostAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/LandedCostCostMatchedAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/LandedCostReceiptLineAmountAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/MatchedInvoicesAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/OrderToReceiptResult.java
A src-test/src/org/openbravo/test/costing/assertclass/PhysicalInventoryAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/ProductCostingAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/ProductTransactionAssert.java
A src-test/src/org/openbravo/test/costing/utils/TestCostingConstants.java
A src-test/src/org/openbravo/test/costing/utils/TestCostingUtils.java
R src-test/src/org/openbravo/test/costing/TestCostingUtils.java
---
(0101887)
dmiguelez (developer)
2018-01-23 10:24

Test Plan:

Lanch TestCosting suite and check that everything is ok
(0101888)
dmiguelez (developer)
2018-01-23 10:25

Code Review + Testing Ok
(0102681)
hudsonbot (developer)
2018-02-22 18:18

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-01-23 10:20 dmiguelez New Issue
2018-01-23 10:20 dmiguelez Assigned To => Triage Finance
2018-01-23 10:20 dmiguelez Modules => Core
2018-01-23 10:20 dmiguelez Triggers an Emergency Pack => No
2018-01-23 10:22 hgbot Checkin
2018-01-23 10:22 hgbot Note Added: 0101885
2018-01-23 10:22 hgbot Status new => resolved
2018-01-23 10:22 hgbot Resolution open => fixed
2018-01-23 10:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7ed116cab029986758076af3858c25b86803bede [^]
2018-01-23 10:24 dmiguelez Note Added: 0101887
2018-01-23 10:25 dmiguelez Review Assigned To => dmiguelez
2018-01-23 10:25 dmiguelez Note Added: 0101888
2018-01-23 10:25 dmiguelez Status resolved => closed
2018-01-23 10:25 dmiguelez Fixed in Version => 3.0PR18Q2
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102681


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker