0037655: Logclient information can accumulate in the terminal, and be continously sent to the backend server

Description

The logclient information is saved temporarily in a local database table, and is sent to the server every 30 seconds. If the server correctly receives it, then the terminal removes it, and otherwise tries to send it again the next time.

However, in some very specific cases, the server may erroneously conclude that the messages were not correctly saved, and then the terminal will send the messages again, and therefore the log messages will never be deleted from the terminal, and new messages will continuously accumulate until the terminal crashes.

Steps To Reproduce

- Log in the WebPOS with terminal VBS-1 with Openbravo user
- Open the backoffice in another tab in the same browser.
- Change the organization in backoffice to "Central Mountain")
- Put a breakpoint in LogclientLoader class.
- Wait until the log is sent from the WebPOS and the breakpoint stops.
- Logout in the backoffice, and refresh the WebPOS.
- Remove the breakpoint.

With these steps, you ensure that you saved logclient messages in a wrong organization, and that the messages were not deleted from the WebPOS.

- Now, log in with vallblanca user in the WebPOS.
- The pending messages will be resent. However, this request will fail, and the messages will be kept in the terminal forever. There is no way to escape from this situation, other than deleting the cache.

Proposed Solution

The LogClientLoader must be changed so that it is able to find records which were created even in unaccessible organizations.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0037656	RR18Q1	closed	marvintm	Logclient information can accumulate in the terminal, and be continously sent to the backend server
depends on	backport	0037657	RR17Q4.1	closed	marvintm	Logclient information can accumulate in the terminal, and be continously sent to the backend server
depends on	backport	0037658	RR17Q3.3	closed	marvintm	Logclient information can accumulate in the terminal, and be continously sent to the backend server
related to	design defect	0037660		new	Retail	Logclient information may be saved in a wrong organization if context is changed

Notes
(0101748) hgbot (developer) 2018-01-17 11:59	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 51bba587f4f6c60bb6eff35fc75019fc860e45eb Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Wed Jan 17 11:59:31 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/51bba587f4f6c60bb6eff35fc75019fc860e45eb [^] Fixed issue 37655. Existing logclient records will now always be found Now the query that checks if the logclient record exists will no longer filter by client/organization, and therefore will be able to find records which were mistakenly created in a non-accessible organization. This will prevent some records from becoming stuck in the terminal. --- M src/org/openbravo/mobile/core/utils/LogClientLoader.java ---

(0101751) migueldejuana (developer) 2018-01-17 12:19	Reviewed

Issue History
Date Modified	Username	Field	Change
2018-01-17 11:57	marvintm	New Issue
2018-01-17 11:57	marvintm	Assigned To	=> marvintm
2018-01-17 11:57	marvintm	Triggers an Emergency Pack	=> No
2018-01-17 11:57	marvintm	Status	new => scheduled
2018-01-17 11:59	hgbot	Checkin
2018-01-17 11:59	hgbot	Note Added: 0101748
2018-01-17 11:59	hgbot	Status	scheduled => resolved
2018-01-17 11:59	hgbot	Resolution	open => fixed
2018-01-17 11:59	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/51bba587f4f6c60bb6eff35fc75019fc860e45eb [^]
2018-01-17 12:19	migueldejuana	Review Assigned To	=> migueldejuana
2018-01-17 12:19	migueldejuana	Note Added: 0101751
2018-01-17 12:19	migueldejuana	Status	resolved => closed
2018-01-17 12:23	marvintm	Relationship added	related to 0037660