0037570: Tests LayawayProductsNotInAssortment and QuotationProductsNotInAssortment are failing in Q4 after fix for issue 37558

Description

Below test are failing:

LayawayProductsNotInAssortment
QuotationProductsNotInAssortment

They are failling because of this line

    adjustPrices: function () {
      // Apply calculated discounts and promotions to price and gross prices
      // so ERP saves them in the proper place
      this.get('lines').each(function (line) {
        var price = line.get('price'),
            gross = line.get('gross'),
            totalDiscount = 0,
            grossListPrice = line.get('priceList'),
            grossUnitPrice, discountPercentage, base;

        // Calculate inline discount: discount applied before promotions
        if ((line.get('product').get('standardPrice') && line.get('product').get('standardPrice') !== price) || (_.isNumber(line.get('discountedLinePrice')) && line.get('discountedLinePrice') !== line.get('product').get('standardPrice'))) {
          grossUnitPrice = new BigDecimal(price.toString());
---->>>>> if (OB.DEC.compare(grossListPrice) === 0)

at this point grossListPrice is undefined

Steps To Reproduce

execute test in 17Q4 release.

They can be also reproducible manually executing the same steps done by mentioned tests.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

0037572

RR17Q4.1

closed

ranjith_qualiantech_com

Under certain circumstances when creating a sales order from a quotation wrong data is generated in the backend

Notes
(0101303) guilleaer (manager) 2018-01-03 10:32	No chnage required. This issue depends on a fix not included in 17Q4, so a backport for that issue was created https://issues.openbravo.com/view.php?id=37572 [^]

Issue History
Date Modified	Username	Field	Change
2017-12-29 14:53	guilleaer	New Issue
2017-12-29 14:53	guilleaer	Assigned To	=> ranjith_qualiantech_com
2017-12-29 14:53	guilleaer	Regression introduced by commit	=> https://code.openbravo.com/retail/backports/3.0RR17Q4/org.openbravo.retail.posterminal/rev/73da959ee44d [^]
2017-12-29 14:53	guilleaer	Triggers an Emergency Pack	=> No
2018-01-03 10:30	guilleaer	Relationship added	depends on 0037572
2018-01-03 10:31	guilleaer	Status	new => scheduled
2018-01-03 10:32	guilleaer	Note Added: 0101303
2018-01-03 10:32	guilleaer	Status	scheduled => resolved
2018-01-03 10:32	guilleaer	Fixed in Version	=> RR17Q4.1
2018-01-03 10:32	guilleaer	Resolution	open => fixed
2018-01-03 10:32	guilleaer	Review Assigned To	=> guilleaer
2018-01-03 10:32	guilleaer	Status	resolved => closed