Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037513
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServermajorhave not tried2017-12-19 15:152018-06-05 13:51
ReporterAugustoMauchView Statuspublic 
Assigned Tojonibc 
PrioritynormalResolutionfixedFixed in VersionRR18Q3
StatusclosedFix in branchFixed in SCM revision7f15b019a837
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037513: org.openbravo.retail.contactinfoforproduct should have an event handler to manage business partner segmentation

DescriptionIn order to manage the business partner segmentation, it is required to know to what versions does each business partner belong.

This event handler [1] automatically assigns a store to a business partner if the business partner is used in an order that belongs to an organization that the business partner does not belong to yet.

The same should be done when an orderline is created whose EM_OBRCIFP_C_BPARTNER_ID column points to a business partner that does not belong to the organization of the order line. The event handler [1] can be used as a template to implement the new one.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/eventhandler/OrderEventHandler.java [^]
Steps To ReproduceTo be defined by the team that fixes the issue, I don't know how the EM_OBRCIFP_C_BPARTNER_ID column is filled in Web POS.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0039936 closedguillermogil org.openbravo.retail.contactinfoforproduct hook is looking for a wrong BP 

-  Notes
(0104108)
hgbot (developer)
2018-04-26 16:14

Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct.synchronization
Changeset: 7f15b019a837fa270d1b94698fc33f46cd1924d4
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Thu Apr 26 16:13:37 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct.synchronization/rev/7f15b019a837fa270d1b94698fc33f46cd1924d4 [^]

Fixed issue 37513: contactinfoforproduct should have an event handler to manage business partner segmentation.
Added event handler to automatically assign the store to the Business Partner assigned to the line.

---
A src/org/openbravo/retail/contactinfoforproduct/synchronization/handler/ContactInfoBusinessPartnerEventHandler.java
---
(0104682)
dmitry_mezentsev (developer)
2018-05-24 19:11

Ping.
"The following issue is resolved but not yet closed for 28 days."
(0104789)
marvintm (manager)
2018-05-29 19:27

The fix as it is implemented currently doesn't work. The logic seems to be correct, but as it is implemented as an EventHandler, it is not executed in the OrderLoader because the triggers are disabled (which also indirectly disables all EventHandlers).

The proper implementation probably should be done as an OrderLoaderHook if it is confirmed that all orders which should trigger this logic will come through the OrderLoader.
(0104938)
hgbot (developer)
2018-06-05 13:06

Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct.synchronization
Changeset: e61df5c12ce8d1b54eb45acf571c5143e083651a
Author: Jonathan Bueno <jonathan.bueno <at> openbravo.com>
Date: Tue Jun 05 13:06:09 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct.synchronization/rev/e61df5c12ce8d1b54eb45acf571c5143e083651a [^]

Updated issue 37513: Change logic to hook.

---
A src/org/openbravo/retail/contactinfoforproduct/synchronization/hook/ContactInfoBusinessOrderLoaderHook.java
R src/org/openbravo/retail/contactinfoforproduct/synchronization/handler/ContactInfoBusinessPartnerEventHandler.java
---

- Issue History
Date Modified Username Field Change
2017-12-19 15:15 AugustoMauch New Issue
2017-12-19 15:15 AugustoMauch Assigned To => asiermartirena
2017-12-19 15:15 AugustoMauch Triggers an Emergency Pack => No
2018-04-26 16:14 hgbot Checkin
2018-04-26 16:14 hgbot Note Added: 0104108
2018-04-26 16:14 hgbot Status new => resolved
2018-04-26 16:14 hgbot Resolution open => fixed
2018-04-26 16:14 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct.synchronization/rev/7f15b019a837fa270d1b94698fc33f46cd1924d4 [^]
2018-05-24 19:11 dmitry_mezentsev Note Added: 0104682
2018-05-29 19:27 marvintm Assigned To asiermartirena => jonibc
2018-05-29 19:27 marvintm Note Added: 0104789
2018-05-29 19:27 marvintm Status resolved => new
2018-05-29 19:27 marvintm Resolution fixed => open
2018-06-05 13:06 hgbot Checkin
2018-06-05 13:06 hgbot Note Added: 0104938
2018-06-05 13:08 marvintm Status new => scheduled
2018-06-05 13:10 marvintm Status scheduled => resolved
2018-06-05 13:10 marvintm Fixed in Version => RR18Q3
2018-06-05 13:10 marvintm Resolution open => fixed
2018-06-05 13:51 marvintm Review Assigned To => marvintm
2018-06-05 13:51 marvintm Status resolved => closed
2019-01-14 08:15 guillermogil Relationship added related to 0039936


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker