Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037430
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Remittancemajoralways2017-12-01 10:492017-12-19 09:19
ReportermaiteView Statuspublic 
Assigned Tocollazoandy4 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7b170efb992b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0037430: Wrong "line_id" generated in Remittance posting when several remittance lines are related with same payment

DescriptionIncorrect "line_id" is being generated when posting a remittance which has several lines related with same payment. All accounting details (fact_acct records) are generated with first line_id associated instead of specific line_id of each remittance line
Steps To Reproduce0. Access as System Administrator to "Windows tabs and fields" and show field "SQL Description" for General Ledger Configuration window, Active Tables tab
1. Access to "F&B International Group US/A/US Dollar" general ledger and define following description for "REM_Remittance" table:

select rl.rem_remittanceline_id || ' - ' || rl.line || ' hola ' from rem_remittanceline rl where rem_remittanceline_id = @Line@

2. Register Sales Order for any org and BP. Set Invoice terms= immediate. Add any line. Set qty=10 and process
3. Register Sales Invoice for same org and BP. Run "Create lines from" and select previous order. Edit line qty to 2 and process
4. Register Sales Invoice for same org and BP. Run "Create lines from" and select previous order and process (line qty should be 8)
5. Register Remittance header. Set Expected Date=01-06-2018, run "Select orders or invoices" and select previous invoices. Process remittance using "grouping by business partner" option
6. Post remittance, go to "Detail" and verify that same description has been generated for all the lines: 2824FC712BD6469892128E16EC1633BA - 10 hola

This is not correct as each line should have specific line no

Moreover, you can select accounting details directly in database to verify that "Line_id" is wrong as same identifier has been set for all lines (select line_id from fact_acct where record_id='remittance_id')
Proposed SolutionProblem is in "loadLinesFieldProvider" method of DocREMRemittance file: "remmitanceLineID" is loaded for first line but as all remittance lines are related to same payment document, then rest of lines are skipped
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0101027)
collazoandy4 (reporter)
2017-12-13 22:54

Remittance configuration
  As System Admin Role
    Set Core Module as In Development: Y
    Go to Windows Tab and Fields window and select General Ledger Configuration record
      Set SQL Description field of Active Tables tab as Displayed: Y
  As F&B International Group Admin Role
    Go to General Ledger Configuration window and select F&B International Group US/A/US Dollar record
      Select the REM_Remittance record of Active Tables tab:
        SQL Description: select rl.rem_remittanceline_id || ' - ' || rl.line || ' hola ' from rem_remittanceline rl where rem_remittanceline_id = @Line@
    Applied the remittance dataset for * organization in Enterprise Module Management window
    Log out and Log in
    Go to Financial Account window and select Cuenta de Banco record:
      Create a new record in Payment Method tab:
        Payment Method: Remittance
        Upon Deposit Use: Cleared Payment Account
        Upon Reconciliation Use: Deposited Payment Account
        Upon Receipt Use: In Transit Payment Account
    Go to Remittance Type window and select Printable Remittance record:
      Create a new record in Accounting tab:
        General Ledger: F&B España, S.A. US/A/Euro
        Settlement Account / Sent Account: 52080
      Create a new record in Accounting tab:
        General Ledger: F&B International Group US/A/US Dollar
        Settlement Account / Sent Account: 1190
Test Plan I
    Go to Sales Order and create a new record for Alimentos y Supermercados, S.A bp
      Invoice Terms: Immediate
      Create a new record in Lines tab:
        Product: Zumo de Piña
        Ordered Quantity: 10
      Complete the order
    Create two Sales Invoice from the previous order created, one with invoiced qty of 2 and other with qty 8 and Complete it
    Go to Remittance window and create a new record:
      Name: TestPlanI
      Expected date: 01-06-2018
      Clic on Select Order or Invoices button:
        Show payments for alternative payment methods: Y
        Select the two record asociated to the previous order created
        Clic on Process button
        Check new Lines was added
      Clic on Process button and select Grouping by Business Partner
      Post the remittance document
      In the Journal Entries of F&B International Group US/A/US Dollar clic on Details link and check that the two remittance lines ids appears as entry description
Test Plan II
    Create to Sales Invoice for Alimentos y Supermercados, S.A bp and complete it
    Go to Remittance window and create a new record:
      Name: TestPlan2
      Expected date: Two months from now
      Clic on Select Order or Invoices button:
        Show payments for alternative payment methods: Y
        Select the two record asociated to the previous invoices created
        Clic on Process button
        Check new Lines was added
      Clic on Process button and no grouping option
      Post the remittance document
      In the Journal Entries of F&B International Group US/A/US Dollar clic on Details link and check that the two remittance lines ids appears as entry description
(0101116)
dmiguelez (developer)
2017-12-19 09:09

Test Plan III
    Go to Sales Order and create a new record for Alimentos y Supermercados, S.A bp
      Invoice Terms: Immediate
      Create a new record in Lines tab:
        Product: Zumo de Piña
        Ordered Quantity: 10
      Complete the order
    Go to Payment In Window and create a partial Payment of 10 with the Payment Method Remittance related to the previously created Sales Order.
    Complete it.
    Create two Sales Invoice from the previous order created, one with invoiced qty of 2 and other with qty 8 and Complete it
    Go to Remittance window and create a new record:
      Name: TestPlanI
      Expected date: 01-06-2018
      Clic on Select Order or Invoices button:
        Show payments for alternative payment methods: Y
        Select the two record asociated to the previous order created
        Clic on Process button
        Check new Lines was added
      Clic on Select Payments button:
        Select the previously created Payment and click on Process button. Check new Line has been added
      Clic on Process button and select Grouping by Business Partner
      Post the remittance document
      In the Journal Entries of F&B International Group US/A/US Dollar clicK on Details link and check that the two remittance lines ids appears as entry description
(0101117)
hgbot (developer)
2017-12-19 09:14

Repository: erp/mods/org.openbravo.module.remittance
Changeset: 7b170efb992b4eae405fc92eb75b5aa9354174e2
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Dec 14 17:01:46 2017 -0500
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/7b170efb992b4eae405fc92eb75b5aa9354174e2 [^]

Fixes issue 37430: Wrong "line_id" generated in Remittance posting when several
remittance lines are related with same payment

When several remittance lines are related to the same payment the process only
take into account the first one, the pending lines are skipped from the process
causing in the FieldProviderFactory created the remittance line id is the
processed record

To avoid that when a new FieldProviderFactory is created the remitance line id is
the remitance line asociated to the payment detail that been processing.

---
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
---
(0101118)
hgbot (developer)
2017-12-19 09:14

Repository: erp/mods/org.openbravo.module.remittance
Changeset: d87b3b9d05e12d383f165dc61589e02e86b03618
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Dec 19 09:12:31 2017 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/d87b3b9d05e12d383f165dc61589e02e86b03618 [^]

Related to Issue 37430: Code Review changes

* Moved Logic to a private method
* Added comment to explain change
* Changed variable name to compile with Java rules
* Changed StringBuffer with StringBuilder

---
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
---
(0101119)
hgbot (developer)
2017-12-19 09:14

Repository: erp/mods/org.openbravo.module.remittance
Changeset: 635d8255de1ecb9e3e808c555ac220be0caf0211
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Dec 14 17:02:13 2017 -0500
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/635d8255de1ecb9e3e808c555ac220be0caf0211 [^]

Related to issue 37430: Update Module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0101120)
dmiguelez (developer)
2017-12-19 09:19

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2017-12-01 10:49 maite New Issue
2017-12-01 10:49 maite Assigned To => Triage Finance
2017-12-01 10:49 maite Resolution time => 1513897200
2017-12-01 14:00 dmiguelez Assigned To Triage Finance => nonofrancisco
2017-12-01 16:02 nonofrancisco Status new => scheduled
2017-12-12 16:53 vmromanos Assigned To nonofrancisco => collazoandy4
2017-12-13 22:54 collazoandy4 Note Added: 0101027
2017-12-19 09:09 dmiguelez Note Added: 0101116
2017-12-19 09:14 hgbot Checkin
2017-12-19 09:14 hgbot Note Added: 0101117
2017-12-19 09:14 hgbot Status scheduled => resolved
2017-12-19 09:14 hgbot Resolution open => fixed
2017-12-19 09:14 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/7b170efb992b4eae405fc92eb75b5aa9354174e2 [^]
2017-12-19 09:14 hgbot Checkin
2017-12-19 09:14 hgbot Note Added: 0101118
2017-12-19 09:14 hgbot Checkin
2017-12-19 09:14 hgbot Note Added: 0101119
2017-12-19 09:19 dmiguelez Review Assigned To => dmiguelez
2017-12-19 09:19 dmiguelez Note Added: 0101120
2017-12-19 09:19 dmiguelez Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker