Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037411 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | trivial | have not tried | 2017-11-28 16:34 | 2018-01-03 12:39 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 94f270f9358c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | caristu | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037411: TreeTablesEventHandler.getDataSource does useless ad_table read | |||||||
| Description | private DataSourceService getDataSource(String tableId) { Table table = OBDal.getInstance().get(Table.class, tableId); OBCriteria<TableTree> obq = OBDal.getInstance().createCriteria(TableTree.class); obq.add(Restrictions.eq(TableTree.PROPERTY_TABLE, table)); That code is uselessly reading from ad_table and should use a getProxy instead. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0100810) hgbot (developer) 2017-11-29 12:16 |
Repository: erp/devel/pi Changeset: 94f270f9358c66b98a1b103ba4789d1212d4a6d5 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Wed Nov 29 12:15:58 2017 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/94f270f9358c66b98a1b103ba4789d1212d4a6d5 [^] fixed bug 37411: useless ad_table query in TreeTablesEventHandler.getDataSource Use proxy as table value is never used. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/TreeTablesEventHandler.java --- |
|
(0101051) caristu (viewer) 2017-12-15 09:11 |
Code reviewed + tested OK. |
|
(0101496) hudsonbot (viewer) 2018-01-03 12:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-11-28 16:34 | shuehner | New Issue | |
| 2017-11-28 16:34 | shuehner | Assigned To | => platform |
| 2017-11-28 16:34 | shuehner | OBNetwork customer | => No |
| 2017-11-28 16:34 | shuehner | Modules | => Core |
| 2017-11-28 16:34 | shuehner | Triggers an Emergency Pack | => No |
| 2017-11-28 16:34 | shuehner | Tag Attached: Performance | |
| 2017-11-29 12:16 | alostale | Assigned To | platform => alostale |
| 2017-11-29 12:16 | hgbot | Checkin | |
| 2017-11-29 12:16 | hgbot | Note Added: 0100810 | |
| 2017-11-29 12:16 | hgbot | Status | new => resolved |
| 2017-11-29 12:16 | hgbot | Resolution | open => fixed |
| 2017-11-29 12:16 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/94f270f9358c66b98a1b103ba4789d1212d4a6d5 [^] |
| 2017-11-29 12:16 | alostale | Review Assigned To | => caristu |
| 2017-12-15 09:11 | caristu | Note Added: 0101051 | |
| 2017-12-15 09:11 | caristu | Status | resolved => closed |
| 2017-12-15 09:11 | caristu | Fixed in Version | => 3.0PR18Q1 |
| 2018-01-03 12:39 | hudsonbot | Checkin | |
| 2018-01-03 12:39 | hudsonbot | Note Added: 0101496 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |