Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0037398 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | minor | always | 2017-11-27 17:21 | 2018-02-22 18:18 | |||
Reporter | JONHM | View Status | public | |||||
Assigned To | jarmendariz | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 21802fa9bc60 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | caristu | |||||||
OBNetwork customer | OBPS | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | 49621 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0037398: No warning message shown in 'Update Characteristics' process when 'TreeDatasourceFetchLimit' preference is not defined | |||||||
Description | No warning message shown in 'Update Characteristics' process when 'TreeDatasourceFetchLimit' preference is not defined. | |||||||
Steps To Reproduce | As System Administrator: 1) Open 'Preference' window and select TreeDatasourceFetchLimit Attribute. Set it as not active. Log out and log in the application. As F&B Admin: 2) Open 'Product Characteristics' window and create a new record name: 'Colour' variant: NO 3) Switch to [Value] tab and create new records 4) Open 'Product' window and select 'Cerveza Ale'. Switch to [Characteristics] tab and create a new one (Colour). 5) Run 'Update Characteristics' process and filter by Colour. It shows message 'No items to show' and the following error on the log: 2017-11-27 17:07:28,943 [ajp-bio-127.0.0.1-8009-exec-138] ERROR org.openbravo.service.json.DefaultJsonDataService - For input string: "null" java.lang.NumberFormatException: For input string: "null" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) at java.lang.Integer.parseInt(Integer.java:492) at java.lang.Integer.parseInt(Integer.java:527) at org.openbravo.service.json.DefaultJsonDataService.createSetQueryService(DefaultJsonDataService.java:648) at org.openbravo.service.json.DefaultJsonDataService.createSetQueryService(DefaultJsonDataService.java:439) at org.openbravo.service.json.DefaultJsonDataService.fetch(DefaultJsonDataService.java:182) at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:85) at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:78) at org.openbravo.service.datasource.TreeDatasourceService.getFilteredNodes(TreeDatasourceService.java:503) at org.openbravo.service.datasource.TreeDatasourceService.fetch(TreeDatasourceService.java:278) at org.openbravo.service.datasource.DataSourceServlet.doFetch(DataSourceServlet.java:284) at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:840) at javax.servlet.http.HttpServlet.service(HttpServlet.java:646) at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228) at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:462) at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87) at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:58) at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:153) at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62) at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46) at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81) at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46) at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:501) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408) at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:193) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:607) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:313) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) | |||||||
Proposed Solution | the endRowStr variable on DefaultJsonDataService class is evaluated as the string 'null' instead of NULL: https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java#l647 [^] Also, a message should be displayed regarding TreeDatasourceFetchLimit disabled or deleted preference. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
||||||||
|
![]() |
|
(0100748) caristu (viewer) 2017-11-27 19:42 |
The request should not fail, if the TreeDatasourceFetchLimit is not defined then the "endRow" should take a default value. |
(0101806) hgbot (developer) 2018-01-19 15:20 |
Repository: erp/devel/pi Changeset: 21802fa9bc60bdc0cbfac3d86287431b7cb706bc Author: Javier Armendáriz <javier.armendariz <at> openbravo.com> Date: Wed Jan 17 10:06:12 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/21802fa9bc60bdc0cbfac3d86287431b7cb706bc [^] Fixed bug 37398: Use default value when TreeDatasourceFetchLimit is not defined --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl --- |
(0101807) caristu (viewer) 2018-01-19 15:21 |
Code reviewed + tested OK |
(0101873) jarmendariz (viewer) 2018-01-23 09:06 |
Edited the wiki to mention the new default value for TreeDatasourceFetchLimit: http://wiki.openbravo.com/wiki/How_to_Create_a_Custom_Tree#fetchNodeChildren [^] |
(0102669) hudsonbot (viewer) 2018-02-22 18:18 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^] Maturity status: Test |
![]() |
|||
Date Modified | Username | Field | Change |
2017-11-27 17:21 | JONHM | New Issue | |
2017-11-27 17:21 | JONHM | Assigned To | => platform |
2017-11-27 17:21 | JONHM | OBNetwork customer | => Yes |
2017-11-27 17:21 | JONHM | Modules | => Core |
2017-11-27 17:21 | JONHM | Support ticket | => 49621 |
2017-11-27 17:21 | JONHM | Triggers an Emergency Pack | => No |
2017-11-27 17:21 | JONHM | Relationship added | related to 0036778 |
2017-11-27 19:42 | caristu | Note Added: 0100748 | |
2017-11-27 19:42 | caristu | Status | new => acknowledged |
2017-12-13 19:28 | caristu | Assigned To | platform => jarmendariz |
2018-01-11 09:45 | jarmendariz | Status | acknowledged => scheduled |
2018-01-19 14:42 | jarmendariz | File Added: bug-37398.patch | |
2018-01-19 14:42 | jarmendariz | Review Assigned To | => caristu |
2018-01-19 15:20 | hgbot | Checkin | |
2018-01-19 15:20 | hgbot | Note Added: 0101806 | |
2018-01-19 15:20 | hgbot | Status | scheduled => resolved |
2018-01-19 15:20 | hgbot | Resolution | open => fixed |
2018-01-19 15:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/21802fa9bc60bdc0cbfac3d86287431b7cb706bc [^] |
2018-01-19 15:21 | caristu | Note Added: 0101807 | |
2018-01-19 15:21 | caristu | Status | resolved => closed |
2018-01-19 15:21 | caristu | Fixed in Version | => 3.0PR18Q1 |
2018-01-22 11:18 | caristu | Fixed in Version | 3.0PR18Q1 => 3.0PR18Q2 |
2018-01-23 09:06 | jarmendariz | Note Added: 0101873 | |
2018-02-22 18:18 | hudsonbot | Checkin | |
2018-02-22 18:18 | hudsonbot | Note Added: 0102669 |
Copyright © 2000 - 2009 MantisBT Group |