Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2017-11-27 17:212018-02-22 18:18
ReporterJONHMView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision21802fa9bc60
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0037398: No warning message shown in 'Update Characteristics' process when 'TreeDatasourceFetchLimit' preference is not defined

DescriptionNo warning message shown in 'Update Characteristics' process when 'TreeDatasourceFetchLimit' preference is not defined.
Steps To ReproduceAs System Administrator:

1) Open 'Preference' window and select TreeDatasourceFetchLimit Attribute. Set it as not active.

Log out and log in the application. As F&B Admin:

2) Open 'Product Characteristics' window and create a new record
  name: 'Colour'
  variant: NO

3) Switch to [Value] tab and create new records

4) Open 'Product' window and select 'Cerveza Ale'. Switch to [Characteristics] tab and create a new one (Colour).

5) Run 'Update Characteristics' process and filter by Colour. It shows message 'No items to show' and the following error on the log:

2017-11-27 17:07:28,943 [ajp-bio-] ERROR org.openbravo.service.json.DefaultJsonDataService - For input string: "null"
java.lang.NumberFormatException: For input string: "null"
    at java.lang.NumberFormatException.forInputString(
    at java.lang.Integer.parseInt(
    at java.lang.Integer.parseInt(
    at org.openbravo.service.json.DefaultJsonDataService.createSetQueryService(
    at org.openbravo.service.json.DefaultJsonDataService.createSetQueryService(
    at org.openbravo.service.json.DefaultJsonDataService.fetch(
    at org.openbravo.service.datasource.DefaultDataSourceService.fetch(
    at org.openbravo.service.datasource.DefaultDataSourceService.fetch(
    at org.openbravo.service.datasource.TreeDatasourceService.getFilteredNodes(
    at org.openbravo.service.datasource.TreeDatasourceService.fetch(
    at org.openbravo.service.datasource.DataSourceServlet.doFetch(
    at org.openbravo.service.datasource.DataSourceServlet.doPost(
    at javax.servlet.http.HttpServlet.service(
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(
    at org.openbravo.client.kernel.BaseKernelServlet.service(
    at org.openbravo.service.datasource.DataSourceServlet.service(
    at javax.servlet.http.HttpServlet.service(
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(
    at org.openbravo.utils.SessionExpirationFilter.doFilter(
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(
    at org.openbravo.utils.CharsetFilter.doFilter(
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(
    at org.openbravo.client.kernel.KernelFilter$1.doAction(
    at org.openbravo.client.kernel.KernelFilter.doFilter(
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(
    at org.openbravo.dal.core.DalRequestFilter.doFilter(
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(
    at org.apache.catalina.core.StandardWrapperValve.invoke(
    at org.apache.catalina.core.StandardContextValve.invoke(
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(
    at org.apache.catalina.core.StandardHostValve.invoke(
    at org.apache.catalina.valves.ErrorReportValve.invoke(
    at org.apache.catalina.core.StandardEngineValve.invoke(
    at org.apache.catalina.connector.CoyoteAdapter.service(
    at org.apache.coyote.ajp.AjpProcessor.process(
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(
    at java.util.concurrent.ThreadPoolExecutor.runWorker(
    at java.util.concurrent.ThreadPoolExecutor$
Proposed Solutionthe endRowStr variable on DefaultJsonDataService class is evaluated as the string 'null' instead of NULL: [^]

Also, a message should be displayed regarding TreeDatasourceFetchLimit disabled or deleted preference.
TagsNo tags attached.
Attached Filespatch file icon bug-37398.patch [^] (3,093 bytes) 2018-01-19 14:42 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0036778 closedcaristu Wrong message shown in 'Update Characteristics' process when it has +200 lines 

-  Notes
caristu (developer)
2017-11-27 19:42

The request should not fail, if the TreeDatasourceFetchLimit is not defined then the "endRow" should take a default value.
hgbot (developer)
2018-01-19 15:20

Repository: erp/devel/pi
Changeset: 21802fa9bc60bdc0cbfac3d86287431b7cb706bc
Author: Javier Armendáriz <javier.armendariz <at>>
Date: Wed Jan 17 10:06:12 2018 +0100
URL: [^]

Fixed bug 37398: Use default value when TreeDatasourceFetchLimit is not defined

M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
caristu (developer)
2018-01-19 15:21

Code reviewed + tested OK
jarmendariz (developer)
2018-01-23 09:06

Edited the wiki to mention the new default value for TreeDatasourceFetchLimit: [^]
hudsonbot (developer)
2018-02-22 18:18

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-11-27 17:21 JONHM New Issue
2017-11-27 17:21 JONHM Assigned To => platform
2017-11-27 17:21 JONHM Modules => Core
2017-11-27 17:21 JONHM Triggers an Emergency Pack => No
2017-11-27 17:21 JONHM Relationship added related to 0036778
2017-11-27 19:42 caristu Note Added: 0100748
2017-11-27 19:42 caristu Status new => acknowledged
2017-12-13 19:28 caristu Assigned To platform => jarmendariz
2018-01-11 09:45 jarmendariz Status acknowledged => scheduled
2018-01-19 14:42 jarmendariz File Added: bug-37398.patch
2018-01-19 14:42 jarmendariz Review Assigned To => caristu
2018-01-19 15:20 hgbot Checkin
2018-01-19 15:20 hgbot Note Added: 0101806
2018-01-19 15:20 hgbot Status scheduled => resolved
2018-01-19 15:20 hgbot Resolution open => fixed
2018-01-19 15:20 hgbot Fixed in SCM revision => [^]
2018-01-19 15:21 caristu Note Added: 0101807
2018-01-19 15:21 caristu Status resolved => closed
2018-01-19 15:21 caristu Fixed in Version => 3.0PR18Q1
2018-01-22 11:18 caristu Fixed in Version 3.0PR18Q1 => 3.0PR18Q2
2018-01-23 09:06 jarmendariz Note Added: 0101873
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102669

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker