Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037278
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2017-11-13 10:582018-01-03 12:39
ReportermalsasuaView Statuspublic 
Assigned Toinigosanchez 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q1
StatusclosedFix in branchFixed in SCM revision50ec19da3e97
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2017-04-06
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c4a5973bba10 [^]
Triggers an Emergency PackNo
Summary

0037278: Deactivated roles are displayed in the role dropdown of user section

DescriptionThe deactivated roles are displayed in the dropdown of roles availables to the user.
Steps To Reproduce1. Login as "F&B International Group Admin" role with "Openbravo" user.
2. Go to [User] window and select Openbravo user.
3. Go to [User Roles] subtab and deactivated a role.(e.g. "F&B US, Inc. - Employee").
4. Do logout and login with previous user.
5. Open [User profile widget] and open the role dropdown.
  --> Check than deactivated rol is shown.
TagsNo tags attached.
Attached Filespng file icon errorRol.png [^] (155,616 bytes) 2017-11-13 12:57


png file icon errorRol2.png [^] (190,564 bytes) 2017-11-13 12:57

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00372813.0PR17Q4 closedinigosanchez Deactivated roles are displayed in the role dropdown of user section 
depends on backport 00372823.0PR17Q3.2 closedinigosanchez Deactivated roles are displayed in the role dropdown of user section 
caused by feature request 0035553 closedcaristu Improve scalability of the login process 
related to defect 0037289 closedinigosanchez It is not possible to do login using a role if the role has got a deactivated organization 

-  Notes
(0100479)
caristu (developer)
2017-11-13 12:59
edited on: 2017-11-13 13:01

 The problem is caused by this changeset: https://code.openbravo.com/erp/devel/pi/diff/c4a5973bba10/modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoComponent.java [^]

When improving the performance of the query, the OBQuery instance used to generate it was replaced with a Query instance. The first includes by default the filter by is active. To fix the problem this filter must be added manually.
(0100518)
hgbot (developer)
2017-11-14 14:13

 Repository: erp/devel/pi
Changeset: e93ad7f316fcbb91f7a65428f8102544132dff09
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 14 14:13:19 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e93ad7f316fcbb91f7a65428f8102544132dff09 [^]

Related with issue 37278: Added test case

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
A src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
---
(0100519)
hgbot (developer)
2017-11-14 14:16

 Repository: erp/devel/pi
Changeset: 50ec19da3e97d69075825368d2b4add0f95eacc1
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 14 14:15:07 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/50ec19da3e97d69075825368d2b4add0f95eacc1 [^]

Fixed issue 37278: Deactivated roles are displayed in the user profile widget

The problem was caused by the "Improve scalability of the login process" project. When improving the performance
of the query that return the complete role list for the current user, the OBQuery instance used to generate it was
replaced with a Query instance. The first includes by default the filter by is active.

To fix the problem this filter must be added manually in the query. Now the problem has been resolved by take into
account this filter.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoComponent.java
---
(0100521)
caristu (developer)
2017-11-14 17:09

 Some code review improvements for the new test case: https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0100524)
hgbot (developer)
2017-11-14 18:44

 Repository: erp/devel/pi
Changeset: 7660b737bf80dd735a9e7765e4c541e97b00bacd
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 14 18:43:12 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7660b737bf80dd735a9e7765e4c541e97b00bacd [^]

Related with issue 37278: Code review improvements for the test case

---
M src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
---
(0100528)
hgbot (developer)
2017-11-15 14:19

 Repository: erp/devel/pi
Changeset: f8d496311f36bda45a1d46d08b680ee6cda23e0b
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Nov 15 14:15:27 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f8d496311f36bda45a1d46d08b680ee6cda23e0b [^]

Related with issue 37278: Test is defined in the wrong suite

Moved test case to the AllWebserviceTests suite.

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src-test/src/org/openbravo/test/AllWebserviceTests.java
---
(0100529)
hgbot (developer)
2017-11-15 14:19

 Repository: erp/devel/pi
Changeset: 69bfa2a635a4fae471eaf849698020971c2284c4
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Nov 15 14:18:09 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/69bfa2a635a4fae471eaf849698020971c2284c4 [^]

Related with issue 37278: Improve log errors in the testcase

---
M src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
---
(0100542)
hgbot (developer)
2017-11-16 09:53

 Repository: erp/devel/pi
Changeset: 73796483a567e952d4d4b22e7463c212d338df88
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Nov 16 09:53:06 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/73796483a567e952d4d4b22e7463c212d338df88 [^]

Related with issue 37278: improvement in the message of the assertion

---
M src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
---
(0100545)
caristu (developer)
2017-11-16 10:37

 Code reviewed + tested OK.
(0101418)
hudsonbot (developer)
2018-01-03 12:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101419)
hudsonbot (developer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101421)
hudsonbot (developer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101422)
hudsonbot (developer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101423)
hudsonbot (developer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101425)
hudsonbot (developer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-11-13 10:58 malsasua New Issue
2017-11-13 10:58 malsasua Assigned To => platform
2017-11-13 10:58 malsasua Modules => Core
2017-11-13 10:58 malsasua Triggers an Emergency Pack => No
2017-11-13 12:24 inigosanchez Status new => scheduled
2017-11-13 12:24 inigosanchez Assigned To platform => inigosanchez
2017-11-13 12:57 malsasua File Added: errorRol.png
2017-11-13 12:57 malsasua File Added: errorRol2.png
2017-11-13 12:58 inigosanchez Steps to Reproduce Updated View Revisions
2017-11-13 12:59 caristu Note Added: 0100479
2017-11-13 13:01 caristu Note Edited: 0100479 View Revisions
2017-11-13 13:04 caristu Regression level => Production - QA Approved
2017-11-13 13:04 caristu Regression date => 2017-04-06
2017-11-13 13:04 caristu Regression introduced in release => 3.0PR17Q3
2017-11-13 13:04 caristu Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/c4a5973bba10 [^]
2017-11-13 13:07 caristu Relationship added caused by 0035553
2017-11-13 13:29 inigosanchez Status scheduled => acknowledged
2017-11-13 13:29 inigosanchez Status acknowledged => scheduled
2017-11-13 15:15 inigosanchez Review Assigned To => caristu
2017-11-14 14:13 hgbot Checkin
2017-11-14 14:13 hgbot Note Added: 0100518
2017-11-14 14:16 hgbot Checkin
2017-11-14 14:16 hgbot Note Added: 0100519
2017-11-14 14:16 hgbot Status scheduled => resolved
2017-11-14 14:16 hgbot Resolution open => fixed
2017-11-14 14:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/50ec19da3e97d69075825368d2b4add0f95eacc1 [^]
2017-11-14 17:09 caristu Note Added: 0100521
2017-11-14 17:30 caristu Relationship added related to 0037289
2017-11-14 18:44 hgbot Checkin
2017-11-14 18:44 hgbot Note Added: 0100524
2017-11-15 14:19 hgbot Checkin
2017-11-15 14:19 hgbot Note Added: 0100528
2017-11-15 14:19 hgbot Checkin
2017-11-15 14:19 hgbot Note Added: 0100529
2017-11-16 09:53 hgbot Checkin
2017-11-16 09:53 hgbot Note Added: 0100542
2017-11-16 10:37 caristu Note Added: 0100545
2017-11-16 10:37 caristu Status resolved => closed
2017-11-16 10:37 caristu Fixed in Version => 3.0PR18Q1
2018-01-03 12:38 hudsonbot Checkin
2018-01-03 12:38 hudsonbot Note Added: 0101418
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101419
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101421
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101422
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101423
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101425

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker