0037074: [RR17Q4] Layaway can't be retrieved after laid away twice

Description

A Layaway ticket can't be opened after being laid away twice. This is, by creating a Receipt, making it Layaway
and laying it away, opening it from the dropdown menu option, laying it away again, and then trying to reopen
it. An error is shown saying that the layaway hasn't been completely synced in the backoffice, as depicted in
the attached picture.

The error collected in the "Errors While Importing POS Data" record in the backoffice are as follows:

--- JSON order Data:
{"hasbeenpaid":"Y","isbeingprocessed":"N","id":"72C6F06590A84578AACDFB1CD165EA5B","client":"39363B0921BB4293B48383844325E84C","organization":"3B187EC130A549A7A9388F8060EF156D","createdBy":"1D0E5A14E65D474FA8EC8311E009E253","updatedBy":null,"documentType":"044E078A49CB4B1192B849462ACB4624","orderType":0,"generateInvoice":false,"isQuotation":false,"oldId":null,"priceList":"496CF965DF9744D2A41248392D1DE407","priceIncludesTax":true,"currency":"102","currency$_identifier":"EUR","session":"B35F1E86AE4CCFC464EED494A7C0B770","warehouse":"5A61F38D57F147A3A28E4C606B66DC47","salesRepresentative":"1D0E5A14E65D474FA8EC8311E009E253","salesRepresentative$_identifier":"Central Mountains Store User","posTerminal":"5F413EBD3A6042C28708821D43C91D0B","posTerminal$_identifier":"CMS POS Terminal","orderDate":"2017-10-16T11:22:58.343Z","creationDate":"2017-10-16T11:22:51.348Z","documentnoPrefix":-1,"quotationnoPrefix":-1,"returnnoPrefix":-1,"documentnoSuffix":-1,"quotationnoSuffix":-1,"returnnoSuffix":-1,"documentNo":"CMS1\/0000013","bp":{"id":"9C211C965971481CA91FC948CBC83076","organization":"3B187EC130A549A7A9388F8060EF156D","searchKey":"CMS\/C0001","_identifier":"CMS Customer","name":"CMS Customer","firstName":"CMS Customer","lastName":null,"description":null,"taxID":null,"taxCategory":null,"paymentMethod":"45A202BF44884F05B8A1BF741E2063B6","paymentTerms":"D8955F8808A54C63BBF478A6843D834D","priceList":"496CF965DF9744D2A41248392D1DE407","invoiceTerms":"I","contactId":"6F8FF918D75F4A9A81AFBD41FE4C8FE2","phone":null,"email":null,"businessPartnerCategory":"B1DD8B371643421C987EF1D5B358D5E9","businessPartnerCategory_name":"Customer","creditLimit":0,"creditUsed":0,"taxExempt":false,"customerBlocking":false,"salesOrderBlocking":true,"priceIncludesTax":true,"priceListName":"The White Valley Group Sale Price List","loaded":"2017-10-16T11:22:21+00:00","birthDay":null,"birthPlace":null,"_filter":"CMS\/C0001###CMS Customer###","_idx":2,"shipLocName":"Alcala 123 2-1","shipLocId":"A25BDF8D987C4280858F71409DC09AA8","shipPostalCode":"38010","shipCityName":"Santa Cruz de Tenerife","shipCountryName":"Spain","shipCountryId":"106","shipRegionId":"6C67D807692046F6A2F59CA37131F1B5","locName":"Alcala 123 2-1","locId":"A25BDF8D987C4280858F71409DC09AA8","postalCode":"38010","cityName":"Santa Cruz de Tenerife","countryName":"Spain","locationModel":{"id":"A25BDF8D987C4280858F71409DC09AA8","bpartner":"9C211C965971481CA91FC948CBC83076","name":"Alcala 123 2-1","postalCode":"38010","cityName":"Santa Cruz de Tenerife","countryName":"Spain","countryId":"106","regionName":"SANTA CRUZ DE TENERIFE ","regionId":"6C67D807692046F6A2F59CA37131F1B5","isBillTo":true,"isShipTo":true,"_identifier":"Alcala 123 2-1","loaded":"2017-10-16T11:22:22+00:00","_filter":"Alcala 123 2-1###","_idx":0}},"lines":[{"product":{"originalStandardPrice":18.9,"id":"9F9BC6229E5C48D38F935D7FD5F5BA94","searchkey":"WVG\/L0001","uPCEAN":null,"uOM":"100","uOMsymbol":"Ud ","uOMstandardPrecision":0,"productCategory":"9BE78BE519494875B84A004EFD4B5ADC","taxCategory":"FF80818123B7FC160123B804AB88000B","imgId":"3D3D41EDE96D4BDEB89E0484BA77526F","description":"Ultralight LED headlamp.","obposScale":false,"groupProduct":true,"stocked":true,"showstock":false,"isGeneric":false,"generic_product_id":null,"brand":"121308E73E684428BF4E65B40629F0EF","characteristicDescription":"Object: Headlamps, Price: < 20€, Range: 29m max, Weight: Under 1Kg, Battery Life: 120h max, Use: Hiking & Trekking","showchdesc":true,"bestseller":true,"ispack":false,"listPrice":18.9,"standardPrice":18.9,"priceLimit":18.9,"cost":0,"algorithm":"S","_identifier":"Headlamp ultralight","currentStandardPrice":"undefined","productType":"I","includeProductCategories":null,"includeProducts":null,"printDescription":false,"oBPOSAllowAnonymousSale":true,"returnable":true,"overdueReturnDays":null,"isPriceRuleBased":false,"proposalType":null,"availableForMultiline":false,"isLinkedToProduct":false,"allowDeferredSell":false,"deferredSellMaxDays":null,"quantityRule":null,"isPrintServices":true,"hasAttributes":false,"isSerialNo":false,"_idx":75},"productidentifier":null,"uOM":"100","qty":1,"price":18.9,"priceList":18.9,"gross":18.9,"net":18.9,"description":"","id":"7CB72D3F2A6C50EFD4B24AC6C64ADBED","promotions":[],"priceIncludesTax":true,"hasRelatedServices":false,"warehouse":{"id":"5A61F38D57F147A3A28E4C606B66DC47","warehousename":"Central Mountains Store Warehouse"},"isEditable":true,"isDeletable":true,"grossListPrice":18.9,"productType":"I","discountPercentage":0,"pricePrecision":2,"remainingQuantity":0,"orderId":"72C6F06590A84578AACDFB1CD165EA5B","grossUnitPrice":18.9,"overdueReturnDays":999999999999,"deliveredQuantity":0,"returnable":true,"taxes":[{"taxId":"6A87420C02554D82B83595A74B73B4CB","identifier":"Entregas a Canarias,Ceuta y Melilla (%N=>0%)","taxAmount":0,"taxableAmount":18.9,"taxRate":0,"docTaxAmount":"D","lineNo":10,"cascade":false}],"linepos":0,"taxLines":{"6A87420C02554D82B83595A74B73B4CB":{"amount":0,"name":"Entregas a Canarias,Ceuta y Melilla (%N=>0%)","net":18.9,"rate":0}},"tax":"6A87420C02554D82B83595A74B73B4CB","taxAmount":0,"pricenet":18.9,"discountedNet":18.9,"linerate":1,"listPrice":0,"standardPrice":0,"lineGrossAmount":18.9}],"payments":[],"payment":0,"change":0,"qty":1,"gross":18.9,"net":18.9,"taxes":{"6A87420C02554D82B83595A74B73B4CB":{"amount":0,"cascade":false,"docTaxAmount":"D","lineNo":10,"name":"Entregas a Canarias,Ceuta y Melilla (%N=>0%)","net":18.9,"rate":0}},"description":"","print":true,"sendEmail":false,"isPaid":false,"creditAmount":0,"paidPartiallyOnCredit":false,"paidOnCredit":false,"isLayaway":true,"isEditable":false,"openDrawer":false,"totalamount":18.9,"approvals":[],"isPartiallyDelivered":false,"isNewReceipt":false,"cloningReceipt":false,"bpBillLocId":"A25BDF8D987C4280858F71409DC09AA8","iscancelled":false,"totalNetAmount":18.9,"bpLocId":"A25BDF8D987C4280858F71409DC09AA8","businessPartner$_identifier":"CMS Customer","orderid":"72C6F06590A84578AACDFB1CD165EA5B","loaded":"2017-10-16T11:22:56.643Z","receiptLines":[{"linegrossamount":18.9,"unitPrice":18.9,"warehouse":"5A61F38D57F147A3A28E4C606B66DC47","productType":"I","id":"9F9BC6229E5C48D38F935D7FD5F5BA94","description":"","name":"Headlamp ultralight","discountPercentage":0,"pricePrecision":2,"remainingQuantity":0,"quantity":1,"uOM":"100","orderId":"72C6F06590A84578AACDFB1CD165EA5B","lineId":"7CB72D3F2A6C50EFD4B24AC6C64ADBED","warehousename":"Central Mountains Store Warehouse","grossUnitPrice":18.9,"overdueReturnDays":999999999999,"baseNetUnitPrice":0,"deliveredQuantity":0,"returnable":true,"priceIncludesTax":true,"shipmentlines":[],"taxes":[{"taxId":"6A87420C02554D82B83595A74B73B4CB","identifier":"Entregas a Canarias,Ceuta y Melilla (%N=>0%)","taxAmount":0,"taxableAmount":18.9,"taxRate":0,"docTaxAmount":"D","lineNo":10,"cascade":false}],"promotions":[],"linepos":0}],"receiptPayments":[],"receiptTaxes":[{"taxid":"6A87420C02554D82B83595A74B73B4CB","rate":0,"net":18.9,"amount":0,"name":"Entregas a Canarias,Ceuta y Melilla (%N=>0%)","gross":18.9,"cascade":false,"docTaxAmount":"D","lineNo":10}],"approvedList":[],"recordInImportEntry":false,"skipApplyPromotions":true,"calculateReceiptCallbacks":[],"isBeingDiscounted":false,"reApplyDiscounts":false,"timezoneOffset":-120,"selectedPayment":"OBPOS_payment.cash","isBeingClosed":false,"created":1508152971348,"obposCreatedabsolute":"2017-10-16 13:22:51.348","movementDate":"2017-10-16T11:22:58.344Z","accountingDate":"2017-10-16T11:22:58.345Z","multipleUndo":null,"paymentMethodKind":null,"obposAppCashup":"FF06117E02CC7BD349D60DC4B842EE98","cashUpReportInformation":{"id":"FF06117E02CC7BD349D60DC4B842EE98","netSales":363.5,"grossSales":363.5,"netReturns":0,"grossReturns":0,"totalRetailTransactions":363.5,"creationDate":"2017-10-16T11:14Z","userId":"1D0E5A14E65D474FA8EC8311E009E253","objToSend":"{\"posterminal\":\"5F413EBD3A6042C28708821D43C91D0B\",\"posTerminal\":\"5F413EBD3A6042C28708821D43C91D0B\",\"id\":\"FF06117E02CC7BD349D60DC4B842EE98\",\"isprocessed\":\"N\",\"isbeingprocessed\":\"Y\",\"netSales\":363.5,\"grossSales\":363.5,\"netReturns\":0,\"grossReturns\":0,\"totalRetailTransactions\":363.5,\"cashPaymentMethodInfo\":[{\"paymentMethodId\":\"43F694DEE8484EB1A809199B61F26CA8\",\"id\":\"1B104755C1039FA9A4C32AAA3D43ECC6\",\"searchKey\":\"OBPOS_payment.card\",\"startingCash\":0,\"totalSales\":0,\"totalReturns\":0,\"rate\":\"1\",\"isocode\":\"EUR\",\"totalDeposits\":0,\"totalDrops\":0,\"paymentmethod_id\":\"43F694DEE8484EB1A809199B61F26CA8\"},{\"paymentMethodId\":\"AA4E033486E842E8B67DED8549C47A47\",\"id\":\"45FCFE590D66DA512E636AB92185B120\",\"searchKey\":\"OBPOS_payment.cash\",\"startingCash\":0,\"totalSales\":325.7,\"totalReturns\":0,\"rate\":\"1\",\"isocode\":\"EUR\",\"totalDeposits\":0,\"totalDrops\":0,\"paymentmethod_id\":\"AA4E033486E842E8B67DED8549C47A47\"},{\"paymentMethodId\":\"5EDB23AEA96845309D8072DFE0740E32\",\"id\":\"8C4DE0D87FB47B65BAF3245023ED3F83\",\"searchKey\":\"OBPOS_payment.voucher\",\"startingCash\":0,\"totalSales\":0,\"totalReturns\":0,\"rate\":\"1\",\"isocode\":\"EUR\",\"totalDeposits\":0,\"totalDrops\":0,\"paymentmethod_id\":\"5EDB23AEA96845309D8072DFE0740E32\"}],\"cashTaxInfo\":[{\"name\":\"Entregas a Canarias,Ceuta y Melilla (%N=>0%)\",\"amount\":0,\"orderType\":\"0\",\"cashupId\":\"FF06117E02CC7BD349D60DC4B842EE98\",\"id\":\"0CC0BDCA1A0273A6494B3CA5B0E0D2D3\"}],\"cashCloseInfo\":[],\"cashUpDate\":\"\",\"creationDate\":\"2017-10-16T11:14:00.000Z\",\"lastcashupeportdate\":\"2017-10-16T11:22:58.512Z\",\"userId\":\"1D0E5A14E65D474FA8EC8311E009E253\",\"organization\":\"3B187EC130A549A7A9388F8060EF156D\"}","isbeingprocessed":"Y","isprocessed":"N","posterminal":"5F413EBD3A6042C28708821D43C91D0B","_idx":null,"lastcashupeportdate":"2017-10-16T11:22:58.512Z"}}

-----------------------------------------------------------------------

-- Error message:
org.postgresql.util.PSQLException: ERROR: null value in column "em_obawo_pending_qty_picking" violates not-null constraint
  Detail: Failing row contains (7CB72D3F2A6C50EFD4B24AC6C64ADBED, 39363B0921BB4293B48383844325E84C,
3B187EC130A549A7A9388F8060EF156D, Y, 2017-10-16 11:22:51, 1D0E5A14E65D474FA8EC8311E009E253, 2017-10-16
11:22:59.943, 1D0E5A14E65D474FA8EC8311E009E253, 72C6F06590A84578AACDFB1CD165EA5B, 10,
9C211C965971481CA91FC948CBC83076, null, 2017-10-16 00:00:00, null, null, null, ,
9F9BC6229E5C48D38F935D7FD5F5BA94, 5A61F38D57F147A3A28E4C606B66DC47, N, 100, 1, 0, 0, 0, null, 102, 0, 18.9, 0,
18.90, 0, 0, null, 0, 6A87420C02554D82B83595A74B73B4CB, null, null, null, N, null, null, null, 0, N, null, N,
null, null, null, 18.9, 18.9, 18.9, null, 18.9, null, null, null, null, null, null, null, null, N, N, N, null,
N, null, N, null, null, null, null, null, N, N, null, null).
    at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2182)
    at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1911)
    at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:338)
    at org.postgresql.jdbc.PgStatement.executeBatch(PgStatement.java:2534)
    at sun.reflect.GeneratedMethodAccessor634.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.apache.tomcat.jdbc.pool.StatementFacade$StatementProxy.invoke(StatementFacade.java:138)
    at com.sun.proxy.$Proxy24.executeBatch(Unknown Source)
    at org.hibernate.jdbc.BatchingBatcher.doExecuteBatch(BatchingBatcher.java:70)
    at org.hibernate.jdbc.AbstractBatcher.executeBatch(AbstractBatcher.java:268)
    at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:268)
    at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:185)
    at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:321)
    at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:51)
    at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1216)
    at org.openbravo.dal.service.OBDal.flush(OBDal.java:260)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:563)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:200)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:154)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:86)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:53)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:59)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:363)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:285)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:473)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
    at java.lang.Thread.run(Thread.java:748)

Steps To Reproduce

0. Log in the Web POS as user "vallblanca"
1. Create a receipt by adding products to the list
2. Open the dropdown menu and select the "Layaway this Receipt" option
3. Click on the Total button and click on the "Layaway" button that will show in the information pane on the right. A green "Layaway VBS1/00000xxx has been successfully created" message will show in the top right corner of the screen
4. Open the just created layaway by selecting "Layaways" in the dropdown menu and by searching and clicking on the list shown in the popup
5. Repeat step 3
6. Repeat step 4. NOTICE that the error in the attached picture is shown.

Notes
(0099926) hgbot (developer) 2017-10-17 14:50	Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.retailconnector Changeset: e440b4b5e06c666b890746c0e74bd157793f9d05 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Oct 17 13:50:21 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.retailconnector/rev/e440b4b5e06c666b890746c0e74bd157793f9d05 [^] Fixed issue 37074: Hook implementation now will take into account standard order, create layaway, update layway and quotations --- M src/org/openbravo/warehouse/advancedwarehouseoperations/retailconnector/OrderLoaderHookImplementation.java ---

(0099927) guilleaer (manager) 2017-10-17 16:04	New module version created (1.0.2) and published in QA status http://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/ForgeModuleVersionDetail?moduleVersionId=8CFB9E744AE541C3826C65E134D423B9 [^]

(0099929) inaki_garcia (reporter) 2017-10-17 16:09	Tested in QA context and working correctly

Issue History
Date Modified	Username	Field	Change
2017-10-16 14:01	inaki_garcia	New Issue
2017-10-16 14:01	inaki_garcia	Assigned To	=> Retail
2017-10-16 14:01	inaki_garcia	File Added: error_opening_layaway.png
2017-10-16 14:01	inaki_garcia	Triggers an Emergency Pack	=> No
2017-10-16 14:04	inaki_garcia	Description Updated	View Revisions
2017-10-17 14:50	hgbot	Checkin
2017-10-17 14:50	hgbot	Note Added: 0099926
2017-10-17 14:50	hgbot	Status	new => resolved
2017-10-17 14:50	hgbot	Resolution	open => fixed
2017-10-17 14:50	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.retailconnector/rev/e440b4b5e06c666b890746c0e74bd157793f9d05 [^]
2017-10-17 16:04	guilleaer	Note Added: 0099927
2017-10-17 16:09	inaki_garcia	Note Added: 0099929
2017-10-19 12:38	marvintm	Assigned To	Retail => guilleaer
2017-10-26 13:35	marvintm	Review Assigned To	=> marvintm
2017-10-26 13:35	marvintm	Status	resolved => closed
2017-10-26 13:35	marvintm	Fixed in Version	=> RR17Q4

Relationships [ Relation Graph ] [ Dependency Graph ]