Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036937 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2017-09-25 10:54 | 2017-09-26 15:25 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 5778a1eb4671 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | AugustoMauch | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036937: update.database source data queries current time to DB for each change | |||||||
| Description | When updating database, each change in source data queries DB for current time stamp. | |||||||
| Steps To Reproduce | 0. Enable logging all DB statements 1. run update.database ensuring there are changes in source data -> check there are as many queries to "select now() from dual" as changes detected in source data | |||||||
| Proposed Solution | Assuming db and sources server are in the same time zone, it's not necessary to query data to DB, being possible to calculate it in JVM preventing in this way round trips to DB. | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0099525) hgbot (developer) 2017-09-25 11:23 |
Repository: erp/devel/dbsm-main Changeset: ecd35e9def0f0f83e1b53bfb1af3098034ba37c8 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Mon Sep 25 10:41:15 2017 +0200 URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/ecd35e9def0f0f83e1b53bfb1af3098034ba37c8 [^] fixed bug 36937: update.database source data queries time to DB for each change There is not need to query current time from DB. Now it is calculated in JVM instead. --- M src/org/apache/ddlutils/platform/PlatformImplBase.java --- |
|
(0099527) hgbot (developer) 2017-09-25 11:23 |
Repository: erp/devel/pi Changeset: 5778a1eb46718a99ff7479e483a108f24a529198 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Mon Sep 25 11:04:14 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/5778a1eb46718a99ff7479e483a108f24a529198 [^] fixed bug 36937, fixed bug 35653: dbsm fixing those 2 issues --- M src-db/database/lib/dbsourcemanager.jar --- |
|
(0099562) AugustoMauch (manager) 2017-09-25 15:20 |
Code reviewed and verified |
|
(0099588) hudsonbot (developer) 2017-09-26 15:25 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8fa643b4437e [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-09-25 10:54 | alostale | New Issue | |
| 2017-09-25 10:54 | alostale | Assigned To | => platform |
| 2017-09-25 10:54 | alostale | Modules | => Core |
| 2017-09-25 10:54 | alostale | Triggers an Emergency Pack | => No |
| 2017-09-25 10:54 | alostale | Assigned To | platform => alostale |
| 2017-09-25 10:55 | alostale | Review Assigned To | => AugustoMauch |
| 2017-09-25 10:55 | alostale | Relationship added | related to 0035653 |
| 2017-09-25 10:55 | alostale | Tag Attached: Performance | |
| 2017-09-25 11:23 | hgbot | Checkin | |
| 2017-09-25 11:23 | hgbot | Note Added: 0099525 | |
| 2017-09-25 11:23 | hgbot | Status | new => resolved |
| 2017-09-25 11:23 | hgbot | Resolution | open => fixed |
| 2017-09-25 11:23 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/dbsm-main/rev/ecd35e9def0f0f83e1b53bfb1af3098034ba37c8 [^] |
| 2017-09-25 11:23 | hgbot | Checkin | |
| 2017-09-25 11:23 | hgbot | Note Added: 0099527 | |
| 2017-09-25 11:23 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/dbsm-main/rev/ecd35e9def0f0f83e1b53bfb1af3098034ba37c8 [^] => http://code.openbravo.com/erp/devel/pi/rev/5778a1eb46718a99ff7479e483a108f24a529198 [^] |
| 2017-09-25 15:20 | AugustoMauch | Note Added: 0099562 | |
| 2017-09-25 15:20 | AugustoMauch | Status | resolved => closed |
| 2017-09-26 15:25 | hudsonbot | Checkin | |
| 2017-09-26 15:25 | hudsonbot | Note Added: 0099588 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |