Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0036879 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | minor | N/A | 2017-09-18 16:20 | 2017-09-21 16:50 | |||
Reporter | caristu | View Status | public | |||||
Assigned To | shuehner | |||||||
Priority | high | Resolution | fixed | Fixed in Version | 3.0PR17Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 86eeae546011 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | caristu | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0036879: Clean-up unused Sqlc parameters related with the Login page | |||||||
Description | In the code involved in the Login page there exists some Sqlc parameters defined in XML which do not have a matching entry in the corresponding HTML file. Therefore they are not being used and they can be cleaned-up. | |||||||
Steps To Reproduce | In decription | |||||||
Tags | No tags attached. | |||||||
Attached Files | login-cleanup.diff [^] (4,638 bytes) 2017-09-18 16:20 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||||||||||||||||
|
Notes | |
(0099120) caristu (developer) 2017-09-18 16:21 |
Attached a patch provided by Stefan |
(0099198) hgbot (developer) 2017-09-21 09:28 |
Repository: erp/devel/pi Changeset: 86eeae5460117058254e8419d9a4fcb2a8ef99c7 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Thu Sep 21 09:02:15 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/86eeae5460117058254e8419d9a4fcb2a8ef99c7 [^] fixes issue 36879: Clean-up unused Sqlc parameters related with the Login page --- M src/org/openbravo/erpCommon/security/Login.java M src/org/openbravo/erpCommon/security/Login.xml M src/org/openbravo/erpCommon/security/SessionLogin_data.xsql M src/org/openbravo/erpCommon/utility/VerticalMenu.java M src/org/openbravo/erpCommon/utility/VerticalMenu.xml --- |
(0099199) hgbot (developer) 2017-09-21 09:33 |
Repository: erp/devel/pi Changeset: 382af6a5db44fb399cf340dd8b9900a6bd87230a Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Thu Sep 21 09:13:51 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/382af6a5db44fb399cf340dd8b9900a6bd87230a [^] related to issue 36879: updated copyright year --- M src/org/openbravo/erpCommon/security/Login.xml M src/org/openbravo/erpCommon/utility/VerticalMenu.xml --- |
(0099200) caristu (developer) 2017-09-21 09:34 |
Code reviewed + tested OK. |
(0099431) hudsonbot (developer) 2017-09-21 16:50 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^] Maturity status: Test |
(0099432) hudsonbot (developer) 2017-09-21 16:50 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^] Maturity status: Test |
Issue History | |||
Date Modified | Username | Field | Change |
2017-09-18 16:20 | caristu | New Issue | |
2017-09-18 16:20 | caristu | Assigned To | => caristu |
2017-09-18 16:20 | caristu | Modules | => Core |
2017-09-18 16:20 | caristu | Triggers an Emergency Pack | => No |
2017-09-18 16:20 | caristu | File Added: login-cleanup.diff | |
2017-09-18 16:21 | caristu | Note Added: 0099120 | |
2017-09-18 16:21 | caristu | Relationship added | related to 0035763 |
2017-09-18 16:21 | caristu | Relationship added | related to 0035386 |
2017-09-18 16:22 | caristu | Relationship added | related to 0036353 |
2017-09-18 19:30 | shuehner | Issue Monitored: shuehner | |
2017-09-21 09:28 | hgbot | Checkin | |
2017-09-21 09:28 | hgbot | Note Added: 0099198 | |
2017-09-21 09:28 | hgbot | Status | new => resolved |
2017-09-21 09:28 | hgbot | Resolution | open => fixed |
2017-09-21 09:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/86eeae5460117058254e8419d9a4fcb2a8ef99c7 [^] |
2017-09-21 09:28 | caristu | Assigned To | caristu => shuehner |
2017-09-21 09:33 | hgbot | Checkin | |
2017-09-21 09:33 | hgbot | Note Added: 0099199 | |
2017-09-21 09:34 | caristu | Review Assigned To | => caristu |
2017-09-21 09:34 | caristu | Note Added: 0099200 | |
2017-09-21 09:34 | caristu | Status | resolved => closed |
2017-09-21 09:34 | caristu | Fixed in Version | => 3.0PR17Q4 |
2017-09-21 16:50 | hudsonbot | Checkin | |
2017-09-21 16:50 | hudsonbot | Note Added: 0099431 | |
2017-09-21 16:50 | hudsonbot | Checkin | |
2017-09-21 16:50 | hudsonbot | Note Added: 0099432 |
Copyright © 2000 - 2009 MantisBT Group |