Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036659 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 04. Warehouse management | major | always | 2017-08-17 13:17 | 2017-09-21 16:49 | |||
| Reporter | ngarcia | View Status | public | |||||
| Assigned To | markmm82 | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR17Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | eedde20727c8 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036659: [Costing Migration Process]: Closing inventories are not leaving stock valuation to 0 | |||||||
| Description | [Costing Migration Process]: Closing inventories are not leaving stock valuation to 0 In calculateCosts function of CostingMigrationProcess class, in order to adjust the cost of the last transaction, the movementqty is wrongly compared with the stock (movementqty will be negative when stock is positive): if (trx.getMovementQuantity().compareTo(totalStock) == 0) { // Last transaction adjusts remaining cost amount. trxCost = totalCost; } | |||||||
| Steps To Reproduce | * | |||||||
| Proposed Solution | Change in CostingMigrationProcess.java: if (trx.getMovementQuantity().compareTo(totalStock) == 0) { // Last transaction adjusts remaining cost amount. trxCost = totalCost; } with: if (trx.getMovementQuantity().negate().compareTo(totalStock) == 0) { // Last transaction adjusts remaining cost amount. trxCost = totalCost; } | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0098535) hgbot (developer) 2017-08-18 08:37 |
Repository: erp/devel/pi Changeset: eedde20727c8bf0ef1c4228dfc7fc29a1bbd89b3 Author: Mark <markmm82 <at> gmail.com> Date: Thu Aug 17 10:35:39 2017 -0400 URL: http://code.openbravo.com/erp/devel/pi/rev/eedde20727c8bf0ef1c4228dfc7fc29a1bbd89b3 [^] Fixes issue 36659: Closing inventories are not leaving stock valuation to 0 When Costing Migration Process is executed closing inventories are not leaving stock valuation to 0. In calculateCosts function of CostingMigrationProcess class, in order to adjust the cost of the last transaction, the movementqty was wrongly compared with the stock because it doesn't take into account that movementqty will be negative (as it belongs to closing inventory transactions) when stock is positive. To fix it, the movement quantity is negated when comparing with stock. --- M src/org/openbravo/costing/CostingMigrationProcess.java --- |
|
(0098536) aferraz (manager) 2017-08-18 08:48 |
Code review OK |
|
(0099312) hudsonbot (developer) 2017-09-21 16:49 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-08-17 13:17 | ngarcia | New Issue | |
| 2017-08-17 13:17 | ngarcia | Assigned To | => Triage Finance |
| 2017-08-17 13:17 | ngarcia | Modules | => Core |
| 2017-08-17 13:17 | ngarcia | Resolution time | => 1504735200 |
| 2017-08-17 13:17 | ngarcia | Triggers an Emergency Pack | => No |
| 2017-08-17 13:17 | ngarcia | Issue Monitored: networkb | |
| 2017-08-17 13:20 | ngarcia | Relationship added | related to 0036642 |
| 2017-08-17 13:27 | aferraz | Assigned To | Triage Finance => markmm82 |
| 2017-08-17 13:28 | aferraz | Proposed Solution updated | |
| 2017-08-17 13:34 | aferraz | Proposed Solution updated | |
| 2017-08-17 16:10 | markmm82 | Status | new => scheduled |
| 2017-08-18 08:37 | hgbot | Checkin | |
| 2017-08-18 08:37 | hgbot | Note Added: 0098535 | |
| 2017-08-18 08:37 | hgbot | Status | scheduled => resolved |
| 2017-08-18 08:37 | hgbot | Resolution | open => fixed |
| 2017-08-18 08:37 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/eedde20727c8bf0ef1c4228dfc7fc29a1bbd89b3 [^] |
| 2017-08-18 08:48 | aferraz | Review Assigned To | => aferraz |
| 2017-08-18 08:48 | aferraz | Note Added: 0098536 | |
| 2017-08-18 08:48 | aferraz | Status | resolved => closed |
| 2017-08-18 08:48 | aferraz | Fixed in Version | => 3.0PR17Q4 |
| 2017-08-21 11:40 | ngarcia | Relationship added | related to 0036675 |
| 2017-09-21 16:49 | hudsonbot | Checkin | |
| 2017-09-21 16:49 | hudsonbot | Note Added: 0099312 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |