Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036530
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-07-24 13:172018-01-22 20:57
ReporteregoitzView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revisionce6e61b2a8e7
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036530: When opening a old ticket it is loaded with new taxes instead of the original ones

DescriptionWhen opening an old ticket on the webpos it is loaded re calculating the taxes
so if the taxes have been changed the ticket opened is not correct.
If you print the ticket the printing is different than the original ticket
Steps To Reproduce-Create a ticket with some taxes
-Create new taxes on the backend applicable starting today
-Login again on the system.
-Load the previous ticket.
*See that the taxes used are the new ones.
Proposed SolutionThe taxes in the duplicate bills are being picked from c_tax instead of picking from c_orderline_tax.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039864 closedranjith_qualiantech_com Taxes are recalculated in Verified Returns receipts and it should not be done 
causes defect 0037550RR18Q1 closedranjith_qualiantech_com Taxes are not correctly shown when a receipt/quotation/layaway is loaded (Price not including taxes) 

-  Notes
(0098702)
hgbot (developer)
2017-08-29 14:04

 Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod
Changeset: f3ac89fd0d3f2fabfaa92f64a117f112e0770e55
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Aug 29 14:03:39 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/f3ac89fd0d3f2fabfaa92f64a117f112e0770e55 [^]

Related to issue 36530: When opening a old ticket it is loaded with new taxes
instead of the original ones

Even if it is a layaway, discounts by payment method should recalculate the taxes
if applied.

---
M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js
---
(0098716)
hgbot (developer)
2017-08-30 08:22

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ce6e61b2a8e743fcd5d0bbcf8e84984512b34672
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Aug 29 13:59:18 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ce6e61b2a8e743fcd5d0bbcf8e84984512b34672 [^]

Fixed issue 36530: When opening a old ticket it is loaded with new taxes
instead of the original ones

The solution is to not calculate Taxes when a order is loaded from the
backend.

To do so, we need to retrieve more information when the ticket is loaded
and then set it in the webPOS.

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0098789)
marvintm (manager)
2017-09-04 09:47

 Currently, there are two changes in the JS side: in calcTaxesIncPrice and in calcTaxesExcPrice. The code in both places is 99% equal, so it should be generalized to a common function.

Besides this, while we need to set the taxes once when the ticket is originally loaded, it's not necessary to do it after that point. Currently, we are executing this code every time calculateReceipt is called, and this has an unnecessary performance impact. Maybe it would be better to call it only when newPaidReceipts is originally called?
(0098946)
hgbot (developer)
2017-09-11 15:21

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1b6687ef4d4c44de4956c3086c653dd40e945c36
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 11 10:57:29 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1b6687ef4d4c44de4956c3086c653dd40e945c36 [^]

Related to issue 36530: When opening a old ticket it is loaded with new taxes
instead of the original ones

Replace code to avoid duplicated code in dataordertaxes file.

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0099068)
marvintm (manager)
2017-09-15 12:12

 Automatic tests will be added later. The flows that need to be tested are:

- Normal receipt (when loaded, taxes should not change)
- Return (when loaded, taxes should not change)
- Layaway (when loaded, taxes should not change)
- Quotation (when loaded, taxes should not change)
- Order from quotation (when order is created, taxes should be updated with the current ones)

All cases must be tested using pricelist including taxes, and not including taxes.
(0099996)
hgbot (developer)
2017-10-23 15:18

 Repository: tools/automation/pi-mobile
Changeset: 2a22c24addd9ce3b5e374aa82a9b18234bc7d706
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Oct 23 09:05:03 2017 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2a22c24addd9ce3b5e374aa82a9b18234bc7d706 [^]

Verifies issue 36530: Added automated test to verify that when opening a old
ticket, it is loaded with the taxes it was created and not any other tax that
could have been created after the ticket.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/taxes/I36530_VerifyOldTicketsShownWithProperTaxes.java
---
(0101870)
hgbot (developer)
2018-01-22 20:57

 Repository: tools/automation/pi-mobile
Changeset: d16ef51d5a9aa0cca18f3f0f599c101d12032db0
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Tue Jan 16 13:03:26 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d16ef51d5a9aa0cca18f3f0f599c101d12032db0 [^]

Test refactor for issue 36530: Changed delete receipt button reference

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/taxes/I36530_VerifyOldTicketsShownWithProperTaxes.java
---

- Issue History
Date Modified Username Field Change
2017-07-24 13:17 egoitz New Issue
2017-07-24 13:17 egoitz Assigned To => Retail
2017-07-24 13:17 egoitz Resolution time => 1502661600
2017-07-24 13:17 egoitz Triggers an Emergency Pack => No
2017-08-22 13:35 jorge-garcia Status new => scheduled
2017-08-22 13:35 jorge-garcia Assigned To Retail => jorge-garcia
2017-08-22 14:28 jorge-garcia Assigned To jorge-garcia => rqueralta
2017-08-23 10:50 jorge-garcia Assigned To rqueralta => jorge-garcia
2017-08-29 14:04 hgbot Checkin
2017-08-29 14:04 hgbot Note Added: 0098702
2017-08-30 08:22 hgbot Checkin
2017-08-30 08:22 hgbot Note Added: 0098716
2017-08-30 08:22 hgbot Status scheduled => resolved
2017-08-30 08:22 hgbot Resolution open => fixed
2017-08-30 08:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ce6e61b2a8e743fcd5d0bbcf8e84984512b34672 [^]
2017-09-01 14:56 marvintm Review Assigned To => mtaal
2017-09-04 09:47 marvintm Note Added: 0098789
2017-09-04 09:47 marvintm Status resolved => new
2017-09-04 09:47 marvintm Resolution fixed => open
2017-09-04 09:48 marvintm Review Assigned To mtaal => marvintm
2017-09-11 12:19 jorge-garcia Status new => scheduled
2017-09-11 15:21 hgbot Checkin
2017-09-11 15:21 hgbot Note Added: 0098946
2017-09-11 15:22 jorge-garcia Status scheduled => resolved
2017-09-11 15:22 jorge-garcia Fixed in Version => RR17Q4
2017-09-11 15:22 jorge-garcia Resolution open => fixed
2017-09-15 12:07 marvintm Status resolved => closed
2017-09-15 12:12 marvintm Note Added: 0099068
2017-10-23 15:18 hgbot Checkin
2017-10-23 15:18 hgbot Note Added: 0099996
2017-12-27 09:23 guilleaer Relationship added causes 0037550
2018-01-22 20:57 hgbot Checkin
2018-01-22 20:57 hgbot Note Added: 0101870
2019-01-01 15:15 malsasua Relationship added related to 0039864

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker