Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036523
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Cash upmajoralways2017-07-21 10:022017-11-22 13:57
ReporteraaroncaleroView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revision11dde8dc94db
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelPre packaging ( pi )
Regression date
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8 [^]
Triggers an Emergency PackNo
Summary

0036523: The financial account configuration for a payment method is not taken into account to create reconciliations in the cashup

DescriptionWhen a cashup is closed, transactions created during that cashup are reconciled adn the money is moved to the financial account defined on the Close events for each payment method.
The "automatic deposit" flag of the payment method defines if these reconciliations should be created or not.
This flag can be found on the generic Payment Method configuration, and also on the Financial Account Payment method configuration (which should override the generic configuration).

The problem is that in order to decide if reconciliations should be created or not, the generic configuration is being taken into account, instead of the configuration on the financial account.
Steps To ReproduceUsing White Valley sampledata:
Log in in backend, go to the Payment Method window, locate the "Wire Transfer" record (this is the Card payment method in webpos) and verify that the Automatic Deposit flag is checked.
Go to the Financial account window, locate the "Credit Card - Vall Blanca Store" record and on the Payment Method tab, verify that the Wire Transfer record is also configured as Automatic Deposit.
Go to the Organization window, Vall Blanca Store record, and on the Cash Management Events tab locate the "Credit Card - Close - Vall Blanca Store" record.


Log in in webpos, terminal VBS-1 and do a cashup to clear all values
Create a new ticket, add a product and complete the ticket paying with Card
Do another cashup.
Go to backend, POS Terminal window; select the VBS-1 record, go to the Payment Type tab, select Card and open the Reconciliation subtab. Verify that a new reconciliation has been created. Navigate to the reconciliation and verify that on the Cleared Items subtab there are two transactions (the payment and the movement to the Close Financial Account).

Go back to the Payment Method window, Wire Transfer record and uncheck the Automatic Deposit flag.
Go back to webpos, create a new ticket, pay it with card, and do another cashup.
Verify that this time, there is no new reconciliation created for the Card payment method, even if the configuration on the Financial Account window still flags the payment method as Automatic Deposit.
Proposed SolutionThe following line on the commit that causes the issue:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8#l1.14 [^]
reads the automatic deposit flag directly from the payment method, which is wrong.

At this point we have the information of the financial account and the payment method, so it should be easy to refactor that code to get the Automatic Deposit flag from the financial account configuration.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0037362RR17Q3.2 closedranjith_qualiantech_com The financial account configuration for a payment method is not taken into account to create reconciliations in the cashup 
causes defect 0037359 closedmarvintm Modulescript required to fix data caused by issue 36523 

-  Notes
(0098257)
hgbot (developer)
2017-07-28 09:26

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 11dde8dc94db70347d947817cb9b94b82abc67f9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jul 28 12:55:59 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/11dde8dc94db70347d947817cb9b94b82abc67f9 [^]

Fixed issue 36523 : Validate Payment method Automatic deposit with Financial account Payment method

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---

- Issue History
Date Modified Username Field Change
2017-07-21 10:02 aaroncalero New Issue
2017-07-21 10:02 aaroncalero Assigned To => Retail
2017-07-21 10:02 aaroncalero Resolution time => 1501797600
2017-07-21 10:02 aaroncalero Regression level => Pre packaging ( pi )
2017-07-21 10:02 aaroncalero Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3dbcb6b316eb645730de8604dbc5f2df21ef91d8 [^]
2017-07-21 10:02 aaroncalero Triggers an Emergency Pack => No
2017-07-27 08:47 ranjith_qualiantech_com Status new => scheduled
2017-07-28 09:26 hgbot Checkin
2017-07-28 09:26 hgbot Note Added: 0098257
2017-07-28 09:26 hgbot Status scheduled => resolved
2017-07-28 09:26 hgbot Resolution open => fixed
2017-07-28 09:26 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/11dde8dc94db70347d947817cb9b94b82abc67f9 [^]
2017-08-01 17:02 marvintm Assigned To Retail => ranjith_qualiantech_com
2017-08-08 16:03 marvintm Review Assigned To => marvintm
2017-08-08 16:03 marvintm Status resolved => closed
2017-08-08 16:03 marvintm Fixed in Version => RR17Q4
2017-11-22 13:14 maite Relationship added causes 0037359
2017-11-22 13:56 marvintm Status closed => new
2017-11-22 13:56 marvintm Resolution fixed => open
2017-11-22 13:56 marvintm Fixed in Version RR17Q4 =>
2017-11-22 13:57 marvintm Status new => scheduled
2017-11-22 13:57 marvintm Status scheduled => resolved
2017-11-22 13:57 marvintm Fixed in Version => RR17Q4
2017-11-22 13:57 marvintm Resolution open => fixed
2017-11-22 13:57 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker