Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0036515
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2017-07-19 20:292017-10-19 09:39
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revisionac8933ca2726
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036515: Improve BusinessPartner query performance removing location info from it

DescriptionImprove BusinessPartner query performance removing location info from it
Steps To ReproduceSee description
TagsPerformance
Attached Filesdiff file icon I36515_MobileCore_17Q1.diff [^] (1,655 bytes) 2017-08-02 08:49 [Show Content]
diff file icon I36515_Posterminal_17Q1.diff [^] (41,813 bytes) 2017-08-02 08:49 [Show Content]
diff file icon I36515_Returns_17Q1.diff [^] (5,070 bytes) 2017-08-02 08:49 [Show Content]
diff file icon I36515_PiMobile_17Q1.diff [^] (4,836 bytes) 2017-08-02 08:49 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
has duplicate defect 0037024 closedrqueralta Tax rate not properly recalculated when setting different customer to the ticket 
related to defect 0037542 closedranjith_qualiantech_com Is impossible to update a customer in hgvol environment 

-  Notes
(0098146)
hgbot (developer)
2017-07-20 12:40

Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 088483d6791da381a56b66d71edc2059de0ba4a1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jul 20 12:35:25 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/088483d6791da381a56b66d71edc2059de0ba4a1 [^]

Fixed issue 0036515: Improve BusinessPartner query performance removing location info from it

- Point to bp instead of pointing to bpl which no longer exists

---
M src/org/openbravo/retail/giftcards/master/BusinessPartnerProperties.java
---
(0098147)
hgbot (developer)
2017-07-20 12:40

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d758d76680f43ce8d34607a5d65cc3cf028c99ff
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jul 20 12:29:27 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d758d76680f43ce8d34607a5d65cc3cf028c99ff [^]

Fixed issue 0036515: Improve BusinessPartner query performance removing location info from it

- Saving a customer, Remove location to the check of outdated bp because locId is not always sent and ensure that locId exists to save/edit location.
- Remove from BusinessPartner query all code related to Business Partner Location
- When we need to load a customer from backend because it is not saved in local database, we also add the possibility to load a second address(billing/shipping)
- In datacustomeraddrsave.js, remove setting the address properties because it will be done in setBPandBPLoc
- businesspartner, load the address information that is not coming with bp model anymore and set and order to load it
- Save also the model of billing location to be able to save it in local database if it is not yet
- Remove all properties related to location in Business Partner model
- In setBPandBPLoc, set all location properties in bp object and save locations in local database if needed

---
M src/org/openbravo/retail/posterminal/CustomerLoader.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
M src/org/openbravo/retail/posterminal/master/BusinessPartnerProperties.java
M src/org/openbravo/retail/posterminal/master/LoadedCustomer.java
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
---
(0098148)
hgbot (developer)
2017-07-20 12:40

Repository: tools/automation/pi-mobile
Changeset: d8cbf9ac2c671d10cb76ccd9d9f07f7b66e1dba5
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jul 20 12:13:20 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d8cbf9ac2c671d10cb76ccd9d9f07f7b66e1dba5 [^]

Fixed issue 0036515: Improve BusinessPartner query performance removing location info from it

- Add an allow error of LogClientLoader to I34968_ReceiptPayOpenTicket because sometimes fails
- Adapt I34968_ReceiptPayOpenTicket to new change done (Retrieve to clientside business partners without a default address)

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/MobileCoreAPI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31484_ReceiptModifyCustomerAddProduct.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35931_SaveCorrectlyCustomerShipmentAndBillingInfo.java
---
(0098149)
hgbot (developer)
2017-07-20 12:40

Repository: erp/pmods/org.openbravo.retail.returns
Changeset: b78f80762d40bce7d125a839a900f8e068f8e6cd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jul 20 12:10:55 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/b78f80762d40bce7d125a839a900f8e068f8e6cd [^]

Fixed issue 0036515: Improve BusinessPartner query performance removing location info from it

- Loading the business partner, load the default bill address and set needed attributes in bp model
- If a bp is not in the local database, we load it from the backend(LoadCustomer.java). If we have different address for billing and shipping, we ask for the second address also.

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0098276)
hgbot (developer)
2017-07-31 14:58

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ac8933ca27260cee2263f1f8b6242d13f63ce570
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jul 27 17:07:23 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac8933ca27260cee2263f1f8b6242d13f63ce570 [^]

Fixed issue 0036515: Improve BusinessPartner query performance removing location info from it

- Do not show bps without any address
- Loading tickets after a reload could cause to load locationBillModel as an object instead of a Backbone model, convert it

---
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
---

- Issue History
Date Modified Username Field Change
2017-07-19 20:29 migueldejuana New Issue
2017-07-19 20:29 migueldejuana Assigned To => migueldejuana
2017-07-19 20:29 migueldejuana Triggers an Emergency Pack => No
2017-07-19 20:34 migueldejuana File Added: issue36515Giftcards.diff
2017-07-19 20:35 migueldejuana File Added: issue36515Pimobile.diff
2017-07-19 20:36 migueldejuana File Added: issue36515Returns.diff
2017-07-19 20:36 migueldejuana File Added: issue36515Posterminal.diff
2017-07-20 12:40 hgbot Checkin
2017-07-20 12:40 hgbot Note Added: 0098146
2017-07-20 12:40 hgbot Status new => resolved
2017-07-20 12:40 hgbot Resolution open => fixed
2017-07-20 12:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/088483d6791da381a56b66d71edc2059de0ba4a1 [^]
2017-07-20 12:40 hgbot Checkin
2017-07-20 12:40 hgbot Note Added: 0098147
2017-07-20 12:40 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/088483d6791da381a56b66d71edc2059de0ba4a1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d758d76680f43ce8d34607a5d65cc3cf028c99ff [^]
2017-07-20 12:40 hgbot Checkin
2017-07-20 12:40 hgbot Note Added: 0098148
2017-07-20 12:40 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d758d76680f43ce8d34607a5d65cc3cf028c99ff [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/d8cbf9ac2c671d10cb76ccd9d9f07f7b66e1dba5 [^]
2017-07-20 12:40 hgbot Checkin
2017-07-20 12:40 hgbot Note Added: 0098149
2017-07-20 12:40 hgbot Fixed in SCM revision http://code.openbravo.com/tools/automation/pi-mobile/rev/d8cbf9ac2c671d10cb76ccd9d9f07f7b66e1dba5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/b78f80762d40bce7d125a839a900f8e068f8e6cd [^]
2017-07-20 12:43 migueldejuana File Deleted: issue36515Giftcards.diff
2017-07-20 12:43 migueldejuana File Deleted: issue36515Pimobile.diff
2017-07-20 12:43 migueldejuana File Deleted: issue36515Returns.diff
2017-07-20 12:43 migueldejuana File Deleted: issue36515Posterminal.diff
2017-07-31 14:58 hgbot Checkin
2017-07-31 14:58 hgbot Note Added: 0098276
2017-07-31 14:58 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/b78f80762d40bce7d125a839a900f8e068f8e6cd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac8933ca27260cee2263f1f8b6242d13f63ce570 [^]
2017-08-02 08:48 jorge-garcia File Added: I36515_MobileCore.diff
2017-08-02 08:49 jorge-garcia File Deleted: I36515_MobileCore.diff
2017-08-02 08:49 jorge-garcia File Added: I36515_MobileCore_17Q1.diff
2017-08-02 08:49 jorge-garcia File Added: I36515_Posterminal_17Q1.diff
2017-08-02 08:49 jorge-garcia File Added: I36515_Returns_17Q1.diff
2017-08-02 08:49 jorge-garcia File Added: I36515_PiMobile_17Q1.diff
2017-09-08 14:38 marvintm Review Assigned To => marvintm
2017-09-08 14:38 marvintm Status resolved => closed
2017-09-08 14:38 marvintm Fixed in Version => RR17Q4
2017-10-19 09:39 malsasua Tag Attached: Performance
2017-11-06 13:14 jorge-garcia Relationship added has duplicate 0037024
2018-01-04 14:46 ranjith_qualiantech_com Relationship added related to 0037542


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker