Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0036508

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

always

2017-07-18 12:00

2017-07-24 11:29

Reporter

Orekaria

View Status

public

Assigned To

Orekaria

Priority

normal

Resolution

fixed

Fixed in Version

3.0PR17Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

alostale

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0036508: ant generate.java.doc marks the build as successful even if contained errors

Description

ant generate.java.doc marks the build as successful even if contained errors

continuous integration reports false negatives because errors are not being detected, e.g: https://ci.openbravo.com/job/int-inc-pgsql/ [^]

Steps To Reproduce

In the ERP folder
Execute ant generate.java.doc
Verify that, if the build contains errors, the build is set as successful (it should report build failed)

Proposed Solution

Apply the attached patch

Tags

No tags attached.

32290.patch [^] (952 bytes) 2017-07-18 12:01 [Show Content] [Hide Content]

# HG changeset patch
# User Rafa Alonso <ral@openbravo.com>
# Date 1500371226 -7200
#      Tue Jul 18 11:47:06 2017 +0200
# Node ID 7afa21c49b267e9e1b178bfdd87e497f3b84b6a6
# Parent  d5b16e274d2cc9602a9101ce3215f274be5a356e
Mark build as failed when 'ant generate.java.doc' report errors

diff -r d5b16e274d2c -r 7afa21c49b26 build.xml
--- a/build.xml	Thu Jun 08 21:26:48 2017 -0400
+++ b/build.xml	Tue Jul 18 11:47:06 2017 +0200
@@ -555,7 +555,7 @@ export.database: exports database struct
   </target>
 
   <target name="generate.java.doc">
-    <javadoc Windowtitle="${title}" access="protected" Header="${header}" Footer="${footer}" destdir="${build.docs}" maxmemory="1024M">
+    <javadoc Windowtitle="${title}" access="protected" Header="${header}" Footer="${footer}" destdir="${build.docs}" maxmemory="1024M" failonerror="yes">
       <sourcepath>
         <pathelement path="${base.src}" />
         <pathelement path="${base.src.test}/src" />

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0036524		closed	alostale	javadoc in pi has syntax error making javadoc command fail completely
related to	defect	0036532		closed	platform	javadoc warns when building with Java 8

Notes
(0098192) hgbot (developer) 2017-07-24 10:59	Repository: erp/devel/pi Changeset: 09b109e916b00539d6fbc10e1e93a5af9dc7a533 Author: Rafa Alonso <ral <at> openbravo.com> Date: Tue Jul 18 11:47:06 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/09b109e916b00539d6fbc10e1e93a5af9dc7a533 [^] fixed 36508: Mark build as failed when 'ant generate.java.doc' report errors --- M build.xml ---

(0098194) alostale (viewer) 2017-07-24 11:29	reviewed + tested

Issue History
Date Modified	Username	Field	Change
2017-07-18 12:00	staffrm	New Issue
2017-07-18 12:00	staffrm	Assigned To	=> platform
2017-07-18 12:00	staffrm	OBNetwork customer	=> No
2017-07-18 12:00	staffrm	Modules	=> Core
2017-07-18 12:00	staffrm	Triggers an Emergency Pack	=> No
2017-07-18 12:01	staffrm	File Added: 32290.patch
2017-07-18 12:12	staffrm	Summary	ant generate.java.doc marks the build as successfull even if contained errors => ant generate.java.doc marks the build as successful even if contained errors
2017-07-18 12:12	staffrm	Description Updated	View Revisions
2017-07-18 12:12	staffrm	Steps to Reproduce Updated	View Revisions
2017-07-18 12:16	staffrm	Description Updated	View Revisions
2017-07-21 11:09	shuehner	Relationship added	related to 0036524
2017-07-21 13:34	alostale	Assigned To	platform => alostale
2017-07-24 10:59	hgbot	Checkin
2017-07-24 10:59	hgbot	Note Added: 0098192
2017-07-24 10:59	hgbot	Status	new => resolved
2017-07-24 10:59	hgbot	Resolution	open => fixed
2017-07-24 10:59	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/09b109e916b00539d6fbc10e1e93a5af9dc7a533 [^]
2017-07-24 11:29	alostale	Review Assigned To	=> alostale
2017-07-24 11:29	alostale	Reporter	staffrm => Orekaria
2017-07-24 11:29	alostale	Assigned To	alostale => Orekaria
2017-07-24 11:29	alostale	Note Added: 0098194
2017-07-24 11:29	alostale	Status	resolved => closed
2017-07-24 11:29	alostale	Fixed in Version	=> 3.0PR17Q4
2017-07-26 08:22	alostale	Relationship added	related to 0036532

Copyright © 2000 - 2009 MantisBT Group