Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036466
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] 07. Sales managementmajoralways2017-07-11 17:172018-06-26 11:43
ReportermaiteView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version3.0PR18Q1
StatusclosedFix in branchFixed in SCM revisionf309cc3e47a9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036466: "Copy from order" process not compatible with high volumes

DescriptionIn case process is run in an environment with huge amount of orders (>=150k rows) it consumes 1.5GB of heap memory.
Steps To Reproduce1. Creates Sales Order document, set any BP and save
2. Run "Copy from Order" button and press selector. In case huge amount of orders exists in the system process will take long (or even not finish) consuming 1.5GB of heap memory.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 00373833.0PR18Q1 closedvmromanos API Change request 

-  Notes
(0100131)
markmm82 (viewer)
2017-10-29 17:44
edited on: 2017-11-01 14:49

 Sales Order Flows

---------------------------------
Test 1: Create From Order with Same Price List
Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = Acc-3 (Payment-Trx-Reconciliation)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Add a new line
  Product = Final Good C
  Ordered Quantity = 10
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = VAT 10% USA
Book The order
  Notice Total Net Amount = 20.00 and Total Gross Amount = 22.00

Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = Acc-3 (Payment-Trx-Reconciliation)
  Payment Terms = 90 days
  Warehouse = Spain East warehouse
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:1"
Verify there is 1 new line in the Lines tab.
  Line 10: Product = Final Good C, Ordered Qty = 10, UOM = Bag, Net Unit Price = 2.00 (took price defined in Customer A PL), Tax = Exempt 3%
Verify Order Total Net Amount = 20.00 and Total Gross Amount = 20.00, they match because no taxes are applied.


---------------------------------
Test 2: Create From Order line numbers generations
Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = Acc-3 (Payment-Trx-Reconciliation)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Add a new line
  Product = Final Good C
  Ordered Quantity = 10
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = VAT 10% USA
Book The order
  Notice Total Net Amount = 20.00 and Total Gross Amount = 22.00

Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = Acc-3 (Payment-Trx-Reconciliation)
  Payment Terms = 90 days
  Warehouse = Spain East warehouse
Add a new line
  Product = Final Good A
  Ordered Quantity = 10
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = VAT 10% USA
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:1"
Verify there is 1 new line in the Lines tab. Check the line number is 20 as there was a previously line in the order.
  Line 20: Product = Final Good C, Ordered Qty = 10, UOM = Bag, Net Unit Price = 2.00 (took price defined in Customer A PL), Tax = Exempt 3%
Verify Order Total Net Amount = 40.00 and Total Gross Amount = 42.00, they match because no taxes are applied.


----------------------------------------------------
Test 3: Create From Order with Different BP and Price Lists
Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = 1 (USA)
  Payment Terms = 30 days, 5
  Warehouse = USA warehouse
Add a new line
  Product = Laptop
  Ordered Quantity = 1
  UOM = Unit
  Net Unit Price = 1300.00
  Net List Price = 1300.00
  Tax = Exempt 10%
Book The order
  Notice Total Net Amount = 1300.00 and Total Gross Amount = 1300.00

Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer B
  Price List = Customer B
  Payment Method = 4 (USA)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:1"
Verify there is 1 new line in the Lines tab.
  Line 10: Product = Laptop, Ordered Qty = 1, UOM = Unit, Net Unit Price = 1250.00 (took price defined in Customer B PL), Tax = Exempt 10%
Verify Order Total Net Amount = 1250.00 and Total Gross Amount = 1250.00, they match because no taxes are applied.

----------------------------------------------------
Test 4: Create From Order with a Product without a price on the order Price List
Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = 1 (USA)
  Payment Terms = 30 days, 5
  Warehouse = USA warehouse
Add a new line
  Product = Service A
  Ordered Quantity = 25
  UOM = Day
  Net Unit Price = 2.00
  Net List Price = 500.00
  Tax = Exempt
Book The order
  Notice Total Net Amount = 1300.00 and Total Gross Amount = 1300.00

Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer B
  Price List = Customer B
  Payment Method = 1 (USA)
  Payment Terms =3 0 days, 5
  Warehouse = USA warehouse
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:1"
Verify there is 1 new line in the Lines tab.
  Line 10: Product = Service A, Ordered Qty = 25, UOM = Day, Net Unit Price = 0.00 (product price is not defined in Customer B PL), Tax = Exempt
Verify Order Total Net Amount = 0.00 and Total Gross Amount = 0.00.

----------------------------------------------------
Test 5: Create From Multiple Orders
Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = Acc-3 (Payment-Trx-Reconciliation)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Add a new line
  Product = Final Good A
  Ordered Quantity = 10
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = Exempt 3%
Book The order
  Notice Total Net Amount = 20.00 and Total Gross Amount = 20.00

Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer B
  Price List = Customer B
  Payment Method = 1 (USA)
  Payment Terms = 30 days, 5
  Warehouse = USA warehouse
Add a new line
  Product = Final Good C
  Ordered Quantity = 30
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = Exempt 3%
Book The order
  Notice Total Net Amount = 60.00 and Total Gross Amount = 60.00

Create a new Sales Order
  Organization = USA
  Transaction Document = Standard Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = Acc-3 (Payment-Trx-Reconciliation)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:2"
Verify there are 2 new line in the Lines tab.
  Line 10: Product Final Good A, Ordered Qty = 10, UOM = Bag, Net Unit Price = 2.00, Line Net Amount = 20, Tax = Exempt 3%
  Line 20: Product Final Good C, Ordered Qty = 30, UOM = Bag, Net Unit Price = 2.00, Line Net Amount = 60, Tax = Exempt 3%
 
  
Verify Order Total Net Amount = 80.00 and Total Gross Amount = 80.00
(0100174)
markmm82 (viewer)
2017-10-31 01:08
edited on: 2017-11-01 14:50

 Purchase Order Flow

---------------------------------
Test 1: Create From Order with Same Price List
Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Vendor A
  Price List = Purchase
  Payment Method = 1 (USA)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Add a new line
  Product = Raw Material A
  Ordered Quantity = 10
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = Exempt 10%
Book The order
  Notice Total Net Amount = 20.00 and Total Gross Amount = 20.00

Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = 1 (USA)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:1"
Verify there is 1 new line in the Lines tab.
  Line 10: Product = Raw Material A, Ordered Qty = 10, UOM = Bag, Net Unit Price = 2.00 (took price defined in Vendor A PL), Tax = Exempt 10%
Verify Order Total Net Amount = 20.00 and Total Gross Amount = 20.00.


---------------------------------
Test 2: Create From Orders line numbers generations
Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Vendor A
  Price List = Purchase
  Payment Method = 1 (USA)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Add a new line
  Product = Raw Material A
  Ordered Quantity = 10
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = Exempt 10%
Book The order
  Notice Total Net Amount = 20.00 and Total Gross Amount = 20.00

Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Customer A
  Price List = Customer A
  Payment Method = 1 (USA)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Add a new line
  Product = Raw Material B
  Ordered Quantity = 10
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = Exempt 10%
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:1"
Verify there is 1 new line in the Lines tab.
  Line 20: Product = Raw Material A, Ordered Qty = 10, UOM = Bag, Net Unit Price = 2.00 (took price defined in Vendor A PL), Tax = Exempt 10%
Verify Order Total Net Amount = 40.00 and Total Gross Amount = 40.00, they match because no taxes are applied.

----------------------------------------------------
Test 3: Create From Order with Different BP and Price Lists
Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Vendor A
  Price List = Purchase
  Payment Method = 1 (USA)
  Payment Terms = 30 days, 5
  Warehouse = USA warehouse
Add a new line
  Product = Raw Material A
  Ordered Quantity = 1
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = Exempt 10%
Book The order
  Notice Total Net Amount = 20.00 and Total Gross Amount = 20.00

Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Vendor B
  Price List = Price Including Taxes Purchase
  Payment Method = 4 (USA)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:1"
Verify there is 1 new line in the Lines tab.
  Line 10: Product = Raw Material A, Ordered Qty = 1, UOM = Bag, Net Unit Price = 3.00 (took price defined in Price Including Taxes Purchase PL), Tax = Exempt 10%
Verify Order Total Net Amount = 30.00 and Total Gross Amount = 30.00, they match because no taxes are applied.

----------------------------------------------------
Test 4: Create From Order with a Product without a price on the order Price List
Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Vendor A
  Price List = Purchase
  Payment Method = 1 (USA)
  Payment Terms = 30 days, 5
  Warehouse = USA warehouse
Add a new line
  Product = Service A
  Ordered Quantity = 25
  UOM = Day
  Net Unit Price = 2.00
  Net List Price = 50.00
  Tax = Exempt 10%
Book The order
  Notice Total Net Amount = 50.00 and Total Gross Amount = 50.00

Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Vendor A
  Price List = Purchase USA
  Payment Method = 1 (USA)
  Payment Terms = 30 days, 5
  Warehouse = USA warehouse
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:1"
Verify there is 1 new line in the Lines tab.
  Line 10: Product = Service A, Ordered Qty = 25, UOM = Day, Net Unit Price = 0.00 (product price is not defined in Purchase USA PL), Tax = Exempt
Verify Order Total Net Amount = 0.00 and Total Gross Amount = 0.00.

----------------------------------------------------
Test 5: Create From Multiple Orders
Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Vendor A
  Price List = Purchase
  Payment Method = 1 (USA)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Add a new line
  Product = Raw material A
  Ordered Quantity = 10
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = Exempt 10%
Book The order
  Notice Total Net Amount = 20.00 and Total Gross Amount = 20.00

Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Vendor B
  Price List = Purchase
  Payment Method = 1 (USA)
  Payment Terms = 30 days, 5
  Warehouse = USA warehouse
Add a new line
  Product = Raw material C
  Ordered Quantity = 30
  UOM = Bag
  Net Unit Price = 2.00
  Net List Price = 2.00
  Tax = Exempt 10%
Book The order
  Notice Total Net Amount = 60.00 and Total Gross Amount = 60.00

Create a new Purchase Order
  Organization = USA
  Transaction Document = Purchase Order
  Business Partner = Purchase
  Price List = Purchase
  Payment Method = 1 (USA)
  Payment Terms = 90 days
  Warehouse = USA warehouse
Execute Create From Orders process
Select previously created orders and press DONE.
Check a success message is shown:
  "Process completed successfully
   Number of records copied:2"
Verify there are 2 new line in the Lines tab.
  Line 10: Raw material A, Ordered Qty = 10, UOM = Bag, Net Unit Price = 2.00, Line Net Amount = 20, Tax = Exempt 10%
  Line 20: Raw material C, Ordered Qty = 30, UOM = Bag, Net Unit Price = 2.00, Line Net Amount = 60, Tax = Exempt 10%
 
Verify Order Total Net Amount = 80.00 and Total Gross Amount = 80.00
(0100759)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: f309cc3e47a9f30cc689198b1bedeffef9f181e2
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Oct 23 15:59:09 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/f309cc3e47a9f30cc689198b1bedeffef9f181e2 [^]

Fixes issue 36466: "Copy from order" refactor to Process Definition

Currently the process "Copy From Order" is defined as a manual process and does
not make use of the benefits of Process Definition. The current process logic
was migrated to a new Process Definition, using the Pick and Edit (PE) pattern
in those windows that currently use it.

Was created a new Pick and Execute window. Defined a new tab with the same fields
that the old process.

Was created a new Process Definition using previously windows as parameter and
updated all the buttons that were using the "Create From Order" process to use
the new process definition "Create From Orders".

Was created a new action handler to process the selection of the orders. It
iterates through all the selected orders and add their lines to the order that
executes the process.

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_WINDOW.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src-db/database/sourcedata/OBUIAPP_REF_WINDOW.xml
A src/org/openbravo/common/actionhandler/CopyFromOrders.java
---
(0100760)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: 3a4539f9f3bcfc4db7add0a5123e9da9b3d75385
Author: Mark <markmm82 <at> gmail.com>
Date: Sun Oct 22 20:42:12 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/3a4539f9f3bcfc4db7add0a5123e9da9b3d75385 [^]

Related to issue 36466: Clean up of old Copy From Order process.

After refactoring the manual Copy From process to the new Copy From Orders Process
Definition, all the old process references in the database are deleted. Also other
unused files has been removed.

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_PROCESS.xml
R src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.html
R src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.java
R src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.xml
R src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder_data.xsql
---
(0100761)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: fcd1919908329c794ab8e63365809e379981b52d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Oct 27 12:55:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fcd1919908329c794ab8e63365809e379981b52d [^]

Related to Issue 36466. Code Review Changes:

* Synchronized Terminology and exported database
* Added new non editable Legal Entity Parameter in Process Definition
  to be able to show Orders for Organizations that belong to that legal entity
* Copy from Orders Process splitted in Handler, Process and classes that implement
  the calculations logic
* Copy From Orders Action Handler handles the request and the response and calls
  Copy From Orders Process to perform the logic
* Copy From Orders Process loops through the Orders and through the Order Lines
  and calls the classes that implement the logic for the calculations.
  It also explodes the non-Stocked BOM Products
* Copy From Orders Implementation Interface is the interface that must be
  implemented by the classes that implements the logic for the calculations
* Several classes created to perform the calculations related to amounts, taxes,
  prices, etc
* Added a Hook at the end of Copy From Orders Process
* Fixed wrong prices calculation
* Fixed wrong amounts calculation
* Fixed exception handling
* Added times taken for processing the orders in the log
* Added missing fields when copying OrderLines

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
A src/org/openbravo/common/actionhandler/CopyFromOrdersActionHandler.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessFilterExpression.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessImplementationInterface.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateOrderLineInformation.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdatePricesAndAmounts.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateProductAndAttributes.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateQuantitiesAndUOMs.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateTax.java
R src/org/openbravo/common/actionhandler/CopyFromOrders.java
---
(0100762)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: 1bbaeeba15217a73f12c7671d028619caa9d9b98
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Oct 31 18:49:37 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/1bbaeeba15217a73f12c7671d028619caa9d9b98 [^]

Related to Issue 36466: Removed database references to Copy From Order process

Removed other database references for old Copy From Order process in Sample datas

---
M modules/org.openbravo.v3.datasets/referencedata/standard/V3_Roles.xml
M referencedata/sampledata/F_B_International_Group/AD_PROCESS_ACCESS.xml
M referencedata/sampledata/QA_Testing/AD_PROCESS_ACCESS.xml
---
(0100763)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: d83b8e92caa92fdbeb93172a7f0a9a244a75f43e
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Nov 02 10:50:52 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/d83b8e92caa92fdbeb93172a7f0a9a244a75f43e [^]

Related to issue 36466: JS Beautified.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
---
(0100764)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: 9194d7d51fc6171168a9e9ad8e4e86955ac82ea9
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Nov 07 13:48:45 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/9194d7d51fc6171168a9e9ad8e4e86955ac82ea9 [^]

Related to issue 36466: Synchronize Terminology done

---
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
---
(0100765)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: 8a532f52b24b6b00c9baea80d47cd72efaf2949e
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Nov 14 20:25:18 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/8a532f52b24b6b00c9baea80d47cd72efaf2949e [^]

Related to issue 36466: Avoid NPE when copyFromOrdersProcessHooks isn't defined

When the CopyFromOrdersProcess class is instantiated directly, for instance in an
automated test, it is possible that copyFromOrdersProcessHooks wasn't initialized
and a NPE is thrown due that.

---
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
---
(0100766)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: 689a684ce416b9de0f72c2f0302a6d8faab8ed59
Author: Mark <markmm82 <at> gmail.com>
Date: Sat Nov 18 17:13:32 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/689a684ce416b9de0f72c2f0302a6d8faab8ed59 [^]

Related to issue 36466: Validate an attribute instance using Attribute defined
in the Attribute Use List of the attribute set instead of iterate on
the attribute instances list.

---
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateProductAndAttributes.java
---
(0100767)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: e768162fb145a1fec6149215fc7902926c33e9aa
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Nov 21 20:34:55 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/e768162fb145a1fec6149215fc7902926c33e9aa [^]

Related to issue 36466: Fixed operative quantity calculation

Recalculated the operative quantity instead based on the ordered quantity.
The ordered quantity can't be changed because it value:
-Was already calculated based on the operative quantity and the defined conversion
 rate if AUM preference was enabled.
-Was defined in the order line and the operative quantity is not defined if the
 AUM preference was not defined.

---
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateQuantitiesAndUOMs.java
---
(0100768)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: b94a1efa6ad9f406e4cc1a5e5b08cdff63725af5
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Nov 22 14:23:26 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/b94a1efa6ad9f406e4cc1a5e5b08cdff63725af5 [^]

Related to issue 36466: jUnit Automated Tests for Copy From Orders process

---
A src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/BPartnerDataConstants.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestConstants.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_13.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_14.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_15.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_16.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_17.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_18.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_19.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_20.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPerformance.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_01.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_02.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_03.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_04.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_05.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_06.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_07.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_08.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_21.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_22.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/CopyLinesFromOrdersTestData.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/JSONUtils.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/OrderData.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/OrderLineData.java
---
(0100769)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: 784edf9354ef92981d6599474ca2ecb59e8c8b41
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 23 13:21:13 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/784edf9354ef92981d6599474ca2ecb59e8c8b41 [^]

Related to issue 36466: Added Copy From Orders tests to AllAntTaskTests

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
---
(0100770)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: 816e3d3873009a834ee145d6c022bfa8fe3c4e64
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 23 13:22:23 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/816e3d3873009a834ee145d6c022bfa8fe3c4e64 [^]

Related to issue 36466: Use standard way to detect UOM Management,
This change fixes issues in Oracle

---
M src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
---
(0100771)
hgbot (developer)
2017-11-28 11:42

 Repository: erp/devel/pi
Changeset: bade85561054b1257150f9da1fafe0de70513865
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 23 13:35:02 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bade85561054b1257150f9da1fafe0de70513865 [^]

Related to issue 36466: Renamed package classes

---
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateOrderLineInformation.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdatePricesAndAmounts.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateProductAndAttributes.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateQuantitiesAndUOMs.java
A src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateTax.java
R src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateOrderLineInformation.java
R src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdatePricesAndAmounts.java
R src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateProductAndAttributes.java
R src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateQuantitiesAndUOMs.java
R src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateTax.java
---
(0100772)
hgbot (developer)
2017-11-28 11:43

 Repository: erp/devel/pi
Changeset: 4b31c7bb92a55a8b96d8f0b8c655f51c9e484482
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 23 18:41:31 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4b31c7bb92a55a8b96d8f0b8c655f51c9e484482 [^]

Related to issue 36466: Hooks are also run for the core's process

This allows a simplification in the code, as it doesn't differenciate between internal and external hooks.
Even more, external processes can be injected at any point in the process.

The interface has been extended to provide an execution order for the hooks.

JUnit tests have been adapted:
1. To support CDI with parametrized tests
2. To include all the information required by the test in the CopyLinesFromOrdersTestData object itself

---
M src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_13.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_14.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_15.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_16.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_17.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_18.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_19.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_20.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPerformance.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_01.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_02.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_03.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_04.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_05.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_06.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_07.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_08.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_21.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_22.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CopyLinesFromOrdersTestData.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessImplementationInterface.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateOrderLineInformation.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdatePricesAndAmounts.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateProductAndAttributes.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateQuantitiesAndUOMs.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateTax.java
---
(0100773)
hgbot (developer)
2017-11-28 11:43

 Repository: erp/devel/pi
Changeset: ef8b3a6923a9227048ac2833646ba8a5b8f3cb16
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 24 10:37:46 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ef8b3a6923a9227048ac2833646ba8a5b8f3cb16 [^]

Related to issue 36466: Fixed javadoc

---
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessImplementationInterface.java
---
(0100774)
hgbot (developer)
2017-11-28 11:43

 Repository: erp/devel/pi
Changeset: a518ac506bfc3ebb62cf81fd6b37ada529f2590d
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 24 10:43:09 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a518ac506bfc3ebb62cf81fd6b37ada529f2590d [^]

Related to issue 36466: Avoid overriding setUp()

---
M src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
---
(0100775)
hgbot (developer)
2017-11-28 11:43

 Repository: erp/devel/pi
Changeset: adcc673b8471c44f06cedd6c328108fcaef03e9b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 24 11:40:58 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/adcc673b8471c44f06cedd6c328108fcaef03e9b [^]

Related to issue 36466: Fixed NPE in some JUnit tests

---
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_07.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_08.java
---
(0100776)
hgbot (developer)
2017-11-28 11:43

 Repository: erp/devel/pi
Changeset: a066d6531e758b9898f524f4cd2cd16f6ff4a010
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 24 12:54:43 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a066d6531e758b9898f524f4cd2cd16f6ff4a010 [^]

Related to issue 36466: code review improvements

CopyFromOrdersProcess.java:
  Added order by lineNo when retrieving order lines, so we create lines in the same order as the original Order.
  Renamed private method to describe better its purpose.

CopyFromOrdersProcessFilterExpression.java:
  Added missed copyright information.
  Moved logic to a separate private method.

---
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessFilterExpression.java
---
(0100777)
hgbot (developer)
2017-11-28 11:43

 Repository: erp/devel/pi
Changeset: 6a1aacf3dad14061f0f85cf63463ae10b247acd2
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 24 12:59:29 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6a1aacf3dad14061f0f85cf63463ae10b247acd2 [^]

Related to issue 36466: Use Proxy to improve performance

---
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessFilterExpression.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateOrderLineInformation.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateQuantitiesAndUOMs.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateTax.java
---
(0100778)
hgbot (developer)
2017-11-28 11:43

 Repository: erp/devel/pi
Changeset: 0f89b6c5f8c762380c21621ea5432e37c5aa28d6
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Nov 24 13:41:43 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0f89b6c5f8c762380c21621ea5432e37c5aa28d6 [^]

Related to issue 36466: renamed some fields

The button has been renamed to Copy from Orders
The organization field in P&E has been renamed to Legal Entity Organization

---
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
---
(0100779)
hgbot (developer)
2017-11-28 11:43

 Repository: erp/devel/pi
Changeset: c3db8193990984c6aefce48c63835bbee31ab5f5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Sat Nov 25 17:04:05 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c3db8193990984c6aefce48c63835bbee31ab5f5 [^]

Related to issue 36466: Code review improvements

Removed onLoad function on process and use the standard Default Expression at field level.
Deleted unnecessary messages
Fixed javadoc in CopyFromOrdersProcessImplementationInterface

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessFilterExpression.java
M src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessImplementationInterface.java
---
(0100784)
hgbot (developer)
2017-11-28 12:42

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 2e19722f8f966ff89fd3f4f3dde1aa6451cee857
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Nov 28 12:40:54 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/2e19722f8f966ff89fd3f4f3dde1aa6451cee857 [^]

Related to issue 36466: updated retail sampledata
Removed references to deleted AD_PROCESS_ID -800165-

---
M referencedata/sampledata/The_White_Valley_Group/AD_PROCESS_ACCESS.xml
---
(0100785)
hgbot (developer)
2017-11-28 13:39

 Repository: erp/devel/pi
Changeset: f234a5824549196d7443d28a628e51ad2afbf5b8
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Nov 28 13:20:38 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f234a5824549196d7443d28a628e51ad2afbf5b8 [^]

Related to issue 36466: Updated V3 Roles dataset

Added new process definition to Sales and Finance Roles

---
M modules/org.openbravo.v3.datasets/referencedata/standard/V3_Roles.xml
M modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_DATASET.xml
---
(0100786)
hgbot (developer)
2017-11-28 13:39

 Repository: erp/devel/pi
Changeset: eaf9a111fa5dab8a069aad8532eaba88b8b7a333
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Nov 28 13:34:32 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/eaf9a111fa5dab8a069aad8532eaba88b8b7a333 [^]

Related to issue 36466: modified sampledata

Added access to new process definition

---
M referencedata/sampledata/F_B_International_Group/AD_WINDOW_ACCESS.xml
M referencedata/sampledata/F_B_International_Group/OBUIAPP_PROCESS_ACCESS.xml
M referencedata/sampledata/QA_Testing/AD_WINDOW_ACCESS.xml
M referencedata/sampledata/QA_Testing/OBUIAPP_PROCESS_ACCESS.xml
---
(0100787)
hgbot (developer)
2017-11-28 13:39

 Repository: erp/devel/pi
Changeset: 9e541631f122fa26d5059a28bda8d94df8513646
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Nov 28 13:38:10 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9e541631f122fa26d5059a28bda8d94df8513646 [^]

Related to issue 36466: Updated V3 Roles dataset

Added access to Copy From Orders P&E window

---
M modules/org.openbravo.v3.datasets/referencedata/standard/V3_Roles.xml
M modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_DATASET.xml
---
(0100789)
hgbot (developer)
2017-11-28 16:44

 Repository: erp/devel/pi
Changeset: de1aa58eeeac3323af9fc9634d82b56931de0655
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Nov 28 16:44:09 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/de1aa58eeeac3323af9fc9634d82b56931de0655 [^]

Related to issue 36466: Adapted test to work with AWO

AWO module already defines the UomManagement property.
This changeset modifies the preference inside the module as required by the test flows.
In case no preference is found, the test creates a new one.

---
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CopyLinesFromOrdersTestData.java
---
(0100792)
hgbot (developer)
2017-11-28 17:20

 Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: 87a870a9e343fca23aa9cba86c50ddcdd00f67db
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Nov 28 17:13:19 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/87a870a9e343fca23aa9cba86c50ddcdd00f67db [^]

Related to issue 36466: updated retail sampledata
Removed references to deleted AD_PROCESS_ID -800165-

---
M referencedata/sampledata/Retail_Test/AD_PROCESS_ACCESS.xml
---
(0100829)
hgbot (developer)
2017-11-30 12:09

 Repository: erp/devel/pi
Changeset: f952b45f0c6c585aa5b4e724e422e26ec97e7dda
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 30 12:08:20 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f952b45f0c6c585aa5b4e724e422e26ec97e7dda [^]

Related to issue 36466: Fixed retail's ci due to duplicate UPC

---
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_18.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_06.java
---
(0100884)
hgbot (developer)
2017-12-01 11:18

 Repository: erp/devel/pi
Changeset: f96b66a5e5ad48bf3b2770ec0018162b97b5429f
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Nov 30 16:38:33 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/f96b66a5e5ad48bf3b2770ec0018162b97b5429f [^]

Related to issue 36466: Fixed preferences conflicts with AWO

To avoid possible conflicts with other tests using the UomManagement preference
the Copy From Orders tests related with the AUM functionality were adapted to save
the status of the preference at the start of the tests, and restore it after the
all the tests are executed.

Is taken into account if the preference exists in the database, and in case the
preference exists also is restored its value. This way, at the tests ending, it
left the preference status as expected by other tests.

Also was created a new class to manage all the actions related with the preference.
Some of existing methods were moved to it, and other were created.

---
M src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_01.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_21.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_22.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CopyLinesFromOrdersTestData.java
A src-test/src/org/openbravo/test/copyLinesFromOrders/data/UOMManagementUtil.java
---
(0100887)
hgbot (developer)
2017-12-01 11:37

 Repository: erp/devel/pi
Changeset: 03feee46a26b12cb69a1be88df3b2abe5b5395da
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Dec 01 11:36:50 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/03feee46a26b12cb69a1be88df3b2abe5b5395da [^]

Related to issue 36466: removed unused variable

---
M src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_01.java
---
(0101467)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101468)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101469)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101470)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101471)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101472)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101473)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101474)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101475)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101476)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101477)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101478)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101479)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101480)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101481)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101482)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101483)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101484)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101485)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101486)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101487)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101488)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101489)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101490)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101492)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101502)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101507)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101509)
hudsonbot (viewer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0102636)
hgbot (developer)
2018-02-22 17:24

 Repository: tools/automation/int
Changeset: dafcacfb14d37de7101bb6c1b179e04a09d95ac0
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Oct 31 17:48:25 2017 -0400
URL: http://code.openbravo.com/tools/automation/int/rev/dafcacfb14d37de7101bb6c1b179e04a09d95ac0 [^]

Related to issue 36466: Add some automated tests

Automated tests for Copy From Order process refactor.
It tests the new Copy From Orders process for the sales and purchase flows.

---
M src-test/com/openbravo/test/integration/erp/gui/procurement/transactions/purchaseorder/PurchaseOrderHeaderTab.java
M src-test/com/openbravo/test/integration/erp/gui/sales/transactions/salesorder/HeaderTab.java
M src-test/com/openbravo/test/integration/erp/testscripts/procurement/transactions/PurchaseOrder.java
M src-test/com/openbravo/test/integration/erp/testscripts/sales/transactions/SalesOrder.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/copyfromorder/CFPO_CopyFromMultipleOrders.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/copyfromorder/CFPO_DifferentBPandPriceList.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/copyfromorder/CFPO_NextLineNoTest.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/copyfromorder/CFPO_ProductPriceNotDefinedInPL.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/copyfromorder/CFPO_SamePriceList.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/copyfromorder/CFPO_Suite.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/copyfromorder/CFSO_CopyFromMultipleOrders.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/copyfromorder/CFSO_DifferentBPandPriceList.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/copyfromorder/CFSO_NextLineNoTest.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/copyfromorder/CFSO_ProductPriceNotDefinedInPL.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/copyfromorder/CFSO_SamePriceList.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/copyfromorder/CFSO_Suite.java
---
(0102637)
hgbot (developer)
2018-02-22 17:24

 Repository: tools/automation/int
Changeset: 7bf614ddaccbf195cb2553013277e560f0a21129
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Nov 28 10:11:07 2017 -0500
URL: http://code.openbravo.com/tools/automation/int/rev/7bf614ddaccbf195cb2553013277e560f0a21129 [^]

Related to issue 36466: Take into account the order line creation

As the Copy From Orders process creates the order lines in the same order they
were created on the orders wich they are copied from, it is validate the expected
order line information taking into account this rule.

---
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/copyfromorder/CFPO_CopyFromMultipleOrders.java
---

- Issue History
Date Modified Username Field Change
2017-07-11 17:17 maite New Issue
2017-07-11 17:17 maite Assigned To => Triage Finance
2017-07-11 17:17 maite OBNetwork customer => Yes
2017-07-11 17:17 maite Modules => Core
2017-07-11 17:17 maite Triggers an Emergency Pack => No
2017-07-11 17:17 maite Issue Monitored: networkb
2017-10-05 16:15 markmm82 Assigned To Triage Finance => markmm82
2017-10-05 16:16 markmm82 Status new => acknowledged
2017-10-06 17:39 markmm82 Status acknowledged => scheduled
2017-10-29 17:44 markmm82 Note Added: 0100131
2017-10-31 01:05 markmm82 Note Edited: 0100131 View Revisions
2017-10-31 01:08 markmm82 Note Added: 0100174
2017-11-01 14:49 markmm82 Note Edited: 0100131 View Revisions
2017-11-01 14:50 markmm82 Note Edited: 0100174 View Revisions
2017-11-24 13:56 vmromanos Relationship added depends on 0037383
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100759
2017-11-28 11:42 hgbot Status scheduled => resolved
2017-11-28 11:42 hgbot Resolution open => fixed
2017-11-28 11:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f309cc3e47a9f30cc689198b1bedeffef9f181e2 [^]
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100760
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100761
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100762
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100763
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100764
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100765
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100766
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100767
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100768
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100769
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100770
2017-11-28 11:42 hgbot Checkin
2017-11-28 11:42 hgbot Note Added: 0100771
2017-11-28 11:43 hgbot Checkin
2017-11-28 11:43 hgbot Note Added: 0100772
2017-11-28 11:43 hgbot Checkin
2017-11-28 11:43 hgbot Note Added: 0100773
2017-11-28 11:43 hgbot Checkin
2017-11-28 11:43 hgbot Note Added: 0100774
2017-11-28 11:43 hgbot Checkin
2017-11-28 11:43 hgbot Note Added: 0100775
2017-11-28 11:43 hgbot Checkin
2017-11-28 11:43 hgbot Note Added: 0100776
2017-11-28 11:43 hgbot Checkin
2017-11-28 11:43 hgbot Note Added: 0100777
2017-11-28 11:43 hgbot Checkin
2017-11-28 11:43 hgbot Note Added: 0100778
2017-11-28 11:43 hgbot Checkin
2017-11-28 11:43 hgbot Note Added: 0100779
2017-11-28 12:42 hgbot Checkin
2017-11-28 12:42 hgbot Note Added: 0100784
2017-11-28 13:39 hgbot Checkin
2017-11-28 13:39 hgbot Note Added: 0100785
2017-11-28 13:39 hgbot Checkin
2017-11-28 13:39 hgbot Note Added: 0100786
2017-11-28 13:39 hgbot Checkin
2017-11-28 13:39 hgbot Note Added: 0100787
2017-11-28 16:44 hgbot Checkin
2017-11-28 16:44 hgbot Note Added: 0100789
2017-11-28 17:20 hgbot Checkin
2017-11-28 17:20 hgbot Note Added: 0100792
2017-11-30 12:09 hgbot Checkin
2017-11-30 12:09 hgbot Note Added: 0100829
2017-12-01 11:18 hgbot Checkin
2017-12-01 11:18 hgbot Note Added: 0100884
2017-12-01 11:37 hgbot Checkin
2017-12-01 11:37 hgbot Note Added: 0100887
2017-12-01 13:21 vmromanos Review Assigned To => vmromanos
2017-12-01 13:21 vmromanos Status resolved => closed
2017-12-01 13:21 vmromanos Fixed in Version => 3.0PR18Q1
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101467
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101468
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101469
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101470
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101471
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101472
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101473
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101474
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101475
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101476
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101477
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101478
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101479
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101480
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101481
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101482
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101483
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101484
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101485
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101486
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101487
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101488
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101489
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101490
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101492
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101502
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101507
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101509
2018-02-22 17:24 hgbot Checkin
2018-02-22 17:24 hgbot Note Added: 0102636
2018-02-22 17:24 hgbot Checkin
2018-02-22 17:24 hgbot Note Added: 0102637
2018-06-26 11:30 hgbot Checkin
2018-06-26 11:30 hgbot Note Added: 0105390
2018-06-26 11:43 hgbot Checkin
2018-06-26 11:43 hgbot Note Added: 0105433
2018-06-26 13:48 gorka_gil Note Deleted: 0105390
2018-06-26 13:48 gorka_gil Note Deleted: 0105433

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker