Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036431 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2017-07-06 13:08 | 2017-07-07 12:38 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 0a461eef07c3 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036431: Cleanup logging (modules/platform part) using or mentioned printStackTrace or System.*.print* | |||||||
| Description | As part of getting better logging all uses of i.e. printStackTrace or System.*.print* should be avoided whenever possible. This issue tracks such bad usage in ERP platform code. | |||||||
| Steps To Reproduce | cd modules grep -IrE '(System.(err|out)|printStackTrace)' . | grep -v src-test | less | |||||||
| Proposed Solution | Convert them to use proper log4j | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  32143.hgexport [^] (4,071 bytes) 2017-07-06 13:19 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0097943) hgbot (developer) 2017-07-07 12:33 |
Repository: erp/devel/pi Changeset: 0a461eef07c36ded143a2203bdbf51a32c54d8b0 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Thu Jul 06 13:18:39 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/0a461eef07c36ded143a2203bdbf51a32c54d8b0 [^] Fixed 36431. Cleanup logging: Removes uses of printStackTrace + System.*.print* Cleanup some uses of bad logging + mention of same in comments. In case of CryptoUtiliy, delete main method having bad usages (api-change). --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/StandardWindowComponent.java M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java M src-core/src/org/openbravo/utils/CryptoUtility.java M src/org/openbravo/dal/security/EntityAccessChecker.java --- |
|
(0097945) alostale (manager) 2017-07-07 12:38 |
reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-07-06 13:08 | shuehner | New Issue | |
| 2017-07-06 13:08 | shuehner | Assigned To | => shuehner |
| 2017-07-06 13:08 | shuehner | Modules | => Core |
| 2017-07-06 13:08 | shuehner | Triggers an Emergency Pack | => No |
| 2017-07-06 13:08 | shuehner | Relationship added | related to 0036162 |
| 2017-07-06 13:16 | shuehner | Relationship added | related to 0036432 |
| 2017-07-06 13:19 | shuehner | File Added: 32143.hgexport | |
| 2017-07-07 12:33 | hgbot | Checkin | |
| 2017-07-07 12:33 | hgbot | Note Added: 0097943 | |
| 2017-07-07 12:33 | hgbot | Status | new => resolved |
| 2017-07-07 12:33 | hgbot | Resolution | open => fixed |
| 2017-07-07 12:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/0a461eef07c36ded143a2203bdbf51a32c54d8b0 [^] |
| 2017-07-07 12:33 | alostale | Review Assigned To | => alostale |
| 2017-07-07 12:38 | alostale | Note Added: 0097945 | |
| 2017-07-07 12:38 | alostale | Status | resolved => closed |
| 2017-07-07 12:38 | alostale | Fixed in Version | => 3.0PR17Q4 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |